Patch Detail
Show a patch.
GET /api/1.1/patches/19302/?format=api
{ "id": 19302, "url": "https://patchwork.libcamera.org/api/1.1/patches/19302/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19302/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231209022227.595197-1-pobrn@protonmail.com>", "date": "2023-12-09T02:22:28", "name": "[libcamera-devel,v1] libcamera: framebuffer_allocator: Remove unnecessary `clear()`", "commit_ref": "b1b798ef68ea84b02e986b8463442f3fad2ce269", "pull_url": null, "state": "accepted", "archived": false, "hash": "ef8e88fde3ae2babf86644dfd2b436dfd46ca2d5", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19302/mbox/", "series": [ { "id": 4111, "url": "https://patchwork.libcamera.org/api/1.1/series/4111/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4111", "date": "2023-12-09T02:22:28", "name": "[libcamera-devel,v1] libcamera: framebuffer_allocator: Remove unnecessary `clear()`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4111/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19302/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19302/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0235CC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 9 Dec 2023 02:22:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D91762B30;\n\tSat, 9 Dec 2023 03:22:41 +0100 (CET)", "from mail-40133.protonmail.ch (mail-40133.protonmail.ch\n\t[185.70.40.133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48E6761D96\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 9 Dec 2023 03:22:39 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702088561;\n\tbh=FmS/PL7f0qPrU43Mtczhnk8DEjNYg3opfi1zr9rRxKo=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=V7ETOW31bSrtSNke1/0IAnQ4IC06nh5XyPLT+wMXVj2RoXE8UbkqXvBcyRhDCBOaU\n\tGvVllT+sDRior+6prB/mbQNkgCZxBzecqnVoCmjyoN5+wWDDC4FqWrqCjkEQrsvvjw\n\tNBj/FGaf2IKIcjInypIUNFEgljkB7CoeYblfq6cVip26slUfdAYGNE62w6j0CfWqur\n\tohdBPt5q4tsnhKwOdjCHxlEWFKjcmGBs9Pe6dKBYHtWuSS3szAB/jKtYndYhDUHFwX\n\t2SBRq8U2gAHqPTXPHWbQZ8YPE2rm6Sks5gmIKKRPm2gzNN3p64+6orHRvq7tFX6deo\n\tVLLke4pVFyRtw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1702088557; x=1702347757;\n\tbh=FmS/PL7f0qPrU43Mtczhnk8DEjNYg3opfi1zr9rRxKo=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=CDPnXbsMdd5qA4SGBLVvGgMNsYrz/SUTzE/RME6qyb1vcVX1S1b1+ZCIDoG4Bz4zt\n\trpj55GGp1XMu2Eu02eLiDvZrpw+Rn5s/PEtgJt4QRVf3w/XSEgXElGo2xhfev2Q20l\n\tRUNgDB9UQ62NKLPDGsRGt0R9p2edmK5NAbFNTX3qzL+4Vj+t3ta57iJHSn4G50KLZs\n\tqG3msVrUo+iPXOaCYngTxyhSoKVObsrnPH1XGdSEANq/TpbQ8AjwmV5AC8HHffvOGf\n\tAsqXVKkYbhZ5uwJ3+ojbUwdXwKoPqg2oHeRKqyWq1iZ3LY2JVFEVXMxJi8IU6ilV1N\n\tOTpgIF7ogZRCQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"CDPnXbsM\"; dkim-atps=neutral", "Date": "Sat, 09 Dec 2023 02:22:28 +0000", "To": "libcamera-devel@lists.libcamera.org", "Message-ID": "<20231209022227.595197-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[libcamera-devel] [PATCH v1] libcamera: framebuffer_allocator:\n\tRemove unnecessary `clear()`", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The vector in question is destroyed when the item in the `buffers_` map\nis destroyed as a result of the `erase()` call. A vector's destructor\nalready does all the things that `clear()` does,\nso calling it earlier is not needed.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/libcamera/framebuffer_allocator.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp\nindex dabd9219..94389735 100644\n--- a/src/libcamera/framebuffer_allocator.cpp\n+++ b/src/libcamera/framebuffer_allocator.cpp\n@@ -121,8 +121,6 @@ int FrameBufferAllocator::free(Stream *stream)\n \tif (iter == buffers_.end())\n \t\treturn -EINVAL;\n \n-\tstd::vector<std::unique_ptr<FrameBuffer>> &buffers = iter->second;\n-\tbuffers.clear();\n \tbuffers_.erase(iter);\n \n \treturn 0;\n", "prefixes": [ "libcamera-devel", "v1" ] }