Patch Detail
Show a patch.
GET /api/1.1/patches/19301/?format=api
{ "id": 19301, "url": "https://patchwork.libcamera.org/api/1.1/patches/19301/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19301/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231207214337.16199-1-laurent.pinchart@ideasonboard.com>", "date": "2023-12-07T21:43:37", "name": "[libcamera-devel] meson: Replace hack with usage of '@BASENAME@'", "commit_ref": "41d6e6e5c166c267e7a15a7b0c1d930bddcbc6b8", "pull_url": null, "state": "accepted", "archived": false, "hash": "4417daf2853a4006ea01d4468720188b2e0705e2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19301/mbox/", "series": [ { "id": 4110, "url": "https://patchwork.libcamera.org/api/1.1/series/4110/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4110", "date": "2023-12-07T21:43:37", "name": "[libcamera-devel] meson: Replace hack with usage of '@BASENAME@'", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4110/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19301/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19301/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7427BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Dec 2023 21:43:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 347E262B32;\n\tThu, 7 Dec 2023 22:43:33 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D002629E1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Dec 2023 22:43:32 +0100 (CET)", "from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CCD4BB2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Dec 2023 22:42:50 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701985413;\n\tbh=hh5JG2mCGT4JhFbToYqD1QWuPYtH4fvhlvRmNJ6txjc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=xJbsTkYXBTBJ2Cpk8MEmehC5/5e7SDTToUumzlXMgNrAa0pwgp0Q3IMhqmBEMrWzp\n\tUp1xSZsf2uXivlY1lvqbQeeTvXrvy1Uen9tUyx7rTmjr8TZngH6SEYF9WvgU2pb81q\n\tuNe0g/FS6iHjLbtSCynaC0TD46MphVkPEEMbAehfhp1KqwdTb3c8+SfnULXg91dwgb\n\tX74Tuiw8T5fXdAdfcxdEOBCBgIrzRGWpAcT1+tsQefLcfSRdArDpcgkK04uQnvpkVb\n\tGSvUDC4tfsiImxocIgk62seULiUJ4lggyvnczu9sHFGjD5dQutmOERg6jiL8Q3cq25\n\t1AsXjxbrH2ZsQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701985370;\n\tbh=hh5JG2mCGT4JhFbToYqD1QWuPYtH4fvhlvRmNJ6txjc=;\n\th=From:To:Subject:Date:From;\n\tb=fdNTaeXYQMfPcbb6uD3iEvYlleoK8p9HWQ117pWHD0UemCVbKPWIEqDujmW0IZFkm\n\tVPVbCd2BK8A8qUSM2vfefJaobXlrLPH7dj0Tf1d3bJUEAR0gX1ErIFbFTah+1SmhoQ\n\tOFIaE+GIYM0Agnptraht9ByL8w8pt6GLkjvz7hyw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fdNTaeXY\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 7 Dec 2023 23:43:37 +0200", "Message-ID": "<20231207214337.16199-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.41.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] meson: Replace hack with usage of\n\t'@BASENAME@'", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Starting with meson 0.59, the custom_target() function substitutes\n'@BASENAME@' in the output parameter with the input file name, with the\nextension removed. This is exactly what we implement manually when\ngenerating the IPA interface .cpp files.\n\nFurthermore, starting with meson 0.60, the 'name' positional parameter\nto the custom_target() function is optional, and defaults to the\nbasename of the output file (including the extension). This is exactly\nthe name we compute manually and pass to the function.\n\nAs libcamera requires meson 0.60 or newer, we can depend on those two\nfeatures and drop manual computation of the base name. This fixes a\nwarning with recent meson versions that complain that passing a file\nobject to the format() function is a broken feature:\n\nWARNING: Broken features used:\n * 1.3.0: {'str.format: Value other than strings, integers, bools, options, dictionaries and lists thereof.'}\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/ipa/meson.build | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)\n\n\nbase-commit: 1c56d2a2cd2dcca86272675e21bbb1770d32db1f", "diff": "diff --git a/src/libcamera/ipa/meson.build b/src/libcamera/ipa/meson.build\nindex 4469524060de..ef73b3f98816 100644\n--- a/src/libcamera/ipa/meson.build\n+++ b/src/libcamera/ipa/meson.build\n@@ -3,13 +3,10 @@\n libcamera_ipa_interfaces = []\n \n foreach file : ipa_mojom_files\n- name = '@0@'.format(file).split('/')[-1].split('.')[0]\n-\n # {pipeline}_ipa_interface.cpp\n libcamera_ipa_interfaces += \\\n- custom_target(name + '_ipa_interface_cpp',\n- input : file,\n- output : name + '_ipa_interface.cpp',\n+ custom_target(input : file,\n+ output : '@BASENAME@_ipa_interface.cpp',\n command : [\n mojom_docs_extractor,\n '-o', '@OUTPUT@', '@INPUT@'\n", "prefixes": [ "libcamera-devel" ] }