Patch Detail
Show a patch.
GET /api/1.1/patches/19296/?format=api
{ "id": 19296, "url": "https://patchwork.libcamera.org/api/1.1/patches/19296/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19296/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231206210524.20974-3-laurent.pinchart@ideasonboard.com>", "date": "2023-12-06T21:05:20", "name": "[libcamera-devel,2/6] test: log: log_process: Fix uninitialized variable on process exit failure", "commit_ref": "db3147743368b14b3ed218cb3f6026cb7963d77c", "pull_url": null, "state": "accepted", "archived": false, "hash": "0e36c9e1f7e4bc9d19953547dcc0439030f8a9e4", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19296/mbox/", "series": [ { "id": 4109, "url": "https://patchwork.libcamera.org/api/1.1/series/4109/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4109", "date": "2023-12-06T21:05:18", "name": "test: Miscellaneous fixes and improvements for unit tests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4109/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19296/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19296/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E204C32BC\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Dec 2023 21:05:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BC93629E3;\n\tWed, 6 Dec 2023 22:05:22 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4D5F61D9E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Dec 2023 22:05:20 +0100 (CET)", "from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B697CE45\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Dec 2023 22:04:39 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701896722;\n\tbh=Sh2/l5RBOsroloGi5qyXJC0ChhAApGVlQ/WjFwco3rQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=L2svlrDGPw8zVZsyoQkvytRcVc7MyW7ra1K7VqySDH/uaIDZbjBbIuq4SxOqtBydm\n\tLW6FFwU5tTD41NVeF7fkBZPNVtKov3cAAH1jxdVNHDsRLieW52+CH6RuM/K0amz9BT\n\tofF75IjXzJbWKXllMYJw2zO5KTk/ltBknmHVtqSv1S5ltl1l/tVzl+NL02nhtN7Q5S\n\t+Qj7WcifBykKWozfSzzUWJ2NHDWoukUGdwmkVlbGyVDEd4TMfmM6PswtqeUZqFq0Es\n\t5oyeJDJTCzI+KgrxQlCxTTsjcX6ACkb8oHZ0eynw8WBkGIxgV+D4qvxKnvsE0D6pTd\n\tieSAeIC1EW4eQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701896679;\n\tbh=Sh2/l5RBOsroloGi5qyXJC0ChhAApGVlQ/WjFwco3rQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=nn8vOd4FfVqlTSoAkp/zgRR8POv0wgP7yVbD0GjmUp8BPjYynKx+puXndHq4kzo+i\n\t9WafvCevTG/k+63hySxpi5m6iGAi9LNYOKxLZsZ+YAqggiEbh36hzwuHNL02clkwBi\n\tLaOD62mLZUlB4sKRXEH2kHssqD5T7eRoEzlnANxE=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nn8vOd4F\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Dec 2023 23:05:20 +0200", "Message-ID": "<20231206210524.20974-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.41.0", "In-Reply-To": "<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>", "References": "<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/6] test: log: log_process: Fix\n\tuninitialized variable on process exit failure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If the process fails to exit before the timeout, the\nLogProcessTest::exitStatus_ variable gets used uninitialized. Fix it by\ninitializating to Process::NotExited.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/log/log_process.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\nindex 17af7d74a1d5..f7635b70255c 100644\n--- a/test/log/log_process.cpp\n+++ b/test/log/log_process.cpp\n@@ -139,7 +139,7 @@ private:\n \tProcessManager processManager_;\n \n \tProcess proc_;\n-\tProcess::ExitStatus exitStatus_;\n+\tProcess::ExitStatus exitStatus_ = Process::NotExited;\n \tstring logPath_;\n \tint exitCode_;\n \tint num_;\n", "prefixes": [ "libcamera-devel", "2/6" ] }