Patch Detail
Show a patch.
GET /api/1.1/patches/19258/?format=api
{ "id": 19258, "url": "https://patchwork.libcamera.org/api/1.1/patches/19258/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19258/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231130155323.13259-3-jaslo@ziska.de>", "date": "2023-11-30T15:43:09", "name": "[libcamera-devel,v2,2/3] gstreamer: Add GstLibcameraSrcState::clearRequests method", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1dc241bb143ccd859baf926e8171e78bca053e0d", "submitter": { "id": 173, "url": "https://patchwork.libcamera.org/api/1.1/people/173/?format=api", "name": "Jaslo Ziska", "email": "jaslo@ziska.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19258/mbox/", "series": [ { "id": 4093, "url": "https://patchwork.libcamera.org/api/1.1/series/4093/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4093", "date": "2023-11-30T15:43:07", "name": "gstreamer: Implement renegotiation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4093/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19258/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19258/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FEE7BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Nov 2023 15:54:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16B3A629D2;\n\tThu, 30 Nov 2023 16:54:41 +0100 (CET)", "from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de\n\t[85.215.255.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 373D6629C2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Nov 2023 16:54:40 +0100 (CET)", "from archlinux.fritz.box by smtp.strato.de (RZmta 49.9.7 AUTH)\n\twith ESMTPSA id n54b84zAUFsd0SC\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))\n\t(Client did not present a certificate);\n\tThu, 30 Nov 2023 16:54:39 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701359681;\n\tbh=1HZaUVHwFT/CmpGGSepQsclpDntj8ie64ONJ4vpQrGE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SADluEfhT1lHyp5wSr2cF95+LcglC+9T/b1inawDTIocAizXqPNhgxCGppFr8FfDx\n\tAtxmC0oELtd555fRJW8lxiFT01zJzj3Wm0+Y2Vfkt+KSdHNoRgZwYgQc6eV+d8BHME\n\t8jpjZK6EF1JLzfnhlJCXKLPxqT0E0rFr5LeU720mCAkOZx88RKqYrafscLCSZddwpr\n\tcK6Pv1A+HG+6oyK9Jp/YrqhPD7M25m0dl8tGxz7CTXw4Fukbqk0heB5QH7YmQ4V2qW\n\tQJQeIgqJtUlZJ/rGlrNYr690BvXgvUJbjv0WPgC/0r0DHThWg9beTXVJrTUwQFFfdU\n\t232BjKGRRKHtw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; t=1701359679;\n\ts=strato-dkim-0002; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=D892LkJsjJS9MKLBSKREEFYt7G0gICXHM6Cbxck3a9M=;\n\tb=Fn0Uf66n2P9iDnzyJOCIFVgpSs30SwO6Iv18iZJ3wtHZ3f1UyfcIUJHtoEgcT44BpH\n\tMRAbrMgq25jnnjcprwhlV8JV/sNK6WY6xc1odWl90aqRAUYg07Gj6Nwx3FIHqFKdTK+J\n\t9T1K9QbvgMxHUbeYGKzwlo2eNlCbphmY6+o7d5ox7oJbdLIDC7Q2Uj9fKp1vY59fEIi6\n\t4zoNeK3VP9zJedp2ZHH82YTf8kMwXDtKQHWovwa94jdBdvl2lndVeFiJu21O3fuOqAov\n\tKqP7fY7BFr+kMy91kiO8u6Ui0DyM+LlFCIpkOZY0faIVnhYL5+Jvdz7rdQ1djXXDOWQy\n\tAiZA==", "v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1701359679;\n\ts=strato-dkim-0003; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=D892LkJsjJS9MKLBSKREEFYt7G0gICXHM6Cbxck3a9M=;\n\tb=UR3PWXVPitQUBRUOb2w3S2azeCMCP9pYfZE+2O3+TS1utHGv0ITb5ijUl5ncN9ycE2\n\tKTfLhNTxaG/9Y6EE0vDw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"Fn0Uf66n\"; \n\tdkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"UR3PWXVP\"; dkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1701359679; cv=none;\n\td=strato.com; s=strato-dkim-0002;\n\tb=TE1VDV0D/L0F/vjDmMzITu5VtdO1IrLln4RIK8IAZJlDn9uMVHjmh6bGqRHUTG0Dzd\n\tdQTf/3SuUyWL5d93exUlei7e0FZqnePVfr7k5Sv/UU4OaO7C8K/HR1KTmtp7WlWlAKgk\n\t6d8Juvgmpyw28x4qPJdrxH+J11+YNzh9W9pPYy1QBmPzloE1+HJ9OnquywSwFJyU8ItR\n\t+gtVWfPuipWPCq0b5Ij2UbbDNfmE7Obo5BR31az744dg7oU86UmIvLewQlze1W04HP7N\n\tCDhyCebYciDE2/7TdzN/OU8mYICZ1c80LgvJRnvfiWseLd43UXyBAtcbTXFc9wBKxTtW\n\tDniA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; t=1701359679;\n\ts=strato-dkim-0002; d=strato.com;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=D892LkJsjJS9MKLBSKREEFYt7G0gICXHM6Cbxck3a9M=;\n\tb=bO2FkWWYCsQiTSVujU+AV7r4rfdsHvk+yfm2L+LrTgsTEBDM7wFru3M9EI9nzKliH1\n\tRCPXBR/Pk4s/VTpEcz7Zp8YnqErBghcFlq2P0BWRlWQXibXiE6u1r1WR9urwnHKZzobV\n\tHMoq830YGXh+5bQjuxtkxp1bmncerexhuGJi4QjCxf/+Kn5gsxsZrwGZxPGBy2w/RN88\n\tRE2gUpyvLHEHa6Ss8o80N5ZlxPni46f29tmx4eVxOs4YAMOZwZti3b2lY+YqwDaritKw\n\tDVDTeqt3mmk9pkLpc4XRHUH6Bs1dGrfsZuqgQhM6dSfY4CtbYdZKHKoJzQyehQgQCLUS\n\t9niQ==", "ARC-Authentication-Results": "i=1; strato.com;\n arc=none;\n dkim=none", "X-RZG-CLASS-ID": "mo00", "X-RZG-AUTH": "\":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cH04q6BfJa07bS3ov6I8QOM/V5x+uTrCUtBrk=\"", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Nov 2023 16:43:09 +0100", "Message-ID": "<20231130155323.13259-3-jaslo@ziska.de>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20231130155323.13259-1-jaslo@ziska.de>", "References": "<20231130155323.13259-1-jaslo@ziska.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "[libcamera-devel] [PATCH v2 2/3] gstreamer: Add\n\tGstLibcameraSrcState::clearRequests method", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jaslo Ziska via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jaslo Ziska <jaslo@ziska.de>", "Cc": "Jaslo Ziska <jaslo@ziska.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a clearRequests method to GstLibcameraSrcState which clears the\nGstLibcameraSrcState::completedRequests_ queue.\n\nUse this new method in gst_libcamera_src_task_leave instead of doing it\nmanually.\n\nSigned-off-by: Jaslo Ziska <jaslo@ziska.de>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex e57ba52f..d448a750 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -133,6 +133,7 @@ struct GstLibcameraSrcState {\n \tint queueRequest();\n \tvoid requestCompleted(Request *request);\n \tint processRequest();\n+\tvoid clearRequests();\n };\n \n struct _GstLibcameraSrc {\n@@ -318,6 +319,12 @@ int GstLibcameraSrcState::processRequest()\n \treturn err;\n }\n \n+void GstLibcameraSrcState::clearRequests()\n+{\n+\tGLibLocker locker(&lock_);\n+\tcompletedRequests_ = {};\n+}\n+\n static bool\n gst_libcamera_src_open(GstLibcameraSrc *self)\n {\n@@ -629,11 +636,7 @@ gst_libcamera_src_task_leave([[maybe_unused]] GstTask *task,\n \tGST_DEBUG_OBJECT(self, \"Streaming thread is about to stop\");\n \n \tstate->cam_->stop();\n-\n-\t{\n-\t\tGLibLocker locker(&state->lock_);\n-\t\tstate->completedRequests_ = {};\n-\t}\n+\tstate->clearRequests();\n \n \t{\n \t\tGLibRecLocker locker(&self->stream_lock);\n", "prefixes": [ "libcamera-devel", "v2", "2/3" ] }