Patch Detail
Show a patch.
GET /api/1.1/patches/19246/?format=api
{ "id": 19246, "url": "https://patchwork.libcamera.org/api/1.1/patches/19246/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19246/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231129160853.1081623-1-bbrotherton@google.com>", "date": "2023-11-29T16:07:45", "name": "[libcamera-devel,v3] libcamera: pipeline: Fix c++20 compile warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "57fecadbfb9da14c76e62b03e5a52618daa0cfd4", "submitter": { "id": 174, "url": "https://patchwork.libcamera.org/api/1.1/people/174/?format=api", "name": "Brett Brotherton", "email": "bbrotherton@google.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19246/mbox/", "series": [ { "id": 4089, "url": "https://patchwork.libcamera.org/api/1.1/series/4089/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4089", "date": "2023-11-29T16:07:45", "name": "[libcamera-devel,v3] libcamera: pipeline: Fix c++20 compile warning", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4089/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19246/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19246/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EDA8C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 29 Nov 2023 16:09:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A47E1629C2;\n\tWed, 29 Nov 2023 17:09:02 +0100 (CET)", "from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com\n\t[IPv6:2607:f8b0:4864:20::b4a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14C3961DA8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Nov 2023 17:09:01 +0100 (CET)", "by mail-yb1-xb4a.google.com with SMTP id\n\t3f1490d57ef6-db4004a8aa9so7930949276.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Nov 2023 08:09:00 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701274142;\n\tbh=mKFxOEbwlAkRu4YHf8cosw/2ZO3ItEd1PxFCYOE9f8U=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=1ha8+zO/6UOY8Zod34RXZWWtguSJpUDWCc7MNAlwfVvrB2eWBdaFFi8X1MJ6TO/qa\n\tZxtMmfNt92o6hBpOxYSkLotCnUWYN0uE/bD2K6m7UDzX89XvNVn0si0nXIs8sxnF8n\n\txEXXwTUZVJolmwTR3mT+alcqDeFQFTxSVsz2ua5vKpDbMz4bmdobKEHJViinjM6iVh\n\tPJzzXd52Sf8z5U+A1sAc5B1nlJJE61tZ72FfW3BFc8bL2OImZjKL5zZ2NEheUSekSX\n\tcabVeATmwyYWVUoMFx7aOFYka5ATWMNMZK4Qm41FkzqgpbiQBJBQYN8V0zFEEO4UqG\n\tOTMHaCbd4rjxA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20230601; t=1701274140; x=1701878940;\n\tdarn=lists.libcamera.org; \n\th=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=RJbGtPmruI7s2SROQdEAcjnknxp8YyW6h2owVRpJMCQ=;\n\tb=Sec711f3QOHpv45q3gIYE2k0dMWayQM4M+78Em3quJMVNSw4x1isMeS+po3NhLmCqi\n\teXyQyiGhZeWaYGRelVonlhaMyGCKoHzC9o92F6m7xyr6g/Tt25+TFrcDUBNlDbLGGdJW\n\taFkNw0pC5Jx2EOZWlYyZi37ENv/uFnlXpz2jRDWOwe/9FJIgnE2Fs+/7xmoVseev9cbB\n\tclLuAJqD/i+J67rNKtWYG6C+77G89med/oe52RfUh/Zv8rxOXkAy2be6X3g6+Qz8zFXw\n\trQDZHOTRLSxIAlqPXoNw8SUQu9sgZLbQ96wW+/aM4hAj3rP7/phn2ulWXjMQRtFAZ/zA\n\tX6gA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=google.com\n\theader.i=@google.com header.b=\"Sec711f3\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701274140; x=1701878940;\n\th=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=RJbGtPmruI7s2SROQdEAcjnknxp8YyW6h2owVRpJMCQ=;\n\tb=kWRYYGwYD+YTrB/t+LNRRfQGdChl2F4WTCASsT+uzqB9bFOE8ZTBtgfkXDKdKCkctN\n\tIFssCwsB2g7gYKnN+bsexmd+KZGmn9HvPzamwYLiUrIE4dy9vS9dxE2mJCa8Z/SDK0DK\n\tGH3ssgMY2x37+6JJwmN7W+POALEC0XOv+BjBrfrdBEPeh+no1+Qi2YduWClpTupJsXb5\n\tmtI6O/zku8wbD5+d7o1LS9V+/UZP/vuJ2PIIjbNDABcJ6sNZWyjf+DUwMuBLKvZPOIrZ\n\tWvSUarCp6z6MSp2THg0gShHU7ZaX+HtsNqUuezIYSS+osSoSYTmfVFljznQtqvHKW9h8\n\tfFjw==", "X-Gm-Message-State": "AOJu0YwGEyDfg6eiDEOV2brzQarhG1tKkhr0eO87LjNm8+dtTYk3e6Xr\n\txjiGnDqzELp9AdvzpqXJOZQQve/YiM3dmOws3BioahV0ymYFX/XfDRt7vD5vZqROIF8cs33xdHG\n\tiH1JjtUlXXp3zvMEYTqs+X0jE3W9T0fFBS6ithJYAkxVCttRx5blq7patrdz4duikf5x3N6BZQc\n\tLO2oKg3qFP3pK8a7Ay", "X-Google-Smtp-Source": "AGHT+IFQADkC+vKk2op29ohZ/hO3yEd0n7H9oQGTASwnV6WCWGNNt6C6G5s/54e+uY/TJEwRyj+QxmGtJ6SucKEE1A==", "X-Received": "from bbrotherton-ws.bld.corp.google.com\n\t([2620:15c:183:200:1044:db30:1b61:3292])\n\t(user=bbrotherton job=sendgmr) by 2002:a25:6f8b:0:b0:db3:f436:5714\n\twith SMTP\n\tid k133-20020a256f8b000000b00db3f4365714mr625918ybc.0.1701274139619;\n\tWed, 29 Nov 2023 08:08:59 -0800 (PST)", "Date": "Wed, 29 Nov 2023 09:07:45 -0700", "Mime-Version": "1.0", "X-Mailer": "git-send-email 2.43.0.rc1.413.gea7ed67945-goog", "Message-ID": "<20231129160853.1081623-1-bbrotherton@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Content-Type": "text/plain; charset=\"UTF-8\"", "Subject": "[libcamera-devel] [PATCH v3] libcamera: pipeline: Fix c++20 compile\n\twarning", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Brett Brotherton via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Brett Brotherton <bbrotherton@google.com>", "Cc": "Brett Brotherton <bbrotherton@google.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix -Wdeprecated-this-capture error when building with c++20 by\nexplicity naming this in the capture.\n\nSigned-off-by: Brett Brotherton <bbrotherton@google.com>\n---\n\nSorry about that here is updated patch that orrects formatting in the\ncommit message. \n\n src/libcamera/pipeline_handler.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 9c74c6cf..29e0c98a 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr<Camera> camera)\n */\n void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n {\n-\tmedia->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n+\tmedia->disconnected.connect(this, [this, media] { mediaDeviceDisconnected(media); });\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "v3" ] }