Patch Detail
Show a patch.
GET /api/1.1/patches/19226/?format=api
{ "id": 19226, "url": "https://patchwork.libcamera.org/api/1.1/patches/19226/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19226/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231122191753.42997-1-jaslo@ziska.de>", "date": "2023-11-22T19:15:47", "name": "[libcamera-devel] gstreamer: Fix unused variable error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4dc0e0cf47256709ccc54896a2fae350fcf5388b", "submitter": { "id": 173, "url": "https://patchwork.libcamera.org/api/1.1/people/173/?format=api", "name": "Jaslo Ziska", "email": "jaslo@ziska.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19226/mbox/", "series": [ { "id": 4080, "url": "https://patchwork.libcamera.org/api/1.1/series/4080/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4080", "date": "2023-11-22T19:15:47", "name": "[libcamera-devel] gstreamer: Fix unused variable error", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4080/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19226/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19226/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24663C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 22 Nov 2023 19:18:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D5FB629AF;\n\tWed, 22 Nov 2023 20:18:32 +0100 (CET)", "from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de\n\t[85.215.255.23])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9358161DAD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Nov 2023 20:18:30 +0100 (CET)", "from archlinux.fritz.box by smtp.strato.de (RZmta 49.9.1 AUTH)\n\twith ESMTPSA id j3f4eezAMJITp3b\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))\n\t(Client did not present a certificate);\n\tWed, 22 Nov 2023 20:18:29 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700680712;\n\tbh=59v+a/FTyMvp+MuBJRimSb9rgQZfiw/dkVF06RqOx6A=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=4iIpf6n+XxDxXyn7hmgWQKX0gcZhG15zo9U1FKqdtsUSAWWYKgQnOIixqMUZYIs3s\n\tXdlX5m/nmKroan2aEi5nbfI3hMdN6HW3mdCZS2fjAh1YpVs1FH0gFK9We1omOlDdv1\n\t6wIGDlri5dg+UrOvJxF/PvI3eiAGO+r9C2MpyuPuxIIzS+rSraK5ConfxAmEXAyeS9\n\t+C314r8deAkq4+gQtGe5qSWi12eP/ygFCpX8aFi0M8/SefsGuzfz9RudkheAW7l7qH\n\t4jrZTH0JXDZzEx8E+pZGeYIoRGb+PCI+5aonjJWAoGNOw0vbZUs7DDgICLQO0YFMtd\n\tNOf6MBfev+gog==", "v=1; a=rsa-sha256; c=relaxed/relaxed; t=1700680710;\n\ts=strato-dkim-0002; d=ziska.de;\n\th=Message-ID:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender;\n\tbh=7s+XcEQbuwnmKsZQDfvVdBoZIbBvqjHeoqJJAcyIKfk=;\n\tb=mKTVijjS6I0Swfi1gRFsxZnUPneaZsGKNOLdxqkOUhiKKNWNXfCUrgcOlBbLHeMYW/\n\tF1CqjT5czniqCMNGpB1fnRTNn8HUM+HNo7GxMTG2q9Ku716hc3Q5lOUK1HRMm2hwWYDv\n\tLP9G1dZrQR0L/nGzyhsfEdhLsB29DzDunTU1xOiRxvFywMFWAfiTEdVq8sNUhqjD2O5n\n\tpqU2h9xt3WBCOVtzJHZxOaEz8baDL9sdFrNgcehpd146g0Mund8CTITX860r+UyqdGzC\n\tzNCV1NhNppgbYPHs1CVL0FqjausdSjUMozZpWXzygoXj/ScBXyc7COrQ2GZt27cqbGon\n\t3ejA==", "v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1700680710;\n\ts=strato-dkim-0003; d=ziska.de;\n\th=Message-ID:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender;\n\tbh=7s+XcEQbuwnmKsZQDfvVdBoZIbBvqjHeoqJJAcyIKfk=;\n\tb=N2ZkKLcseZXhx/GTraJW5rTPsTzImHB1jC+KHHIx2MaHQRbim4dytjFNJW9nTB8Hun\n\tj4+QDUZvt19Ws2FqyIDw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"mKTVijjS\"; \n\tdkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"N2ZkKLcs\"; dkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1700680710; cv=none;\n\td=strato.com; s=strato-dkim-0002;\n\tb=ch1qE1odl++v7Cwm4ENTrP7ZH43Qa9b2EDfjJ7Lvlx4udJ/hPoajb+e0uCqOpX05x2\n\tUTHYJFyRz7ajf5jEekyl58WBZ55UhjUQc5/1XGc2J7zn3MUtQf/R8Ut3kWIklQQgdFHZ\n\tSJYfBKXnBRIDvX7r/e07XotoncjpGw+VJos0pgunmb8Eqc41EzBb6Q0oxnv/E6FLt1Yk\n\tdG2nyZwsAqHDxh+IARpNOe2XwsdHuzU8FTlehjyErCwa5eF4TA9G9a2j9e50H9dB8HzN\n\tQNq+mpbgdh8eVTpji4ry1c5ZDc2WlfVBSpq7LxvWwVcCkAfcK2e6Ec8+GGQiLKcyJycb\n\tcd8A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; t=1700680710;\n\ts=strato-dkim-0002; d=strato.com;\n\th=Message-ID:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender;\n\tbh=7s+XcEQbuwnmKsZQDfvVdBoZIbBvqjHeoqJJAcyIKfk=;\n\tb=johOaJ9z+fDst2t5PSLz00E4diGQ5RCfQ4Wikgs/V+QA9O10GZj3IZS4UIg0syxaTh\n\t7NqRwF+e5JJtjt7Id9ES8KA5zliwzvSQf2jxZ632PYhu7Fq3WD+wHm6HswgigkDI/e3U\n\t3CP5PhwSnvOBVKlwbN1LWeEvbqoE66pqjQWKtkH9gRTc7Iqg3fHk5VsEB74EMlQZGit7\n\tm/AqHx9GhtSYbZzMVBt9Q/GOEuiaUcYgTIBopaZFTXPPx++BDVvzG+awryMBwHOoft67\n\tTjnMqqlgOktwkXtftawCovZSuxD+afqDoqTGojzPLHKvPQmgCC0ql/bo9DQl952I98Ow\n\tpcNw==", "ARC-Authentication-Results": "i=1; strato.com;\n arc=none;\n dkim=none", "X-RZG-CLASS-ID": "mo00", "X-RZG-AUTH": "\":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cHhoq7VPJQVrv/Pjz9vWwFKVwtgQho0fFAdiY=\"", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 22 Nov 2023 20:15:47 +0100", "Message-ID": "<20231122191753.42997-1-jaslo@ziska.de>", "X-Mailer": "git-send-email 2.42.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "[libcamera-devel] [PATCH] gstreamer: Fix unused variable error", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jaslo Ziska via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jaslo Ziska <jaslo@ziska.de>", "Cc": "Jaslo Ziska <jaslo@ziska.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix unused variable error introduced in fd84180d.\n---\nThis patch fixes the unused variable error raised by Laurent.\n\n src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.42.1", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 767017db..b0eb2dd7 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -765,7 +765,7 @@ gst_libcamera_src_send_event(GstElement *element, GstEvent *event)\n\n \tswitch (GST_EVENT_TYPE(event)) {\n \tcase GST_EVENT_EOS: {\n-\t\tg_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);\n+\t\t[[maybe_unused]] g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);\n\n \t\tret = TRUE;\n \t\tbreak;\n", "prefixes": [ "libcamera-devel" ] }