Patch Detail
Show a patch.
GET /api/1.1/patches/19208/?format=api
{ "id": 19208, "url": "https://patchwork.libcamera.org/api/1.1/patches/19208/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19208/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231113165244.480925-1-bbrotherton@google.com>", "date": "2023-11-13T16:52:44", "name": "[libcamera-devel] libcamera: pipeline: fix c++20 compile warning", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "925ccd8682d9f3dc7e8e66db02b81a8a9e1744e1", "submitter": { "id": 174, "url": "https://patchwork.libcamera.org/api/1.1/people/174/?format=api", "name": "Brett Brotherton", "email": "bbrotherton@google.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19208/mbox/", "series": [ { "id": 4073, "url": "https://patchwork.libcamera.org/api/1.1/series/4073/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4073", "date": "2023-11-13T16:52:44", "name": "[libcamera-devel] libcamera: pipeline: fix c++20 compile warning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4073/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19208/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19208/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1180BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Nov 2023 18:08:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AA4C629BC;\n\tMon, 13 Nov 2023 19:08:13 +0100 (CET)", "from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com\n\t[IPv6:2607:f8b0:4864:20::1149])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 174A1629A9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Nov 2023 17:52:51 +0100 (CET)", "by mail-yw1-x1149.google.com with SMTP id\n\t00721157ae682-5b02ed0f886so65107207b3.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Nov 2023 08:52:50 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1699898893;\n\tbh=k+VUAaJ9MHeliVkF1oj3Fd+vNppti6pW6hUdGNFIcAY=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=RhsPrGi4Bc2AAQRFlmSzmtKM/Ml5SkT9UXwkVkxyS3zrqmiZwTWWEKY/NaRPicxhs\n\t8dNKljrIsgS+sTEiTzvGF3Pj6krWqI0LAnupR8uSuPyh9BBho6C+sLJgBYDR1dtCjb\n\tEjJI+QFFRUymp9DpEYuOdJ1I86M16qTc/YuzHYPqEmhSc0BkJOtH185aEohr4LLMdT\n\tQ1tfbSzqQlPmPvo/fVFoX0yYdDHo+BBYDiVYKBw7m/2EPIix2JyNMLGxTNWjC22CBm\n\te0Sxypf4oauV7NdxnaRc45N1MPy6BedGv48kJ8uVW9MiX8c1aMXD6bgehRUW6dB44w\n\trHt+P7yjCZpfg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20230601; t=1699894369; x=1700499169;\n\tdarn=lists.libcamera.org; \n\th=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=yE/zVCqVkqbFBjaA5vxIIWwj2mesrlsKe5E9GsDJqbg=;\n\tb=sBkJHZDge9MzOAk8xZJ6mhgP90txERz/DMgPw61kKgWlTmqamhGxsbZkUxCiy8CDm9\n\tTHK0WdilIsgijQIFaaHM3HZ4wmGIesa5s6e7p42l8ogpt+jZff+prgLiLrD7wfhSuykD\n\tVYWrsitExivkz/ktHW3JaMJTGhRezl86CKoOcR2GooFBt+/c/HNM8DX4KX17RJFs8lgE\n\tNkOMSE9kTlzPLFF4J7u5pCtIfuZR5pIwBEuc6e6h03IC2JwtcdnxQk55klF4Gur/K+Lc\n\tb+6NlyHD0b//GvYbkt5OMwG420nhy32siBBY0RfS1KFLbTfLLaRV3+K8CEH0aAiVY+3T\n\twfoQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=google.com\n\theader.i=@google.com header.b=\"sBkJHZDg\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1699894369; x=1700499169;\n\th=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=yE/zVCqVkqbFBjaA5vxIIWwj2mesrlsKe5E9GsDJqbg=;\n\tb=iiAN9L0YDKNaPFVJuc+g+BpI2CGEkbGpgKJKNqzCbXZfzn20yrB1mOW/GyxZrgBXVo\n\tlgASDbjuQGARECgSUye1WLMyCea6GzdDp1B9PECvdLNXDfUyYD2DHMPcPBXMLgBuZsPv\n\tN1r13yLIBAdqzS5SFXTf5d2TXzbMlxDcgkIeMvQ9/WRkqIZuvEkokqvI1Ra03hLPCZbm\n\tPTd9qiHMtcO5rZgnXAl1Mm/51BLEvtq8tAErOAMSVzjapA/1k4B9+Q7VCv+JoISKMcIP\n\tU0R4nqwYQucQJWCZMtUtFzJbmDz0SZzHx1HTK/yWG7IiCEncWvFym8mGnpYqAx9TTpSD\n\tjeAA==", "X-Gm-Message-State": "AOJu0YxI7/rboueCKsTCM36KUI7wo8DdgmUWTQvvAvel89JvmFZWsigE\n\tKSw/4msMmuJIXiI1vgAs3JZM+hH0ATk1kRkCLJaVZSbqK7n9o1Fgbq2j66VXSI0TDK2TALgXppa\n\tI5/agWocZXGk3zK/lyh3XuzV4kQCla6ooUkVmKJoAdpjqkUBsokRZhWbxmZyymBVYx2GeBlcOk5\n\tYWDnRkS7hkOsxAFGmi", "X-Google-Smtp-Source": "AGHT+IF4+yLW5GlHuf6bTu5eaese9JQgzz9KkUaRXwQV3qawI8aGLZkwGIfsvacYoewreLQ/SvB2QBB+PtnnOs+DFA==", "X-Received": "from bbrotherton-ws.bld.corp.google.com\n\t([2620:15c:183:200:b8fd:14d6:388a:4a8])\n\t(user=bbrotherton job=sendgmr) by 2002:a25:9e0e:0:b0:d9a:5b63:a682\n\twith SMTP\n\tid m14-20020a259e0e000000b00d9a5b63a682mr184787ybq.13.1699894369394;\n\tMon, 13 Nov 2023 08:52:49 -0800 (PST)", "Date": "Mon, 13 Nov 2023 09:52:44 -0700", "Mime-Version": "1.0", "X-Mailer": "git-send-email 2.42.0.869.gea05f2083d-goog", "Message-ID": "<20231113165244.480925-1-bbrotherton@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Mailman-Approved-At": "Mon, 13 Nov 2023 19:08:12 +0100", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: fix c++20 compile\n\twarning", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Brett Brotherton via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Brett Brotherton <bbrotherton@google.com>", "Cc": "Brett Brotherton <bbrotherton@google.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "fix -Wdeprecated-this-capture error when building with c++20 by\nexplicity naming this in the capture\n\nSigned-off-by: Brett Brotherton <bbrotherton@google.com>\n---\n src/libcamera/pipeline_handler.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 9c74c6cf..2220cb92 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr<Camera> camera)\n */\n void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n {\n-\tmedia->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n+\tmedia->disconnected.connect(this, [=, this]() { mediaDeviceDisconnected(media); });\n }\n \n /**\n", "prefixes": [ "libcamera-devel" ] }