Patch Detail
Show a patch.
GET /api/1.1/patches/19160/?format=api
{ "id": 19160, "url": "https://patchwork.libcamera.org/api/1.1/patches/19160/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19160/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231019140133.32090-13-jacopo.mondi@ideasonboard.com>", "date": "2023-10-19T14:01:33", "name": "[libcamera-devel,v6,12/12] py: cam: Add option to set stream orientation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ced1ff39bfb5255139fe88c2447a96027da6173d", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19160/mbox/", "series": [ { "id": 4053, "url": "https://patchwork.libcamera.org/api/1.1/series/4053/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4053", "date": "2023-10-19T14:01:21", "name": "libcamera: Replace CameraConfiguration::transform", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4053/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19160/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19160/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26929C32BB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Oct 2023 14:02:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C97D96299E;\n\tThu, 19 Oct 2023 16:02:02 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C1C862982\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Oct 2023 16:01:54 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90D93735;\n\tThu, 19 Oct 2023 16:01:46 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697724122;\n\tbh=jPUq1A9sUQKQYtv41RZ3i6l4nfYqyMpxL+pYMbxUW64=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vNbr5zhaUmj8hQFNjna4l4Z9h851bA3ScD6HH0hUBNPUpTnlD5/6tx41D3TLCtjxM\n\tf0afQ5qDgkkA/xLgxy3CdK2txOb6Tw9vnplmX25xKVigCTKin/q8OtMgwoObMyNf3F\n\tQe45L7pIkN8MY9GJPIgNnT0ypjqueY1MDnQpH+sULY23wFyKXVUCNyJzDYa6FdOlgc\n\tjDBjuOkFtRBeb5m3Ndkpjok4MRfrydESnKSPr49fLSMy/DZMHFfgSQLdWif5AEcZGQ\n\tBsQJuO4PCSLP0Efs6i9U/IiJFfOkGDsgwfLbcH3VIkhEGH/BBh4Q9EVMKsm4+ofsgn\n\tWchCmGNdz0K3Q==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697724106;\n\tbh=jPUq1A9sUQKQYtv41RZ3i6l4nfYqyMpxL+pYMbxUW64=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qRy1LNiCPY+mmNAnUrfPmGnwXlAv3nUeXWJCPXPl9svVGUHV6r7k2W9L5gpmGnEdt\n\tX5kdjSFntsi2JiHXi152h5DLMbh5t2L1wxp4TakwesKipLdUboQh88bAUPtlmjhaCw\n\trfOhF08KCKyyQkCcBRmQ42fjZz8CEHyhM6/vBtw8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qRy1LNiC\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 19 Oct 2023 16:01:33 +0200", "Message-ID": "<20231019140133.32090-13-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "References": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 12/12] py: cam: Add option to set\n\tstream orientation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a '--orientation|-o' option to the Python version of the cam test\napplication to set an orientation to the image stream.\n\nSupported values are:\n- rot0: no rotation\n- rot180: rotate 180 degrees\n- flip: vertical flip\n- mirror: horizontal flip\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/py/cam/cam.py | 21 +++++++++++++++++++++\n 1 file changed, 21 insertions(+)", "diff": "diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex a2a115c164b4..06bd51aa5efe 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -23,6 +23,7 @@ class CameraContext:\n opt_metadata: bool\n opt_save_frames: bool\n opt_capture: int\n+ opt_orientation: str\n \n stream_names: dict[libcam.Stream, str]\n streams: list[libcam.Stream]\n@@ -146,6 +147,21 @@ class CameraContext:\n if 'pixelformat' in stream_opts:\n stream_config.pixel_format = libcam.PixelFormat(stream_opts['pixelformat'])\n \n+ if self.opt_orientation is not None:\n+ orientation_map = {\n+ 'rot0': libcam.Orientation.Rotate0,\n+ 'rot180': libcam.Orientation.Rotate180,\n+ 'mirror': libcam.Orientation.Rotate0Mirror,\n+ 'flip': libcam.Orientation.Rotate180Mirror,\n+ }\n+\n+ orient = orientation_map.get(self.opt_orientation, None)\n+ if orient is None:\n+ print('Bad orientation: ', self.opt_orientation)\n+ sys.exit(-1)\n+\n+ camconfig.orientation = orient\n+\n stat = camconfig.validate()\n \n if stat == libcam.CameraConfiguration.Status.Invalid:\n@@ -385,6 +401,7 @@ def main():\n parser.add_argument('--metadata', nargs=0, type=bool, action=CustomAction, help='Print the metadata for completed requests')\n parser.add_argument('--strict-formats', type=bool, nargs=0, action=CustomAction, help='Do not allow requested stream format(s) to be adjusted')\n parser.add_argument('-s', '--stream', nargs='+', action=CustomAction)\n+ parser.add_argument('-o', '--orientation', help='Desired image orientation (rot0, rot180, mirror, flip)')\n args = parser.parse_args()\n \n cm = libcam.CameraManager.singleton()\n@@ -408,6 +425,10 @@ def main():\n ctx.opt_metadata = args.metadata.get(cam_idx, False)\n ctx.opt_strict_formats = args.strict_formats.get(cam_idx, False)\n ctx.opt_stream = args.stream.get(cam_idx, ['role=viewfinder'])\n+ if args.orientation is not None:\n+ ctx.opt_orientation = args.orientation\n+ else:\n+ ctx.opt_orientation = None\n contexts.append(ctx)\n \n for ctx in contexts:\n", "prefixes": [ "libcamera-devel", "v6", "12/12" ] }