Patch Detail
Show a patch.
GET /api/1.1/patches/19157/?format=api
{ "id": 19157, "url": "https://patchwork.libcamera.org/api/1.1/patches/19157/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19157/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231019140133.32090-10-jacopo.mondi@ideasonboard.com>", "date": "2023-10-19T14:01:30", "name": "[libcamera-devel,v6,09/12] py: libcamera: Define and use Orientation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cdfd062329e091739bf675a7cdce98bc262e7ed2", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19157/mbox/", "series": [ { "id": 4053, "url": "https://patchwork.libcamera.org/api/1.1/series/4053/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4053", "date": "2023-10-19T14:01:21", "name": "libcamera: Replace CameraConfiguration::transform", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4053/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19157/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19157/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4362BC32B9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Oct 2023 14:02:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA7856298F;\n\tThu, 19 Oct 2023 16:02:00 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 797E262990\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Oct 2023 16:01:53 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 547A6735;\n\tThu, 19 Oct 2023 16:01:45 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697724120;\n\tbh=+BfuYw/ENojz8fu8+mWFKfDwzkpRGph1acjzgncgusI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tWbcH07oiVxohtKUZNEhks6K2/2Nn64Z7PYCCb5ZFC5QWljmegQa2WN0PFH08bWso\n\tzVkXnUOtvfzaZH0EgOFQgErbZ4GSDSm21ENCnWU7UUjBl5NcKJt00sOv3mOGXqc65u\n\tdOW8bXFB7I0ft+wU2/zHwieh0inj3al91pLpKOrxPSr8YYW7OUhlGScqcPr5Rg8Cjq\n\tnI6kArY4OdwlFUur5/4euJBPl4fZtgWLKBFYy9Ru9awRVJ8ttdAdUpJglGUlt9nHAW\n\t7WZqZVfAWX9ZikKv3LUW6QLWP9FhQlqv6KPKUdfvZYkit0eCz+LI5XMh80AGcep9yL\n\tkJiKjt1Pp6FQQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697724105;\n\tbh=+BfuYw/ENojz8fu8+mWFKfDwzkpRGph1acjzgncgusI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pDv5TBP5bc+IIAujaiH4h5A9hIGqHEfepySbgn1E9GbYvKanDz4q/Gn20wQaiKdKY\n\tsK03cqzlz9p1/fCN0GVrinDrdoL80bpoqgCvgkTZjmeyj/w6gR96wuEisZc2dm+USy\n\ti4qVNlejkmEWvEhSp6zYPWyTp/z0mZpjHPhFDr3A=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pDv5TBP5\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 19 Oct 2023 16:01:30 +0200", "Message-ID": "<20231019140133.32090-10-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "References": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 09/12] py: libcamera: Define and use\n\tOrientation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Define an enumeration type for Orientation and expose the\nCameraConfiguration::orientation property in place of\nCameraConfiguration::transform.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/libcamera/py_enums.cpp | 10 ++++++++++\n src/py/libcamera/py_main.cpp | 1 +\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/src/py/libcamera/py_enums.cpp b/src/py/libcamera/py_enums.cpp\nindex 803c4e7ee362..e25689c674ef 100644\n--- a/src/py/libcamera/py_enums.cpp\n+++ b/src/py/libcamera/py_enums.cpp\n@@ -31,4 +31,14 @@ void init_py_enums(py::module &m)\n \t\t.value(\"String\", ControlType::ControlTypeString)\n \t\t.value(\"Rectangle\", ControlType::ControlTypeRectangle)\n \t\t.value(\"Size\", ControlType::ControlTypeSize);\n+\n+\tpy::enum_<Orientation>(m, \"Orientation\")\n+\t\t.value(\"Rotate0\", Orientation::Rotate0)\n+\t\t.value(\"Rotate0Mirror\", Orientation::Rotate0Mirror)\n+\t\t.value(\"Rotate180\", Orientation::Rotate180)\n+\t\t.value(\"Rotate180Mirror\", Orientation::Rotate180Mirror)\n+\t\t.value(\"Rotate90Mirror\", Orientation::Rotate90Mirror)\n+\t\t.value(\"Rotate270\", Orientation::Rotate270)\n+\t\t.value(\"Rotate270Mirror\", Orientation::Rotate270Mirror)\n+\t\t.value(\"Rotate90\", Orientation::Rotate90);\n }\ndiff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex d2ce372297db..aa35f0a24847 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -330,6 +330,7 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t.def_property_readonly(\"empty\", &CameraConfiguration::empty)\n \t\t.def_readwrite(\"sensor_config\", &CameraConfiguration::sensorConfig)\n \t\t.def_readwrite(\"transform\", &CameraConfiguration::transform);\n+\t\t.def_readwrite(\"orientation\", &CameraConfiguration::orientation);\n \n \tpyCameraConfigurationStatus\n \t\t.value(\"Valid\", CameraConfiguration::Valid)\n", "prefixes": [ "libcamera-devel", "v6", "09/12" ] }