Patch Detail
Show a patch.
GET /api/1.1/patches/19153/?format=api
{ "id": 19153, "url": "https://patchwork.libcamera.org/api/1.1/patches/19153/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19153/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231019140133.32090-6-jacopo.mondi@ideasonboard.com>", "date": "2023-10-19T14:01:26", "name": "[libcamera-devel,v6,05/12] libcamera: transform: Add functions to convert Orientation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3f372d8a0260c322c47a1e2ca8fd33e3c365dc36", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19153/mbox/", "series": [ { "id": 4053, "url": "https://patchwork.libcamera.org/api/1.1/series/4053/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4053", "date": "2023-10-19T14:01:21", "name": "libcamera: Replace CameraConfiguration::transform", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4053/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19153/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19153/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 405B9C3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Oct 2023 14:01:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8382D62997;\n\tThu, 19 Oct 2023 16:01:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6D446297F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Oct 2023 16:01:51 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B32CC276;\n\tThu, 19 Oct 2023 16:01:43 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697724115;\n\tbh=59rANWTuLJcpkVFdsDHrVnbnFXCHLU/KPzDNWI+oHEQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uZU1ujmTVCkwdPWaQpvPNVTaVgWbim3eLkqtOLJ/UbjSfCIyLe0sz2ks1cfAYduAc\n\t2jQkZjegsc2rdacQh8zLbuoF+DQcI0mr4ppuDGuCPQEa5rBUT5I87z+Ri9sUqkuR2U\n\tuOFoIQQhwdtAVrQqlakAxsLI52IDxDNk+oGOVFZG4wtdJCRRqf+DiKBfslH6zfAlvZ\n\tWbYPr2ycjpY4HoJagTctc9aWGNLYQYvDpX+Hd5SbUrK5gAUD1vL06dChWYKgm5FAwp\n\tOdFiGbOCZLnSmpj+Y3ZqKV/BM5PtHhrgmYxnGZeyQtD9Tk+dLnFjVlZedY/3bF7U6T\n\tMUumw3P6kktoQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697724103;\n\tbh=59rANWTuLJcpkVFdsDHrVnbnFXCHLU/KPzDNWI+oHEQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hC8aQGYirFBg8ijX8G55ZxIIaKBNotxaMxlRRIc1+6kI3ZdQBSINh2CijmkJryJRg\n\t1/5yOMXuatNz4vqXu9P3bn/d0r0hO5tyxgxO6HYiiBJF6A/rU6jheCaTeeDf48p4hE\n\tCHBcvEIFzN+XbKB0NNTR2aoPCVHbEMSZIHT4E2Jk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hC8aQGYi\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 19 Oct 2023 16:01:26 +0200", "Message-ID": "<20231019140133.32090-6-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "References": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 05/12] libcamera: transform: Add\n\tfunctions to convert Orientation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add two helper functions to the transform.cpp file that allows to\nconvert to and from an Orientation.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n include/libcamera/transform.h | 4 +++\n src/libcamera/transform.cpp | 60 +++++++++++++++++++++++++++++++++++\n 2 files changed, 64 insertions(+)", "diff": "diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\nindex 2a6838c78369..14f1db0e8572 100644\n--- a/include/libcamera/transform.h\n+++ b/include/libcamera/transform.h\n@@ -11,6 +11,8 @@\n \n namespace libcamera {\n \n+enum class Orientation;\n+\n enum class Transform : int {\n \tIdentity = 0,\n \tRot0 = Identity,\n@@ -69,6 +71,8 @@ constexpr Transform operator~(Transform t)\n }\n \n Transform transformFromRotation(int angle, bool *success = nullptr);\n+Transform transformFromOrientation(const Orientation &orientation);\n+Orientation transformToOrientation(const Transform &transform);\n \n const char *transformToString(Transform t);\n \ndiff --git a/src/libcamera/transform.cpp b/src/libcamera/transform.cpp\nindex 4668303d0676..c305940100bf 100644\n--- a/src/libcamera/transform.cpp\n+++ b/src/libcamera/transform.cpp\n@@ -7,6 +7,8 @@\n \n #include <libcamera/transform.h>\n \n+#include <libcamera/orientation.h>\n+\n /**\n * \\file transform.h\n * \\brief Enum to represent and manipulate 2D plane transforms\n@@ -299,6 +301,64 @@ Transform transformFromRotation(int angle, bool *success)\n \treturn Transform::Identity;\n }\n \n+/**\n+ * \\brief Return the transform representing \\a orientation\n+ * \\param[in] orientation The orientation to convert\n+ * \\return The transform corresponding to \\a orientation\n+ */\n+Transform transformFromOrientation(const Orientation &orientation)\n+{\n+\tswitch (orientation) {\n+\tcase Orientation::Rotate0:\n+\t\treturn Transform::Identity;\n+\tcase Orientation::Rotate0Mirror:\n+\t\treturn Transform::HFlip;\n+\tcase Orientation::Rotate180:\n+\t\treturn Transform::Rot180;\n+\tcase Orientation::Rotate180Mirror:\n+\t\treturn Transform::VFlip;\n+\tcase Orientation::Rotate90Mirror:\n+\t\treturn Transform::Transpose;\n+\tcase Orientation::Rotate90:\n+\t\treturn Transform::Rot90;\n+\tcase Orientation::Rotate270Mirror:\n+\t\treturn Transform::Rot180Transpose;\n+\tcase Orientation::Rotate270:\n+\t\treturn Transform::Rot270;\n+\t}\n+\n+\treturn Transform::Identity;\n+}\n+\n+/**\n+ * \\brief Return the Orientation representing \\a transform\n+ * \\param[in] transform The transform to convert\n+ * \\return The Orientation corresponding to \\a transform\n+ */\n+Orientation transformToOrientation(const Transform &transform)\n+{\n+\tswitch (transform) {\n+\tcase Transform::Identity:\n+\t\treturn Orientation::Rotate0;\n+\tcase Transform::HFlip:\n+\t\treturn Orientation::Rotate0Mirror;\n+\tcase Transform::VFlip:\n+\t\treturn Orientation::Rotate180Mirror;\n+\tcase Transform::Rot180:\n+\t\treturn Orientation::Rotate180;\n+\tcase Transform::Transpose:\n+\t\treturn Orientation::Rotate90Mirror;\n+\tcase Transform::Rot270:\n+\t\treturn Orientation::Rotate270;\n+\tcase Transform::Rot90:\n+\t\treturn Orientation::Rotate90;\n+\tcase Transform::Rot180Transpose:\n+\t\treturn Orientation::Rotate270Mirror;\n+\t}\n+\n+\treturn Orientation::Rotate0;\n+}\n+\n /**\n * \\brief Return a character string describing the transform\n * \\param[in] t The transform to be described.\n", "prefixes": [ "libcamera-devel", "v6", "05/12" ] }