Patch Detail
Show a patch.
GET /api/1.1/patches/19152/?format=api
{ "id": 19152, "url": "https://patchwork.libcamera.org/api/1.1/patches/19152/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19152/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231019140133.32090-5-jacopo.mondi@ideasonboard.com>", "date": "2023-10-19T14:01:25", "name": "[libcamera-devel,v6,04/12] libcamera: properties: Make 'Rotation' the mounting rotation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f861c5cb10419bcad67eac9ef2a19954656494bf", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19152/mbox/", "series": [ { "id": 4053, "url": "https://patchwork.libcamera.org/api/1.1/series/4053/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4053", "date": "2023-10-19T14:01:21", "name": "libcamera: Replace CameraConfiguration::transform", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4053/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19152/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19152/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69959C32B6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Oct 2023 14:01:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B4DD62988;\n\tThu, 19 Oct 2023 16:01:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6281961DD2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Oct 2023 16:01:51 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 490A7735;\n\tThu, 19 Oct 2023 16:01:43 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697724115;\n\tbh=ez09PkZ4hoqGcybyDh8tQLfj8on8zVKYntI7Pbhg7iU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hmh1E0IyH29VoqYDUUgjxLDWiJtjhAgYpeN23sJ2qDESavs3purnXW2JIpNCebA27\n\tgcuFzoAXGx2oeqlZk8UmzGnG0++JNiJQ3Gw9pFyToJy4zuOBKKNrNnjNvlMxi/AYGV\n\toMryTikx1Uk7HJPCtlYf8j9nbVQ4cAecLYerBuimx3bqwg9GCYvsoL9GfkhEnp564j\n\tQT30BA328g5WDzh56Ac89Oj8aDuIu5QXOBBqGzT6hC0TnCTIadhXJI1xhaDgC+Vc3d\n\tcm08Ml9R11ctcBVLs2oM6WPR7RLcuMPehZtOMamiBNyQL9GoiKUQyjKQ7gsvpSg9k2\n\tJmmeylv6O1inQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697724103;\n\tbh=ez09PkZ4hoqGcybyDh8tQLfj8on8zVKYntI7Pbhg7iU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fl+XKNeGydxpskHCF1D4xdyMq6xly0K1PMzcyu8kX2BZ/pdV0PXTkLevTknFOJIEZ\n\ts3RB9PFMkNlR43Z84sKkWJFSCdsdJzvtNCnzotua1AzebnQCxj5NDHvTqzLDf3Xlv+\n\toUsHYY6fjOl2hrS2zNouj/K4CU9bhcg6CU9eqHFU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fl+XKNeG\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 19 Oct 2023 16:01:25 +0200", "Message-ID": "<20231019140133.32090-5-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "References": "<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 04/12] libcamera: properties: Make\n\t'Rotation' the mounting rotation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Specify in the documentation that properties::Rotation specifies the\nmounting rotation of the camera module. This avoids confusion with the\nimage orientation which is instead expressed by\nCameraConfiguration::orientation.\n\nFor this reason, do not compensate the Rotation property when\ninitializing the CameraSensor class but report the value of\nV4L2_CID_CAMERA_SENSOR_ROTATION or 0 if the control is not available.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera_sensor.cpp | 15 +++------------\n src/libcamera/property_ids.yaml | 8 ++++----\n 2 files changed, 7 insertions(+), 16 deletions(-)", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex e3826cebeeff..8ff72b424560 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -433,11 +433,11 @@ int CameraSensor::initProperties()\n \n \t/* Retrieve and register properties from the kernel interface. */\n \tconst ControlInfoMap &controls = subdev_->controls();\n-\tint32_t propertyValue;\n \n \tconst auto &orientation = controls.find(V4L2_CID_CAMERA_ORIENTATION);\n \tif (orientation != controls.end()) {\n \t\tint32_t v4l2Orientation = orientation->second.def().get<int32_t>();\n+\t\tint32_t propertyValue;\n \n \t\tswitch (v4l2Orientation) {\n \t\tdefault:\n@@ -462,7 +462,7 @@ int CameraSensor::initProperties()\n \n \tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n \tif (rotationControl != controls.end()) {\n-\t\tpropertyValue = rotationControl->second.def().get<int32_t>();\n+\t\tint32_t propertyValue = rotationControl->second.def().get<int32_t>();\n \n \t\t/*\n \t\t * Cache the Transform associated with the camera mounting\n@@ -477,20 +477,11 @@ int CameraSensor::initProperties()\n \t\t\trotationTransform_ = Transform::Identity;\n \t\t}\n \n-\t\t/*\n-\t\t * Adjust property::Rotation as validateTransform() compensates\n-\t\t * for the mounting rotation. However, as a camera sensor can\n-\t\t * only compensate rotations by applying H/VFlips, only rotation\n-\t\t * of 180 degrees are automatically compensated. The other valid\n-\t\t * rotations (Rot90 and Rot270) require transposition, which the\n-\t\t * camera sensor cannot perform, so leave them untouched.\n-\t\t */\n-\t\tif (propertyValue == 180 && supportFlips_)\n-\t\t\tpropertyValue = 0;\n \t\tproperties_.set(properties::Rotation, propertyValue);\n \t} else {\n \t\tLOG(CameraSensor, Warning)\n \t\t\t<< \"Rotation control not available, default to 0 degrees\";\n+\t\tproperties_.set(properties::Rotation, 0);\n \t\trotationTransform_ = Transform::Identity;\n \t}\n \ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 5bddafc29364..f35563842a5a 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -29,10 +29,10 @@ controls:\n - Rotation:\n type: int32_t\n description: |\n- The camera rotation is expressed as the angular difference in degrees\n- between two reference systems, one relative to the camera module, and\n- one defined on the external world scene to be captured when projected\n- on the image sensor pixel array.\n+ The camera physical mounting rotation. It is expressed as the angular\n+ difference in degrees between two reference systems, one relative to the\n+ camera module, and one defined on the external world scene to be\n+ captured when projected on the image sensor pixel array.\n \n A camera sensor has a 2-dimensional reference system 'Rc' defined by\n its pixel array read-out order. The origin is set to the first pixel\n", "prefixes": [ "libcamera-devel", "v6", "04/12" ] }