Patch Detail
Show a patch.
GET /api/1.1/patches/19139/?format=api
{ "id": 19139, "url": "https://patchwork.libcamera.org/api/1.1/patches/19139/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19139/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231013074841.16972-16-naush@raspberrypi.com>", "date": "2023-10-13T07:48:36", "name": "[libcamera-devel,v2,15/20] pipeline: rpi: Make color space members in RPiCameraConfiguration public", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bdcf86630ff374a2d941ce7c9e6271383e37a9ca", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19139/mbox/", "series": [ { "id": 4049, "url": "https://patchwork.libcamera.org/api/1.1/series/4049/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4049", "date": "2023-10-13T07:48:21", "name": "Raspberry Pi: Preliminary PiSP support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4049/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19139/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19139/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7BB9C32C0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Oct 2023 07:49:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C74A62999;\n\tFri, 13 Oct 2023 09:49:06 +0200 (CEST)", "from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B484762989\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Oct 2023 09:48:57 +0200 (CEST)", "by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-4054f790190so20864305e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Oct 2023 00:48:57 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm16-20020a7bca50000000b003fee6e170f9sm1791890wml.45.2023.10.13.00.48.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Oct 2023 00:48:56 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697183346;\n\tbh=k6AIkgxNK2TCKRgGWXmKIS+DZmRVUgN3qu4+zZdoSDA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=UN5+N86FS4G43JfI2F+odJ1QpmTpwpv7h6BRyBWMPXGFSNJrChal58WbP4Werbh6s\n\t2lrYQceuP6Z2EegAD+ro6LDUClCdz4kK7pD0pEyXM9sDYvGsDqr7xCtPNJ9G77qrmb\n\tQ6LmXZRc2OCGwDp20FE9e7wIfqK2HbSARPJ1nhOC3dyjh2IRLEX3s5Zj5SpH4YWjHE\n\tDe9posDJOywes75NyGGEH03bt4suuEy6jqopLSplJiQd9HJy/31TycyCnk49flZsCW\n\tyZdidkNi8lcnEv4FakXdtiM16s7vr7Piz7sNMOpXm7BUXW4IYfN9a2N4hO5+yOyXGN\n\t+MGvORQl9mVaw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1697183337; x=1697788137;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=6KeD7RYi36cgDXjCWlDhOsoX6YMd/Et152aNpo+jQdA=;\n\tb=GDXA1iB3zD+8Q8e1SCIadoh+fypLqhqEXnGhk0U2vuTcWVkFYnlG0OYktoOeLAEx8m\n\tolr140iD8uIgu92FtLz75TODjFbDyYPex70/y+p0VW/9B2lNXLDuRw6BLytyC5bbziED\n\t+MDkRzvnSnXpfFDS1tIoaq3c4rpVibRIy/gvRZi4YCJ4rULkOPjluHcdaqm7cMmnHBUF\n\tUoNQhbkfoafBhx4IhDhPUeiZupITIyJRTHmQq9+wulgqMdYcz7xU+yKZpEcEKOHwqpHE\n\tRLoFqyryRHY7YCcqKLJKr1D//AqRiVSxp3MikQjuiuPr5tCuLGoJiL6EnCBt4LX79kx1\n\tm3rQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"GDXA1iB3\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1697183337; x=1697788137;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=6KeD7RYi36cgDXjCWlDhOsoX6YMd/Et152aNpo+jQdA=;\n\tb=dixXwwuBn4mnedEhWG9bwkbN8YL4Kk8MPABwR+rlZAPu2hGiVD6nskbt4cG5qk7KrM\n\t0Z5x1FrZpooPhs8A/uejm9nN0tyY673/3WCibZGZbum9vBAD7sYnWNuVuWBgwwa9UHYI\n\tONrdouFRI0gtuKCgmC4kLz02fSHwV1YuOg6nsKa33xPUt/MmOczF0aiTSGZlqknGUA1Z\n\tqBtb4a0jm6NrYIgUtXlooxk62fSLtLhluNIQ6q2pHK+UZCE/oYuNTMCy4PAiUSI7a4NL\n\tXl5Sv4k0nVlIgAed9IW4oBfHHPctx+ryyPYNMU+eGCeAzGzEeGh5cB5maoNCY3pBet8l\n\tquNw==", "X-Gm-Message-State": "AOJu0Ywm27yr27Vb1rsHNQr7YCQ0/wtRMy19VY6Sfs/6p/bQ3Jv3ZoFZ\n\t7d0s4oJoLYLFVyjeBQuugmPDHC2to9vr1zAUut7Bcg==", "X-Google-Smtp-Source": "AGHT+IEZVPN29SMDsaIYNw8/tCH/7gHL47TyUf1Zohg2lHYBgw05B4fHnEMExyUtkMtWHTYKlQQaVQ==", "X-Received": "by 2002:a7b:cb8c:0:b0:406:517f:ac71 with SMTP id\n\tm12-20020a7bcb8c000000b00406517fac71mr22625846wmi.29.1697183337179; \n\tFri, 13 Oct 2023 00:48:57 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 13 Oct 2023 08:48:36 +0100", "Message-Id": "<20231013074841.16972-16-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231013074841.16972-1-naush@raspberrypi.com>", "References": "<20231013074841.16972-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 15/20] pipeline: rpi: Make color space\n\tmembers in RPiCameraConfiguration public", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This allows them to be accessed by the pipeline handlers when needed.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\nindex 0c4a59b7f590..267eef1102f1 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n@@ -273,9 +273,6 @@ public:\n \tstd::vector<StreamParams> rawStreams_;\n \tstd::vector<StreamParams> outStreams_;\n \n-private:\n-\tconst CameraData *data_;\n-\n \t/*\n \t * Store the colour spaces that all our streams will have. RGB format streams\n \t * will have the same colorspace as YUV streams, with YCbCr field cleared and\n@@ -283,6 +280,9 @@ private:\n \t */\n \tstd::optional<ColorSpace> yuvColorSpace_;\n \tstd::optional<ColorSpace> rgbColorSpace_;\n+\n+private:\n+\tconst CameraData *data_;\n };\n \n } /* namespace RPi */\n", "prefixes": [ "libcamera-devel", "v2", "15/20" ] }