Patch Detail
Show a patch.
GET /api/1.1/patches/19128/?format=api
{ "id": 19128, "url": "https://patchwork.libcamera.org/api/1.1/patches/19128/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19128/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231013074841.16972-5-naush@raspberrypi.com>", "date": "2023-10-13T07:48:25", "name": "[libcamera-devel,v2,04/20] ipa: rpi: Add IpaBase::platformStart() member function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c1c508af0897280a212f0dab9b2a3020a86c9fe1", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19128/mbox/", "series": [ { "id": 4049, "url": "https://patchwork.libcamera.org/api/1.1/series/4049/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4049", "date": "2023-10-13T07:48:21", "name": "Raspberry Pi: Preliminary PiSP support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4049/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19128/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19128/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A174FC32B8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Oct 2023 07:48:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 80C386297E;\n\tFri, 13 Oct 2023 09:48:53 +0200 (CEST)", "from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4186462980\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Oct 2023 09:48:50 +0200 (CEST)", "by mail-wr1-x435.google.com with SMTP id\n\tffacd0b85a97d-31f71b25a99so1697576f8f.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Oct 2023 00:48:50 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm16-20020a7bca50000000b003fee6e170f9sm1791890wml.45.2023.10.13.00.48.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Oct 2023 00:48:49 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697183333;\n\tbh=rxVei+/bCJL0Jded4ibv1g3xlqNCQ9dDIFL/A3oIamA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=t0xnbzWLU0Dc+vsDT1DV8sssH1mw2EjlPutGeoi4rowQcZMEt7at/TxFnfjo9rAno\n\tYN8zWnAQ2oW/PtWAFSNXg1q1weyu40/lnI6+QTd/h2inxZpJUF0K1cx7Ma2POWZy9F\n\tMN+JUfCYqCYS1sxU3HlNnP8Zhq37jIJUOb9tZDXx426xQdhhBwH+ZDTSZ+TJgE//rf\n\tGpUF2BS0WAEqnPrycIMzYQEaol4mMBX2qpNHtC1waEEgGGeASKNzVv63+LJSksZOKl\n\tk9wPpT7D72SHORKZmvw80tGooh9ukOxdbydf0/B4xwri6iBSLJa7L8G5ojsggg5uyl\n\tleYfFSChuSNCg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1697183329; x=1697788129;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=kUh7r73vgyaw/ga4Ir8ecXHXGWBguUKt7Z76Z8tysMU=;\n\tb=YnDExHuXlTh+UBbdWeLtW2mB9K4FmKa1227Wk8nqNefhyoYOwYcE1JSVJIB3Yhapjy\n\t81XOkONTRAK6FV0gK3yRLCJ+gaHlGIVmoo4unnTxi76AaTQ7n6HzSui9DUa0rP81sNHR\n\tceZRV/UWTyJfi6T4iZq0/epToILXAMrNAqzgoEHViUs93sIsRfQ2i2SdpjziM3ngIR7s\n\tfjjZg3I0SVh63ECqgykVlD77YSLc/o54PH/wN8Wz0yiUGHoo8mZWgEPgsBkVkpthN+Js\n\tMz5DrLlzKH3l4Qt6YTuqgGtG4j+nCBP63RuP/e1bgBXStaWAMpdK2JJxvDdRSTbRz0I0\n\tNVgg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"YnDExHuX\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1697183329; x=1697788129;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=kUh7r73vgyaw/ga4Ir8ecXHXGWBguUKt7Z76Z8tysMU=;\n\tb=Lu0ib9dMXMFwI+O7rQAUfN1Hxxd9de0gXR2RbJstWwqc/9kMWzxWgVJNGnEvz1XdgZ\n\t2P/z/WPas8PF0raj0WSE5RM1d4VKpsqeJnyz0ZiW3KMdQY6pcdCwyCWpIQbMSDygEnzG\n\tmVuUAT6WjKLfaDW3ra9/T8BU/pV3gtPnmJuiV/rsmozka5L8aErDfsu0hGwIp07ObdUp\n\tOb6B7xxGfrZD5cpp7T+t/JkWGVayeeJqVIhlMkT9xZwvGW9g4HTJ1q7ml1qSzDtdhSTG\n\t3C+7og1a/TEvZYeOCZksaXp7Val4AeK9YR6nTPJSAS2wwCL+bq6qONbf/RZkpNUzMDgx\n\tQuKQ==", "X-Gm-Message-State": "AOJu0YwRMIRICnaEB2en6wJkYXudcGA8hcksxuoQ5KTPSSr8GGlI90Tr\n\teeblZgtOMyehw/Fj04qvQy6ImAuQqymHcslqhYjHWA==", "X-Google-Smtp-Source": "AGHT+IFugMizvcTpEW+nLBMAHZUDyrGkXzxZQaxQxKudxsop3NxvlTgoJ00cyuxdgHn1sTFbxT+PMA==", "X-Received": "by 2002:a05:6000:24a:b0:32d:9337:e7d4 with SMTP id\n\tm10-20020a056000024a00b0032d9337e7d4mr3044736wrz.9.1697183329615; \n\tFri, 13 Oct 2023 00:48:49 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 13 Oct 2023 08:48:25 +0100", "Message-Id": "<20231013074841.16972-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231013074841.16972-1-naush@raspberrypi.com>", "References": "<20231013074841.16972-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 04/20] ipa: rpi: Add\n\tIpaBase::platformStart() member function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a virtual IpaBase::platformStart() member function that is called\nat the end of IpaBase::start(). For the IpaVc4 derived class, this\nfunction does nothing, but will be used in the PiSP derived class to\nreset internal state on startup.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 2 ++\n src/ipa/rpi/common/ipa_base.h | 1 +\n src/ipa/rpi/vc4/vc4.cpp | 7 +++++++\n 3 files changed, 10 insertions(+)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 5df1998c8113..5939fe57f040 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -341,6 +341,8 @@ void IpaBase::start(const ControlList &controls, StartResult *result)\n \n \tfirstStart_ = false;\n \tlastRunTimestamp_ = 0;\n+\n+\tplatformStart(controls, result);\n }\n \n void IpaBase::mapBuffers(const std::vector<IPABuffer> &buffers)\ndiff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\nindex 097f436af93b..eaa9f71182ed 100644\n--- a/src/ipa/rpi/common/ipa_base.h\n+++ b/src/ipa/rpi/common/ipa_base.h\n@@ -67,6 +67,7 @@ private:\n \tstatic constexpr unsigned int numMetadataContexts = 16;\n \n \tvirtual int32_t platformInit(const InitParams ¶ms, InitResult *result) = 0;\n+\tvirtual int32_t platformStart(const ControlList &controls, StartResult *result) = 0;\n \tvirtual int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) = 0;\n \n \tvirtual void platformPrepareIsp(const PrepareParams ¶ms,\ndiff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp\nindex 1de0d3ccdc44..4a4d720ce7dd 100644\n--- a/src/ipa/rpi/vc4/vc4.cpp\n+++ b/src/ipa/rpi/vc4/vc4.cpp\n@@ -51,6 +51,7 @@ public:\n \n private:\n \tint32_t platformInit(const InitParams ¶ms, InitResult *result) override;\n+\tint32_t platformStart(const ControlList &controls, StartResult *result) override;\n \tint32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override;\n \n \tvoid platformPrepareIsp(const PrepareParams ¶ms, RPiController::Metadata &rpiMetadata) override;\n@@ -94,6 +95,12 @@ int32_t IpaVc4::platformInit([[maybe_unused]] const InitParams ¶ms, [[maybe_\n \treturn 0;\n }\n \n+int32_t IpaVc4::platformStart([[maybe_unused]] const ControlList &controls,\n+\t\t\t [[maybe_unused]] StartResult *result)\n+{\n+\treturn 0;\n+}\n+\n int32_t IpaVc4::platformConfigure(const ConfigParams ¶ms, [[maybe_unused]] ConfigResult *result)\n {\n \tispCtrls_ = params.ispControls;\n", "prefixes": [ "libcamera-devel", "v2", "04/20" ] }