Patch Detail
Show a patch.
GET /api/1.1/patches/19117/?format=api
{ "id": 19117, "url": "https://patchwork.libcamera.org/api/1.1/patches/19117/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19117/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231006132000.23504-16-naush@raspberrypi.com>", "date": "2023-10-06T13:19:55", "name": "[libcamera-devel,15/20] pipeline: rpi: Make color space members in RPiCameraConfiguration public", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bdcf86630ff374a2d941ce7c9e6271383e37a9ca", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19117/mbox/", "series": [ { "id": 4047, "url": "https://patchwork.libcamera.org/api/1.1/series/4047/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4047", "date": "2023-10-06T13:19:40", "name": "Raspberry Pi: Preliminary PiSP support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4047/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19117/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19117/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9820BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Oct 2023 13:20:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50ECA62997;\n\tFri, 6 Oct 2023 15:20:19 +0200 (CEST)", "from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73CE562989\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Oct 2023 15:20:15 +0200 (CEST)", "by mail-wr1-x429.google.com with SMTP id\n\tffacd0b85a97d-31c5cac3ae2so1847337f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 06 Oct 2023 06:20:15 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm8-20020a056000180800b00321773bb933sm1639478wrh.77.2023.10.06.06.20.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Oct 2023 06:20:14 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696598419;\n\tbh=ufz7tg/n9JeM7qTjoqdk7XlHaX5amgtAEu+hsGROEf4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=E2jWKws+Egav48eQfXOttbFgUJhWzEwE+4XBFHZ/YZnSnV7WBfW7JrUvSer0kvO4/\n\tbe0iRhuQtxUGl7T73Y8XhaWcFP/aGPBTpLVcqO1I36oXolpSzHckztqMOEWm4TotdC\n\tqSILc2UNR75k4WCKAgLVVn4hoH8F8aXzEM2BXUMCw/bgNRMUIZOyHvWevp97wKXIKR\n\tfUXY7nVGwZDctTJr8sI5kMLGjEX5y7oZKWXDLRGcg5pJuGo+uNx/N5CFCH+VZr7ZqD\n\tvILll/nDcAoF20q72zwmJoHOiAqjc38oMZlB4oAI2g2dHhlL/eCx4Wcf+OKscI3B3v\n\t9QBCa1iRDTneg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1696598415; x=1697203215;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=pU4wKiWXwkZLedJeP1sGrANY/IM78qE81hjwahnBKxk=;\n\tb=dVQFKBatAx/hO+HZKyKulIEAvjHr3eDtghLmaLDG/F7UcgTF+HZbabT/VGPySsSP3o\n\tJJfQbLUbML4pcHpNpPGjsR79BUGZS+V9vBdCik8VgVipdeiCd/BjlTE4IV+VzM2EfiZO\n\tTewcK3m0M8Rteh5qGKlvlY65SAvBR2uxlgK7SBfrZdYdiopkuLwybzGncceu0ScXWkzJ\n\tyyhtRAOuq37dm//rsOcdJE9WEQAGHqshktrIu+L3nkMqHJ45i8XShEzgiSymCP9bqK3k\n\t3IVfh2o7yIjvQ9zPGWz8rWR8WJA2zpPMOS2DKteU7q7/fini5UV6rBW3R28NMG+dPjjz\n\tNDjg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"dVQFKBat\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1696598415; x=1697203215;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=pU4wKiWXwkZLedJeP1sGrANY/IM78qE81hjwahnBKxk=;\n\tb=oBAKdSkQ0Os1m5RF+PMDMNR3ear7qcHhCPVykZweRPQvUTWl4JyZylS+eJSwFxHNFK\n\tLg2WyyoFQBeKibrjwCGBjrOx5q9JdOA0vAcu23oY06SnET3d+/Seo2pPX7nv2482iwrz\n\tZYll3unY/rEp2GNNX8TUdHClRqEmu3CEgq9wGNi4JMf0S0Pd5Ex/h/xlb0oWL91TLnce\n\tvJMX7D4Cqk91qpxZ2m5QhlsSluXJ7YN7WD1UI47PEu0A9MidUOiE/n4QGq822sK9QqcW\n\tpsYRFv+htQNvjUJmbvNSeBJ1jbEm8uFiurZLJPHNVB6pnix1Bm390VFmGPl3Bn87lDf8\n\trdIg==", "X-Gm-Message-State": "AOJu0Yytxxl4W5UiLx7TJgPtOMdtBh4+AmCRHk4wylc4HK85pXj96nIu\n\teRNS0IX54pC88jmw5PQEZXnDVnPNZaunFVYjmPKFRw==", "X-Google-Smtp-Source": "AGHT+IELOZBlh6BkKnhguxX/9rBs1BOwik8ixz0LziSf2Gr2jtQshxLM23evJ36P9I3mwGQEtwM9Ww==", "X-Received": "by 2002:adf:f24f:0:b0:319:63f3:c0cb with SMTP id\n\tb15-20020adff24f000000b0031963f3c0cbmr7179221wrp.40.1696598414829; \n\tFri, 06 Oct 2023 06:20:14 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 6 Oct 2023 14:19:55 +0100", "Message-Id": "<20231006132000.23504-16-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231006132000.23504-1-naush@raspberrypi.com>", "References": "<20231006132000.23504-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 15/20] pipeline: rpi: Make color space\n\tmembers in RPiCameraConfiguration public", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This allows them to be accessed by the pipeline handlers when needed.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\nindex 0c4a59b7f590..267eef1102f1 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n@@ -273,9 +273,6 @@ public:\n \tstd::vector<StreamParams> rawStreams_;\n \tstd::vector<StreamParams> outStreams_;\n \n-private:\n-\tconst CameraData *data_;\n-\n \t/*\n \t * Store the colour spaces that all our streams will have. RGB format streams\n \t * will have the same colorspace as YUV streams, with YCbCr field cleared and\n@@ -283,6 +280,9 @@ private:\n \t */\n \tstd::optional<ColorSpace> yuvColorSpace_;\n \tstd::optional<ColorSpace> rgbColorSpace_;\n+\n+private:\n+\tconst CameraData *data_;\n };\n \n } /* namespace RPi */\n", "prefixes": [ "libcamera-devel", "15/20" ] }