Patch Detail
Show a patch.
GET /api/1.1/patches/19054/?format=api
{ "id": 19054, "url": "https://patchwork.libcamera.org/api/1.1/patches/19054/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19054/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230918091045.16992-1-naush@raspberrypi.com>", "date": "2023-09-18T09:10:45", "name": "[libcamera-devel] pipeline: rpi: Reset the frame lengths queue during configure", "commit_ref": "e991a2887ebf065d9d62e5dd11d6128eb58f628e", "pull_url": null, "state": "accepted", "archived": false, "hash": "c68ba852ea1cdcff503148676475da7322cc5a69", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19054/mbox/", "series": [ { "id": 4029, "url": "https://patchwork.libcamera.org/api/1.1/series/4029/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4029", "date": "2023-09-18T09:10:45", "name": "[libcamera-devel] pipeline: rpi: Reset the frame lengths queue during configure", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4029/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19054/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19054/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BB9EC326B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 18 Sep 2023 09:10:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 249DE6293E;\n\tMon, 18 Sep 2023 11:10:50 +0200 (CEST)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34BB261DEC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Sep 2023 11:10:49 +0200 (CEST)", "by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-401187f8071so27751625e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Sep 2023 02:10:49 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tc22-20020a7bc856000000b00402f7e473b7sm11717267wml.15.2023.09.18.02.10.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Sep 2023 02:10:48 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695028250;\n\tbh=FeDuZuQO5AVk3Vx79FH2cHCj/OownCH9m0ULNxJXX7Q=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Ov5ByVzuKr9zz7VVIqBg5fIJJvpygqBnyLcOw8XeroFzc075WZqyx66ufA4bVM2TG\n\tsejRu8Ms1lOTNsZb8uDX/3XAID+y2478EcvkafYg2IySTx2D+wtImQUpWkQxC1J5pO\n\tJSyIfREyaXPOMuCJEfKAHgpw8D/1/9IIqCYnT/5+zzdZHUXSdZZU7OVZGgtp4SZf2v\n\t2yR5dTgUsQ8YlKbKdyi16H1K4sQLGenYwbH5CTw/0TzZu+f9wvtLXqiefe197XMIsI\n\tmcgXXMgPkCuk0LA6eIeKQYraTL0lkzRrr845WtyDJH9BhYrF4CHhEcXVUWyBP6PntL\n\tWcFstun2RJ6gw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695028248; x=1695633048;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=5bSQcq0jEBWvwXLfqDd4WA4ENFOQ3ZkA/8GdnctpxnI=;\n\tb=Uvs4GP0DdTuMhRG+gLgXVppgh5HR7A/F2mPgzdMGVMRDa79YSJxeeGUXuGPXpkmlYK\n\tpvwrc/ey7Sre+qT7JrlX4agDnpvkKEEBCo3kfDM+krnMSrb3gVFWm+ZFZu2KMM6Zc1kp\n\t6UL6bHiUZ22kN/b0vsel/QC5zTZa3XIE9ErK90rkUB+blMO1UowsE0SNbdoGXD1YZEIs\n\t/HSb0cwPJh88kalozcf16Y2LOS2iSQ0kiYMgZyPQh3dHLOdlELZzd79xFg1bJPYj5wQ0\n\tmptOxN9vu45NyuJoXjN0bKArvC0ay+4FP76fOLee7BrartftRT62CTC6nPXq9Qpqn67L\n\t2LZw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Uvs4GP0D\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695028248; x=1695633048;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=5bSQcq0jEBWvwXLfqDd4WA4ENFOQ3ZkA/8GdnctpxnI=;\n\tb=dVkn2ROz4rjc3MQ/SWnO0hJn96T+XYkhDLZuGEm84BK63fCDUlNcaQ9+y+RELwQK+G\n\tiONpqtNKcgrqdzh44hF7hxmFn7PbO/OYt+iukVptrpEOUOyIOFecyk7+mQuuYv85TwmH\n\tNuSN7igeEqhX1rHKhAQF9bqai0V+ifTAg7J/sveVdWD74T7NEfuSVq1VMOMMuzomIMrL\n\tP0aBGZItbpP3GAxYqnCKIC7N4oqC4yt0ceuSvLBdMkzcPBHr/bVqfQqTt4B5o9i9sDWQ\n\tL/eptRFKPC0EVRGiLPBC8t69tsQ+yV27fzL4LRtDmeUBH77Zd0+hDOnCNavgmGANe2YX\n\tHtGg==", "X-Gm-Message-State": "AOJu0YwaIJh+1VtRCC0gfu0Aae80JVarQU59u6ZoNWIFeTfC45+aYxRD\n\t2jR/3A+WM317AgLcULZgSYR0jyg2598NUsx235MLkA==", "X-Google-Smtp-Source": "AGHT+IEs2agJuSVS2r0li+WOPgdEugCpLo64+S4oioj2gF1liG5YYYpiqYYAfPbhQAYSjwzHrVvKkw==", "X-Received": "by 2002:a05:600c:20d3:b0:3fe:1b5e:82 with SMTP id\n\ty19-20020a05600c20d300b003fe1b5e0082mr5911499wmm.20.1695028248431; \n\tMon, 18 Sep 2023 02:10:48 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 18 Sep 2023 10:10:45 +0100", "Message-Id": "<20230918091045.16992-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] pipeline: rpi: Reset the frame lengths\n\tqueue during configure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPA stores a list of the last 10 frame lengths applied to the\nsensor for determining the timeout to use. This list gets reset on\nstart(), but there is a path through the code that accesses this list\nin configure() which happens earlier, causing a logical error.\n\nFix this by constructing the list with 10 initial values of 0s.\n\nBug: https://github.com/raspberrypi/libcamera/issues/64\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex f7e7ad5ee499..f0ce6c75dc03 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -100,8 +100,8 @@ LOG_DEFINE_CATEGORY(IPARPI)\n namespace ipa::RPi {\n \n IpaBase::IpaBase()\n-\t: controller_(), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0),\n-\t firstStart_(true), flickerState_({ 0, 0s })\n+\t: controller_(), frameLengths_(FrameLengthsQueueSize, 0s), frameCount_(0),\n+\t mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s })\n {\n }\n \n", "prefixes": [ "libcamera-devel" ] }