Patch Detail
Show a patch.
GET /api/1.1/patches/19024/?format=api
{ "id": 19024, "url": "https://patchwork.libcamera.org/api/1.1/patches/19024/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19024/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230915130650.35691-6-jacopo.mondi@ideasonboard.com>", "date": "2023-09-15T13:06:43", "name": "[libcamera-devel,v3,05/12] libcamera: rpi: Allow platformValidate() to adjust format strides", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1047eb03c5e678d3f33aaa767dff89fa5b8a6e06", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19024/mbox/", "series": [ { "id": 4025, "url": "https://patchwork.libcamera.org/api/1.1/series/4025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4025", "date": "2023-09-15T13:06:38", "name": "libcamera: Introduce SensorConfiguration", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19024/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19024/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 821E1BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Sep 2023 13:07:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 874046292A;\n\tFri, 15 Sep 2023 15:07:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 360B062918\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Sep 2023 15:07:10 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BCD3C9A8;\n\tFri, 15 Sep 2023 15:05:36 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694783235;\n\tbh=RZhYEj/pzFsYZ1EdPil8Y7m2aIi45fZLApt+gcqLs9I=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=e5y5WoNcf+ZD1PqG3zRnIiGeEwisE3QqJDbxGvra9l4KV9XQLNChB95n+gIfx8DU4\n\t5P66tC/+BKtvhVHVXXZ7lG7MVPaQsYw0Jhj1GHvznFxbPmxd+fcgI2lAdCu6SgIm07\n\t8dTg4pNtLTaNFOvimJv5KYHMykO//JsRGiBrMMJSZLPJykAdUElAZe4fjhL/TxZti6\n\thW7XKGhsr5BrPKAuLe8+dOUhw66Gx4s6h5oywDQanxcE6bDIYTtdvcmqw/cCH12rOs\n\tPNk3BKu7YBZlRh5bk4ADq7XsvVZ9kJRTBSyAtBIXPwar+8einU7yYpZ+/9EvC6tUG+\n\tg0LVpXm3cVXvw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1694783137;\n\tbh=RZhYEj/pzFsYZ1EdPil8Y7m2aIi45fZLApt+gcqLs9I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KciLzndu+TN4h/c2nUjv5JfkXjqM2HQ0XN+1FKmpuU907T6E9VoHLunG30EU/0pC2\n\tnm4qTFnLw0D6nRNl9ms2m+mIrixKntmPim50bqZlRyGp88f1UMyG6k5LnL0oubzwnl\n\t5l7XRXVhcDqMP5FJEWslJppX1DlP1wTvj9yIsn60=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KciLzndu\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 15 Sep 2023 15:06:43 +0200", "Message-ID": "<20230915130650.35691-6-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20230915130650.35691-1-jacopo.mondi@ideasonboard.com>", "References": "<20230915130650.35691-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 05/12] libcamera: rpi: Allow\n\tplatformValidate() to adjust format strides", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Naushir Patuck <naush@raspberrypi.com>\n\nPropagate any changes to the format stride done by platformValidate().\nThe stride value may be adjusted for performace reasons.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex dff4164a5f02..2d787f4b99ed 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -305,6 +305,17 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \t\tV4L2DeviceFormat format;\n \t\tformat.fourcc = out.dev->toV4L2PixelFormat(cfg.pixelFormat);\n \t\tformat.size = cfg.size;\n+\n+\t\t/*\n+\t\t * platformValidate may have worked out the correct stride so we\n+\t\t * must pass it in. This also needs the planesCount to be set\n+\t\t * correctly or the stride will be ignored.\n+\t\t */\n+\t\tconst PixelFormat &pixFormat = format.fourcc.toPixelFormat();\n+\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixFormat);\n+\t\tformat.planesCount = info.numPlanes();\n+\t\tformat.planes[0].bpl = cfg.stride;\n+\n \t\t/* We want to send the associated YCbCr info through to the driver. */\n \t\tformat.colorSpace = yuvColorSpace_;\n \n", "prefixes": [ "libcamera-devel", "v3", "05/12" ] }