Patch Detail
Show a patch.
GET /api/1.1/patches/19001/?format=api
{ "id": 19001, "url": "https://patchwork.libcamera.org/api/1.1/patches/19001/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19001/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230912142309.170720-2-david.plowman@raspberrypi.com>", "date": "2023-09-12T14:23:09", "name": "[libcamera-devel,1/1] libcamera: controls: Add a control for IQ stability", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ae23d5769001ddd43b05890338d9399a55ad80dd", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19001/mbox/", "series": [ { "id": 4019, "url": "https://patchwork.libcamera.org/api/1.1/series/4019/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4019", "date": "2023-09-12T14:23:08", "name": "Add a control for IQ stability", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4019/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19001/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19001/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0929BC3260\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 12 Sep 2023 14:23:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79F8C628F7;\n\tTue, 12 Sep 2023 16:23:17 +0200 (CEST)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 667DC61DF5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Sep 2023 16:23:16 +0200 (CEST)", "by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-402c46c49f4so60990495e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Sep 2023 07:23:16 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:2bce:64d6:1a5c:49a2])\n\tby smtp.gmail.com with ESMTPSA id\n\to13-20020a05600c510d00b003fee777fd84sm10481514wms.41.2023.09.12.07.23.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 12 Sep 2023 07:23:14 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694528597;\n\tbh=l7S1gPVtFaDBDLTKzumhSPHFZtZFq78fUnD3Vbq+UXM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tybqRTuWU9N8Imu0LM3eVYu38AHeDeAJFfmyZRIgu0dZfUQWgoeQTlGYhKPx1GGWQ\n\tUSaDP0CFzIq/B3r07rBhFIicTUxzo4hpED8eKjc+u3xSp3SgXgWd2is0k1037HrchN\n\tHZT+ZQBlD7lIJIgIWzR8c5wFRLBhIcjV/mMpkMBRmcgrmVlmTvNO3FT29Q+npwiDfK\n\t3DBrRHGe6f1CpVEHDFKqdDZoc0YgV+DzppEDIMonU0nffXeoXo1vYOnuI2TgsWGasW\n\t4lqxPSzRswf8BdgBsGB1poqmdKaCudAawqnN2ncATg6mlk6clQq4cBPHQ/2tip6J1l\n\t1oDvVb5KDrkfw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1694528596; x=1695133396;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=d26yBqvmBC4VdvJK1yTBb3obVyXpwlz0NppPWIbadSg=;\n\tb=oMG6KO0P0L9VGzBhE8WyYm4FNfuNyrH3MwN65agu+aTe5wsI2qS4I1cawfzljXIrl2\n\tn/zQ15MdAs9sn/Q7FUJdv0xvZ7yxQbPyrlrshmjqWSIWX9R7vXO+245cB22kifBdz9Du\n\tSy8RPI4W6mVib4Pln7NUv4QSSjOdorIHI6VZipOYq/wW0RJs9ENKWnCMHp3EhGfOQZ7R\n\tqMg7nnUTPAJHfY5vXJ2QotpCZpjkXuCnxRGmFhHamuGgDPIbX8MaqvtnGeSKNfaufW4i\n\tdbU1XmT3QGyT0HH6RnXTMjLNaLZ90JjZDvWlNKbqtuSQ+WTvEctH5JIdcBYFvLwKVP3l\n\t+oyg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"oMG6KO0P\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1694528596; x=1695133396;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=d26yBqvmBC4VdvJK1yTBb3obVyXpwlz0NppPWIbadSg=;\n\tb=ZCTtyUGU8V00QbahUcDHMtLRdRR8fbgO40Zw1+MVuWGwnvSyO4akf0GTMbribgEoJO\n\tc0Dw5BcPW5YnoS/UnK3b95WC12A3ln82agbmM+9hHBOnZbMJhDVuGtgGwaQs6h7alpLe\n\tcXOYGHhL5HOCfZ/k28NdVIbquN/ohwYIK64uokfYuzVcO29Ek8JRQnLxB7bqdJ+WXHzf\n\thJoPECT8wBBMOM/5m7f/Xf/1DaPTNtf71SXAGWAVufkXWBL/bCaGnV6DumKreeVVQh6R\n\t7ycofaapuIhT/l7l60EcQmrMyptHF82aBmiKY8DHAqMwbuSNLtOgr4vajUDWeDFSqHOY\n\tpyNA==", "X-Gm-Message-State": "AOJu0YzCfYAkhYU+IDxB4s11voUIM2xNjrNn7vupXvak489MMqcAAcGh\n\taxKooOI9pqTr2hxZP5lTc81LP56AI1x4AYj7PG0=", "X-Google-Smtp-Source": "AGHT+IGI8e3PTzugtF8nufkUVZm/Y3yHYtMnIFXe5PudJ0MsQsy/hDgfnq5O81GIOKLHUMxQVFgJOA==", "X-Received": "by 2002:a05:600c:1d85:b0:403:50:a61e with SMTP id\n\tp5-20020a05600c1d8500b004030050a61emr8302516wms.24.1694528595722; \n\tTue, 12 Sep 2023 07:23:15 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 12 Sep 2023 15:23:09 +0100", "Message-Id": "<20230912142309.170720-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230912142309.170720-1-david.plowman@raspberrypi.com>", "References": "<20230912142309.170720-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/1] libcamera: controls: Add a control\n\tfor IQ stability", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "David Plowman <david.plowman@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IqUnstable metadata can be used by IPAs to indicate to an\napplication that they have not settled sufficiently to produce\nreliable image quality. Applications would be advised to avoid using\nframes flagged in this way.\n\nOne example would be when the camera starts, when the AEC/AGC might\noscillate for a few frames.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex f2e542f4..b96e1272 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -774,6 +774,26 @@ controls:\n Continuous AF is paused. No further state changes or lens movements\n will occur until the AfPauseResume control is sent.\n \n+ - IqUnstable:\n+ type: bool\n+ description: |\n+ The value true indicates that the camera algorithms have not settled\n+ sufficiently to generate images of reliable quality. The application\n+ receiving this frame is advised to drop it and wait for a frame where\n+ this metadata reports false (or is absent).\n+\n+ One example of this would be when the camera system starts. It may be\n+ trying to adapt very quickly to the ambient conditions, resulting in a\n+ few frames where the image brightness may be subject to unusually\n+ extreme oscillations.\n+\n+ The control may report true at other times, for example when an HDR mode\n+ is enabled. Here too there may be a few frames of unpredictable exposure\n+ until the algorithms have settled.\n+\n+ The value false (or absence of the control) indicates that this is a\n+ normal frame.\n+\n # ----------------------------------------------------------------------------\n # Draft controls section\n \n", "prefixes": [ "libcamera-devel", "1/1" ] }