Patch Detail
Show a patch.
GET /api/1.1/patches/18978/?format=api
{ "id": 18978, "url": "https://patchwork.libcamera.org/api/1.1/patches/18978/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18978/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230907161259.2942654-1-gbiv@google.com>", "date": "2023-09-07T16:12:59", "name": "[libcamera-devel] meson: Don't set _FORTIFY_SOURCE for ChromeOS", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "4d1c81e0b6d01b2d510c626fd1532501c3cc784e", "submitter": { "id": 172, "url": "https://patchwork.libcamera.org/api/1.1/people/172/?format=api", "name": "George Burgess", "email": "gbiv@google.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18978/mbox/", "series": [ { "id": 4013, "url": "https://patchwork.libcamera.org/api/1.1/series/4013/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4013", "date": "2023-09-07T16:12:59", "name": "[libcamera-devel] meson: Don't set _FORTIFY_SOURCE for ChromeOS", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4013/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18978/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18978/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF516C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Sep 2023 16:21:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45227628EC;\n\tThu, 7 Sep 2023 18:21:23 +0200 (CEST)", "from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com\n\t[IPv6:2607:f8b0:4864:20::1149])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2546627DF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Sep 2023 18:13:16 +0200 (CEST)", "by mail-yw1-x1149.google.com with SMTP id\n\t00721157ae682-58cbf62bae8so12738267b3.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 07 Sep 2023 09:13:16 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694103683;\n\tbh=TnaDc4CcDOsunXGKpvmbUM/W5kZf+xmPdWiSaOuUk78=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=CGS3UQzD/Jx0qw+uOs4kQlBNCjLWpMBEugKuXz2U2cExkmF7nOfyKEbB7xYd+38L6\n\tn5G0sT/qsEwjai2I8kcc6feq6XqO0abIyFtB5rvf89fo/PxGqu4tIAF+koW7k0jbt+\n\tXnGf3Vj/0PRIMlv+ru4hzgLch8zsrZ5EW2bTEN15FF+sXYvQmou1a+/5HNkoGe/Tfz\n\tgcXE5envRrASz3I2qiJ7n0aeeKVsIAFHY8Blg0WldSxR3dRtv1aiiPaRksRnNGg48Q\n\tOCkeZL1HuWpQs6tqaNzWncSqhAVqGy9OXtJVqOh6y+qXSHwM+NkvBmZlTqI8Pq9h8F\n\t1AF2jXVOU5TsA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20221208; t=1694103195; x=1694707995;\n\tdarn=lists.libcamera.org; \n\th=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=1Ap1qRpiF3VPmfIEnUdkfD275HjbYDD84stF1Ks5T+0=;\n\tb=Rv5xBnToulvmAxjcLASg+JHkyRswCSLqZo9GnXmMzVQpBrD5JoeUPclmOvltxf+HdF\n\tPR7rg/V4RcbMhKToqFlRC5sIu5xEPe6aP2W7TrID3IViEKdg/fbplWmBsR+6O+sfdn8k\n\taCfv26WXqEpbduz8KDJaIMDixkmlY+k16DzlZ6Z2L20hnuChlkDVVKtHktbYGwwgzTy2\n\tnZTBo0QkLNgP9jHANLyQaqqCFOLgX+6c6BaYT4Mg7sWFiSSgTpmL7gqkrAsxxXDWDjSH\n\tjLNQauWF9HP5BCzBq8y06fcSBkXe2R0WoqTEPU7B7+b5vZ21oSElTvA9J4zYBdkDYYmW\n\t9sWw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=google.com\n\theader.i=@google.com header.b=\"Rv5xBnTo\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1694103195; x=1694707995;\n\th=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=1Ap1qRpiF3VPmfIEnUdkfD275HjbYDD84stF1Ks5T+0=;\n\tb=GSOTqc774aT/b/vpMIr09IsjL5hq7zRohl1HZ1IYyB8QpisCH1ECtj9QoYBWOD6q4W\n\tBmp1ykIUbz7uRKIaa+MpT7FwOj6b+n69rWNFr85/2h+E2T0VpuIaXdSc5l9xvuPyOV1S\n\tZWAGVc9HtYziKFzdl91zgZ9eHGRJRorq9NmTW27h7eWCdQO9Z5zmC2yVGXY2S9MNYQn2\n\tVW5MTu4J60oq+mkvkm2vcZ37Xy82bQbNPkxTt+sDQNBpEYTrZJfqiAetCBDsgDGg4ii9\n\tiW872ztgDExkECUw/ckkjOMNkbPYFLOylJ47rL4H3PsgDAxayIbdPob+mKGvuIrsm4CR\n\tqckA==", "X-Gm-Message-State": "AOJu0Yys918DzS1uLvFVjNvDDjuyo3+XA3Lm5ADJbGP9JYdNXQ6JuGhM\n\tCoNrJOGCramaXqQM6RVTpo5sd8T2dRcQiRYxlrfPRhFf3rZ0m7QtM9Ane60yq8cLxkBff2Pti8E\n\teNwUy4VAPtbnbZwmhP4huSKdwEra8ImqpVLyRBbo7StgLH+tXTKfY0jyBWwHd77sURRrR++1Nbg\n\t==", "X-Google-Smtp-Source": "AGHT+IH1b32n+SWUVnDReMFiXVZWrDMClshlfFIRz7+rSVJoKKX7npKa4aYAInjqVsn+M4e95wCPK4Su", "X-Received": "from gbivco.c.googlers.com\n\t([fda3:e722:ac3:cc00:2b:ff92:c0a8:22d5])\n\t(user=gbiv job=sendgmr) by 2002:a05:6902:1781:b0:d80:896:f16c with\n\tSMTP id\n\tca1-20020a056902178100b00d800896f16cmr27524ybb.9.1694103195421;\n\tThu, 07 Sep 2023 09:13:15 -0700 (PDT)", "Date": "Thu, 7 Sep 2023 10:12:59 -0600", "Mime-Version": "1.0", "X-Mailer": "git-send-email 2.42.0.283.g2d96d420d3-goog", "Message-ID": "<20230907161259.2942654-1-gbiv@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Mailman-Approved-At": "Thu, 07 Sep 2023 18:21:22 +0200", "Subject": "[libcamera-devel] [PATCH] meson: Don't set _FORTIFY_SOURCE for\n\tChromeOS", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "George Burgess IV via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "George Burgess IV <gbiv@google.com>", "Cc": "George Burgess IV <gbiv@google.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "ChromeOS is moving to a platform default of `_FORTIFY_SOURCE=3`, and\nthis definition conflicts with that:\n\n```\n<command line>:4:9: error: '_FORTIFY_SOURCE' macro redefined\n[-Werror,-Wmacro-redefined]\n```\n\nRather than adding logic to keep up with their local configuration, it\nseems best to leave setting _FORTIFY_SOURCE on ChromeOS up to ChromeOS.\n\nSigned-off-by: George Burgess IV <gbiv@google.com>\n---\n meson.build | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 7959b538..109923ac 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -101,7 +101,8 @@ if cc.get_id() == 'clang'\n \n # Turn _FORTIFY_SOURCE by default on optimised builds (as it requires -O1\n # or higher). This is needed on clang only as gcc enables it by default.\n- if get_option('optimization') != '0'\n+ # CrOS sets their preferred FORTIFY level in platform-level CFLAGS.\n+ if get_option('optimization') != '0' and get_option('android_platform') != 'cros'\n common_arguments += [\n '-D_FORTIFY_SOURCE=2',\n ]\n", "prefixes": [ "libcamera-devel" ] }