Patch Detail
Show a patch.
GET /api/1.1/patches/1894/?format=api
{ "id": 1894, "url": "https://patchwork.libcamera.org/api/1.1/patches/1894/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1894/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190829232653.13214-8-niklas.soderlund@ragnatech.se>", "date": "2019-08-29T23:26:46", "name": "[libcamera-devel,v2,07/14] libcamera: controls: Allow read only access to control values", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b2b153e4b5038ccc374c795ef5a002baad1943a3", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1894/mbox/", "series": [ { "id": 475, "url": "https://patchwork.libcamera.org/api/1.1/series/475/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=475", "date": "2019-08-29T23:26:40", "name": "libcamera: ipa: Add basic IPA support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/475/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1894/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1894/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C810C6192E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2019 01:27:33 +0200 (CEST)", "from bismarck.berto.se (unknown [79.202.45.17])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 908c63f9-cab4-11e9-837a-0050569116f7;\n\tFri, 30 Aug 2019 01:27:28 +0200 (CEST)" ], "X-Halon-ID": "908c63f9-cab4-11e9-837a-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Aug 2019 01:26:46 +0200", "Message-Id": "<20190829232653.13214-8-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.22.1", "In-Reply-To": "<20190829232653.13214-1-niklas.soderlund@ragnatech.se>", "References": "<20190829232653.13214-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 07/14] libcamera: controls: Allow read\n\tonly access to control values", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 29 Aug 2019 23:27:34 -0000" }, "content": "Allow the control values in a ControlList to be examined from a const\nenvironment.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/controls.h | 1 +\n src/libcamera/controls.cpp | 34 ++++++++++++++++++++++++++++++++++\n 2 files changed, 35 insertions(+)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex fbb3a62274c64259..eee5ef87b8fd2633 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -124,6 +124,7 @@ public:\n \tvoid clear() { controls_.clear(); }\n \n \tControlValue &operator[](ControlId id);\n+\tconst ControlValue &operator[](ControlId id) const;\n \tControlValue &operator[](const ControlInfo *info) { return controls_[info]; }\n \n \tvoid update(const ControlList &list);\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 35861e27401d5241..12cbf778408ee8e7 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -521,6 +521,40 @@ ControlValue &ControlList::operator[](ControlId id)\n \treturn controls_[&iter->second];\n }\n \n+/**\n+ * \\brief Access a control specified by \\a id\n+ * \\param[in] id The control ID\n+ *\n+ * This method returns a reference to the control identified by \\a id, if it\n+ * exists or an empty control if it does not.\n+ *\n+ * The behaviour is undefined if the control \\a id is not supported by the\n+ * camera that the ControlList refers to.\n+ *\n+ * \\return A reference to the value of the control identified by \\a id\n+ */\n+const ControlValue &ControlList::operator[](ControlId id) const\n+{\n+\tconst ControlInfoMap &controls = camera_->controls();\n+\tstatic ControlValue empty;\n+\n+\tconst auto iter = controls.find(id);\n+\tif (iter == controls.end()) {\n+\t\tLOG(Controls, Error)\n+\t\t\t<< \"Camera \" << camera_->name()\n+\t\t\t<< \" does not support control \" << id;\n+\t\treturn empty;\n+\t}\n+\n+\tconst auto it = controls_.find(&iter->second);\n+\tif (it == controls_.end()) {\n+\t\tLOG(Controls, Error) << \"list does not have control \" << id;\n+\t\treturn empty;\n+\t}\n+\n+\treturn it->second;\n+}\n+\n /**\n * \\fn ControlList::operator[](const ControlInfo *info)\n * \\brief Access or insert the control specified by \\a info\n", "prefixes": [ "libcamera-devel", "v2", "07/14" ] }