Patch Detail
Show a patch.
GET /api/1.1/patches/18936/?format=api
{ "id": 18936, "url": "https://patchwork.libcamera.org/api/1.1/patches/18936/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18936/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230808125228.29043-10-jacopo.mondi@ideasonboard.com>", "date": "2023-08-08T12:52:28", "name": "[libcamera-devel,RFC,9/9,HACK] libcamera: pipeline: Add usb-test pipeline", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b33ca411fa7ecd825804f98b7824f5a93c5f4018", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18936/mbox/", "series": [ { "id": 4002, "url": "https://patchwork.libcamera.org/api/1.1/series/4002/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4002", "date": "2023-08-08T12:52:19", "name": "libcamera: Generalize device match and support USB devices", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4002/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18936/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18936/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15CF2C32B3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 8 Aug 2023 12:52:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82470627F6;\n\tTue, 8 Aug 2023 14:52:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCD49627F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 8 Aug 2023 14:52:51 +0200 (CEST)", "from uno.localdomain (mob-5-90-60-22.net.vodafone.it [5.90.60.22])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC15B87CC; \n\tTue, 8 Aug 2023 14:51:43 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1691499179;\n\tbh=bVaPL/jKTBsyEmGOyaB8CwG8+poD9A6OtASWtadqCw4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mi7Ff+/HW1hj/q+GqByY1rtKLLblV0zBGRneP4NcSB2wlAGfG0wZPXAIbXQCKEA0Y\n\ttb3/BAX8yH6WDea9F8x0N65r0/22TfLaQOxjDh+QgX5Tf34cIDAzZDHBYgum68ezBo\n\tgKXaEP6rMslRNcZpiaFzWZV5EGAucpISbMO/0TVkiEkoD1cGrjwPxdO104lsjK3E7r\n\tClJsHcu84FdVGU3KXeFX+GZb4ac1EL+DC7E/KuTXI3hoqvhIX+CpXCrhDZcGz1Yg6L\n\tv0nr31XxUROHt4ZAlzneU4P41M+jbGGoW954GqijxFMSf1IZZG8lDBjdQdXVzokzwE\n\tax83mZHlZkvXA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1691499104;\n\tbh=bVaPL/jKTBsyEmGOyaB8CwG8+poD9A6OtASWtadqCw4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WMy/mt9Q0VIC2pwET4rg3CDLAq6DxE9D8cPbwGJQjreeQ3v9Ona+QjJs06XP5Wlg3\n\tlV5zsgSxqUWikZ+XL/tys0YhrcXUuD5LKS+Ap+1UF6RykvG2ve+puOrVUVMRpJEeRw\n\tcTK16uq2nObX0F0TBky2nIqyFwVxWqEuH+3X/rdg=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WMy/mt9Q\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org, Sophie Friedrich <dev@flowerpot.me>", "Date": "Tue, 8 Aug 2023 14:52:28 +0200", "Message-Id": "<20230808125228.29043-10-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20230808125228.29043-1-jacopo.mondi@ideasonboard.com>", "References": "<20230808125228.29043-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC 9/9] [HACK] libcamera: pipeline: Add\n\tusb-test pipeline", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a test pipeline to match on a USBDevice. This is a proof of concept\nas the pipeline handler matches on my mouse VID/PID pair.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n meson_options.txt | 1 +\n src/libcamera/pipeline/usb-test/meson.build | 5 ++\n src/libcamera/pipeline/usb-test/usb_test.cpp | 93 ++++++++++++++++++++\n 3 files changed, 99 insertions(+)\n create mode 100644 src/libcamera/pipeline/usb-test/meson.build\n create mode 100644 src/libcamera/pipeline/usb-test/usb_test.cpp", "diff": "diff --git a/meson_options.txt b/meson_options.txt\nindex fad928af4b62..e706484be109 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -46,6 +46,7 @@ option('pipelines',\n 'rkisp1',\n 'rpi/vc4',\n 'simple',\n+ 'usb-test',\n 'uvcvideo',\n 'vimc'\n ],\ndiff --git a/src/libcamera/pipeline/usb-test/meson.build b/src/libcamera/pipeline/usb-test/meson.build\nnew file mode 100644\nindex 000000000000..bafff18e7b0b\n--- /dev/null\n+++ b/src/libcamera/pipeline/usb-test/meson.build\n@@ -0,0 +1,5 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+libcamera_sources += files([\n+ 'usb_test.cpp',\n+])\ndiff --git a/src/libcamera/pipeline/usb-test/usb_test.cpp b/src/libcamera/pipeline/usb-test/usb_test.cpp\nnew file mode 100644\nindex 000000000000..5df1a137f81f\n--- /dev/null\n+++ b/src/libcamera/pipeline/usb-test/usb_test.cpp\n@@ -0,0 +1,93 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2023, Ideas On Board Oy\n+ *\n+ * usb_test.cpp - Test USB device matching\n+ */\n+\n+#include <libcamera/base/log.h>\n+\n+#include <libcamera/camera.h>\n+#include <libcamera/stream.h>\n+\n+#include \"libcamera/internal/camera.h\"\n+#include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/pipeline_handler.h\"\n+#include \"libcamera/internal/usb_device.h\"\n+\n+namespace libcamera {\n+\n+LOG_DEFINE_CATEGORY(USBTest)\n+\n+class USBCameraData : public Camera::Private\n+{\n+public:\n+\tUSBCameraData(PipelineHandler *pipe)\n+\t\t: Camera::Private(pipe)\n+\t{\n+\t}\n+\n+\tStream stream_;\n+};\n+\n+class PipelineHandlerUSB : public PipelineHandler\n+{\n+public:\n+\tPipelineHandlerUSB(CameraManager *manager)\n+\t\t: PipelineHandler(manager)\n+\t{\n+\t}\n+\n+\tstd::unique_ptr<CameraConfiguration> generateConfiguration([[maybe_unused]] Camera *camera,\n+\t\t\t\t\t\t\t\t [[maybe_unused]] Span<const StreamRole> roles) override\n+\t{\n+\t\treturn {};\n+\t}\n+\tint configure([[maybe_unused]] Camera *camera, [[maybe_unused]] CameraConfiguration *config) override\n+\t{\n+\t\treturn 0;\n+\t}\n+\n+\tint exportFrameBuffers([[maybe_unused]] Camera *camera, [[maybe_unused]] Stream *stream,\n+\t\t\t [[maybe_unused]] std::vector<std::unique_ptr<FrameBuffer>> *buffers) override\n+\t{\n+\t\treturn 0;\n+\t}\n+\n+\tint start([[maybe_unused]] Camera *camera, [[maybe_unused]] const ControlList *controls) override\n+\t{\n+\t\treturn 0;\n+\t}\n+\tvoid stopDevice([[maybe_unused]] Camera *camera) override\n+\t{\n+\t}\n+\n+\tint queueRequestDevice([[maybe_unused]] Camera *camera, [[maybe_unused]] Request *request) override\n+\t{\n+\t\treturn 0;\n+\t}\n+\n+\tbool match(DeviceEnumerator *enumerator) override;\n+};\n+\n+bool PipelineHandlerUSB::match(DeviceEnumerator *enumerator)\n+{\n+\tUSBDeviceMatch dm(\"046d\", \"c52b\");\n+\tUSBDevice *usbDev = acquireUSBDevice(enumerator, dm);\n+\tif (!usbDev)\n+\t\treturn false;\n+\n+\tstd::unique_ptr<USBCameraData> data = std::make_unique<USBCameraData>(this);\n+\tstd::string id = usbDev->vid() + \"/\" + usbDev->pid();\n+\tstd::set<Stream *> streams{ &data->stream_ };\n+\n+\tstd::shared_ptr<Camera> camera =\n+\t\tCamera::create(std::move(data), id, streams);\n+\tregisterCamera(std::move(camera));\n+\n+\treturn true;\n+}\n+\n+REGISTER_PIPELINE_HANDLER(PipelineHandlerUSB)\n+\n+} /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "RFC", "9/9", "HACK" ] }