Patch Detail
Show a patch.
GET /api/1.1/patches/18851/?format=api
{ "id": 18851, "url": "https://patchwork.libcamera.org/api/1.1/patches/18851/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18851/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230718105210.83558-11-jacopo.mondi@ideasonboard.com>", "date": "2023-07-18T10:52:10", "name": "[libcamera-devel,v3,10/10] apps: cam: Add option to set stream orientation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2057c286637cfc8eabdb8f5fd612081d1be313c7", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18851/mbox/", "series": [ { "id": 3976, "url": "https://patchwork.libcamera.org/api/1.1/series/3976/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3976", "date": "2023-07-18T10:52:00", "name": "libcamera: Replace CameraConfiguration::transform", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3976/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18851/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18851/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6DACC32AD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 18 Jul 2023 10:52:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90702628CC;\n\tTue, 18 Jul 2023 12:52:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7EA3628C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Jul 2023 12:52:30 +0200 (CEST)", "from uno.localdomain (mob-5-90-54-150.net.vodafone.it\n\t[5.90.54.150])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1CE68D0;\n\tTue, 18 Jul 2023 12:51:36 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689677554;\n\tbh=xZiKf0IW1VQsytjg7nKnQa6dxUGuyIJmhWSQge3KGps=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2URllzDrE2gXKIct5VNxGbruzepq9egyFcC6pWF3kLnRtzRgD23Dn0kvb/esMP76M\n\t85OVmrdejZpldTaKmXmEUTy/mmwNCHo5K98sXx9F2kwjoswz4zz2jqznGGnKbz6zco\n\tpzpzsim6RZYB+b1EPiN7ZtK5qRnCne11ttSxNS/vB4X7UTFCNiY0enmHVsSkd/ohH1\n\tsf3Klcmu66gTbKeqUIV9GLdzJ6GNMgSJryvy1fw7jKg3+L9E6dQT9CGaM6pi3WwlEi\n\t5G/aRbIxijfZmofPMJ4lKeoXgyNXxVnMUrq51bJc1qpTygwg54r6H4EqFCm+uESrdT\n\t/XZH++qIZiQ9g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689677497;\n\tbh=xZiKf0IW1VQsytjg7nKnQa6dxUGuyIJmhWSQge3KGps=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ds9OppLdP5TRQCUTaGGSxNLeiq1SdujtijmOwbhNT6qQVII+r+z2gLpvBdKACM5KG\n\thl6rHXILKywx0tAY2uu7iJ99GBDtSoanxVk76Ieikl8tMHxrDiHNnQN+Lfpk1IdEfN\n\tqyDieZa68pGJ+lOa88vXNTqbnk1MywD9HaprqeKM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ds9OppLd\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 18 Jul 2023 12:52:10 +0200", "Message-Id": "<20230718105210.83558-11-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20230718105210.83558-1-jacopo.mondi@ideasonboard.com>", "References": "<20230718105210.83558-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 10/10] apps: cam: Add option to set\n\tstream orientation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a '--orientation|-o' option to the cam test application to set\nan orientation to the image stream.\n\nSupported values are the ones obtained by applying flips to the camera\nsensor:\n- rot180: Rotate 180 degrees\n- flip: vertical flip\n- mirror: horizontal flip\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/apps/cam/camera_session.cpp | 17 +++++++++++++++++\n src/apps/cam/main.cpp | 5 +++++\n src/apps/cam/main.h | 1 +\n 3 files changed, 23 insertions(+)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 066e397b5f47..1cf7a245aaa7 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -65,6 +65,23 @@ CameraSession::CameraSession(CameraManager *cm,\n \t\treturn;\n \t}\n \n+\tif (options_.isSet(OptOrientation)) {\n+\t\tstd::string orient = options_[OptOrientation].toString();\n+\t\tif (orient == \"rot180\") {\n+\t\t\tconfig->orientation =\n+\t\t\t\tlibcamera::Orientation::rotate180;\n+\t\t} else if (orient == \"mirror\") {\n+\t\t\tconfig->orientation =\n+\t\t\t\tlibcamera::Orientation::rotate0Flip;\n+\t\t} else if (orient == \"flip\") {\n+\t\t\tconfig->orientation =\n+\t\t\t\tlibcamera::Orientation::rotate180Flip;\n+\t\t} else {\n+\t\t\tstd::cerr << \"Invalid orientation \" << orient << std::endl;\n+\t\t\treturn;\n+\t\t}\n+\t}\n+\n \t/* Apply configuration if explicitly requested. */\n \tif (StreamKeyValueParser::updateConfiguration(config.get(),\n \t\t\t\t\t\t options_[OptStream])) {\ndiff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\nindex 5d8a57bc14e5..8698d5eedcf8 100644\n--- a/src/apps/cam/main.cpp\n+++ b/src/apps/cam/main.cpp\n@@ -133,6 +133,11 @@ int CamApp::parseOptions(int argc, char *argv[])\n \t\t\t \"Capture until interrupted by user or until <count> frames captured\",\n \t\t\t \"capture\", ArgumentOptional, \"count\", false,\n \t\t\t OptCamera);\n+\n+\tparser.addOption(OptOrientation, OptionString,\n+\t\t\t \"The camera stream image orientation (rot180, mirror, flip)\",\n+\t\t\t \"orientation\", ArgumentRequired, \"orientation\", false,\n+\t\t\t OptCamera);\n #ifdef HAVE_KMS\n \tparser.addOption(OptDisplay, OptionString,\n \t\t\t \"Display viewfinder through DRM/KMS on specified connector\",\ndiff --git a/src/apps/cam/main.h b/src/apps/cam/main.h\nindex 526aecece3f3..4aa959b32e13 100644\n--- a/src/apps/cam/main.h\n+++ b/src/apps/cam/main.h\n@@ -17,6 +17,7 @@ enum {\n \tOptList = 'l',\n \tOptListProperties = 'p',\n \tOptMonitor = 'm',\n+\tOptOrientation = 'o',\n \tOptSDL = 'S',\n \tOptStream = 's',\n \tOptListControls = 256,\n", "prefixes": [ "libcamera-devel", "v3", "10/10" ] }