Patch Detail
Show a patch.
GET /api/1.1/patches/18808/?format=api
{ "id": 18808, "url": "https://patchwork.libcamera.org/api/1.1/patches/18808/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18808/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230711133915.650485-4-kieran.bingham@ideasonboard.com>", "date": "2023-07-11T13:39:14", "name": "[libcamera-devel,3/4] utils: checkstyle.py: Derive Amendment from Commit", "commit_ref": "e2f0ad27b18b1502f59268bda2eeff4a7a21055c", "pull_url": null, "state": "accepted", "archived": false, "hash": "b2d747a6d9663b21c988a7223dacc5865da9da5d", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18808/mbox/", "series": [ { "id": 3966, "url": "https://patchwork.libcamera.org/api/1.1/series/3966/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3966", "date": "2023-07-11T13:39:11", "name": "utils: checkstyle.py: Fix Trailer handling", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3966/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18808/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18808/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB706C32AA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 11 Jul 2023 13:39:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B60A628C0;\n\tTue, 11 Jul 2023 15:39:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D435460570\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Jul 2023 15:39:20 +0200 (CEST)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06C3F8CC;\n\tTue, 11 Jul 2023 15:38:31 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689082764;\n\tbh=FnsDFbhbH5fHvsvlfP3Vh11bJ9n/j776hWcPzDBcxcU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vTNn6pJD3CTzH7/zVWhuV81s9/gjDdQP26ge2n/fb4aKy8p9zSWT2PVDoZvnBFGIk\n\tLKxNeAQhe2UKjmnZE/KnAIVQeg7/O0y3NLXR57zNE35JOtj/SyYTjiOp3KHxV7uR1L\n\tQ92N/ukYZMI//5UHOivWhGH7aJPajd8OMdbR5+ViIH/leR3Scr08wUQH8ntpi4pdVk\n\to6oo7R/FY27B/uNSVls4jbIEsNP5aiudgfDmwhTI4Cov0HSeTwk8GApaJM42rswwEU\n\tpBV7BWjsOKkyiI3qY/M2AJ+p2Ylwm+fdzhF5spzN1NSRPpaK+F95fVVBckbxspiPLM\n\tvJi5jXwGD4b8A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689082712;\n\tbh=FnsDFbhbH5fHvsvlfP3Vh11bJ9n/j776hWcPzDBcxcU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kQTibisfP767fMqlyo55lKLDZ0/Zt76jEc11rVTbCJHXdq4HTOYQRIqQLH+SOkZO1\n\tJ3Shm2uY6h46P4U8AWIuqJdNzbOAFeZ84FQ3WmmoB20tFuS+aANhfq+7isOdTuKyXM\n\t5ZvpCLK18Bnp3EqyDRQ7ILOkbrPCsaeNeiQoCsAM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kQTibisf\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 11 Jul 2023 14:39:14 +0100", "Message-Id": "<20230711133915.650485-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230711133915.650485-1-kieran.bingham@ideasonboard.com>", "References": "<20230711133915.650485-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/4] utils: checkstyle.py: Derive\n\tAmendment from Commit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Amendment commit class is derived from the StagedChanges class\n(which in turn derives from the Commit base class), however there is no\ncode sharing between Amendment and StagedChanges other than the call to\ninitalise through the base Commit class.\n\nRefactor the inheritance to make an Amendment derive directly from\nCommit.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n utils/checkstyle.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 2ba3165b8ecd..5663af811961 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -269,9 +269,9 @@ class StagedChanges(Commit):\n return parse_diff(diff.splitlines(True))\n \n \n-class Amendment(StagedChanges):\n+class Amendment(Commit):\n def __init__(self):\n- StagedChanges.__init__(self)\n+ Commit.__init__(self, '')\n \n def _parse(self):\n # Create a title using HEAD commit\n", "prefixes": [ "libcamera-devel", "3/4" ] }