Patch Detail
Show a patch.
GET /api/1.1/patches/18806/?format=api
{ "id": 18806, "url": "https://patchwork.libcamera.org/api/1.1/patches/18806/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18806/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230711133915.650485-2-kieran.bingham@ideasonboard.com>", "date": "2023-07-11T13:39:12", "name": "[libcamera-devel,1/4] utils: checkstyle.py: Treat Malformed trailers as a CommitIssue", "commit_ref": "b14d2cab127b05399348cca31eb9190eee0f305f", "pull_url": null, "state": "accepted", "archived": false, "hash": "6c3cae35d0e4aead3376d92cfd6944a5ebddada7", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18806/mbox/", "series": [ { "id": 3966, "url": "https://patchwork.libcamera.org/api/1.1/series/3966/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3966", "date": "2023-07-11T13:39:11", "name": "utils: checkstyle.py: Fix Trailer handling", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3966/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18806/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18806/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAEA5C3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 11 Jul 2023 13:39:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5D82628C7;\n\tTue, 11 Jul 2023 15:39:22 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6AEF861E32\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Jul 2023 15:39:20 +0200 (CEST)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 69EFF9B9;\n\tTue, 11 Jul 2023 15:38:31 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689082762;\n\tbh=NcyCkiLhkOsMM7/Czz7Q19u8pchZ6gml5HMwcIfkcxw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vNF8Bms0M2HMig1z9imQv/h2V9Ujdq5kcEWfsK2AQyJqHS2I5LXXomacCKDLx/r+U\n\t2Ewx/m7DnzzNFHka64nqVhEW6BaS16BDy2Bp+hA5t2KFsPnStcFF5mMKob9x9jjBfO\n\tlSaUcCWPLbeMj2nWFcoGHQJmuFMUgLyy067nimiI0dfIYWiALK4RGstRsbDzVRgTQZ\n\tPstHKkFa6jse3iPDe0BGdgvIg8mrs4YZ63lKJpYqoH+6cu/YduFe2R81OkzsRPvLKt\n\t5OjTm//2GloPkb9hsi9qRBn5L4RG3cx/ZDgUI3eSxt5+XOM7g38E61R753ul+/gESJ\n\tv3ClNPjt/uAwA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689082711;\n\tbh=NcyCkiLhkOsMM7/Czz7Q19u8pchZ6gml5HMwcIfkcxw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=R/eVzJi/QzQ6urHl2NFDeisj6P2rQlViluwuZdhB/Shlkwn7DMOQAybDpXezP79NG\n\t+ry7JXf18pfOTQU2xCnIlU4Zxz7GGPktVIp1ywDsA7i+7NJNWdFgeIREckcZMKw8Sb\n\t5NqQC006XAWCIaWs+pqBZEzlUGw1X25SDUhXj56k=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R/eVzJi/\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 11 Jul 2023 14:39:12 +0100", "Message-Id": "<20230711133915.650485-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230711133915.650485-1-kieran.bingham@ideasonboard.com>", "References": "<20230711133915.650485-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/4] utils: checkstyle.py: Treat Malformed\n\ttrailers as a CommitIssue", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If a Malformed trailer is identified the checkstyle script triggers a\nRuntimeError and stops processing the rest of the commit.\n\nA malformed trailer can be regarded as an issue in the commit and\nreported as such using the same method as other faults identified by the\ntool.\n\nConvert the RuntimeError into a CommitIssue and continue processing\nother trailers.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n utils/checkstyle.py | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 3558740d389d..5a1268064d31 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -479,7 +479,8 @@ class TrailersChecker(CommitChecker):\n for trailer in commit.trailers:\n match = TrailersChecker.trailer_regex.fullmatch(trailer)\n if not match:\n- raise RuntimeError(f\"Malformed commit trailer '{trailer}'\")\n+ issues.append(CommitIssue(f\"Malformed commit trailer '{trailer}'\"))\n+ continue\n \n key, value = match.groups()\n \n", "prefixes": [ "libcamera-devel", "1/4" ] }