Patch Detail
Show a patch.
GET /api/1.1/patches/1880/?format=api
{ "id": 1880, "url": "https://patchwork.libcamera.org/api/1.1/patches/1880/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1880/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190828141343.10237-1-jacopo@jmondi.org>", "date": "2019-08-28T14:13:43", "name": "[libcamera-devel] android: camera_device: Add pipeline max depth static metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "64f8b9d27e956984c5870247bd59dfc9a90ba8a4", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/1880/mbox/", "series": [ { "id": 472, "url": "https://patchwork.libcamera.org/api/1.1/series/472/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=472", "date": "2019-08-28T14:13:43", "name": "[libcamera-devel] android: camera_device: Add pipeline max depth static metadata", "version": 1, "mbox": "https://patchwork.libcamera.org/series/472/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1880/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1880/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BBF160BF6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Aug 2019 16:12:21 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id DAFCC1C0010;\n\tWed, 28 Aug 2019 14:12:20 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo@jmondi.org>, kamesan@google.com,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Wed, 28 Aug 2019 16:13:43 +0200", "Message-Id": "<20190828141343.10237-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] android: camera_device: Add pipeline max\n\tdepth static metadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 28 Aug 2019 14:12:21 -0000" }, "content": "The ANDROID_REQUEST_PIPELINE_MAX_DEPTH metadata tag was wrongly\nreported in the capture settings template, while it is actually a static\ncamera metadata.\n\nAs of Chromium R78 the absence of this specific metadata tag causes a\nsystem crash. Fix this by reporting the maximum pipeline depth in the\nstatic metadata pack and set its value to 1 as currently no control is\napplied to the image capture pipeline.\n\nReported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSuggested-by: Ren-Pei Zeng <kamesan@google.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\n---\nLaurent, as you're running R78 and first reported the crash, could you please\ngive this a spin and report if the issue is still present?\n\n---\n src/android/camera_device.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\n--\n2.23.0", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex c27175ac090d..7c69d0810eee 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -281,6 +281,13 @@ camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n \t\t\t&supportedHWLevel, 1);\n\n+\t/* Request static metadata. */\n+\tuint8_t maxPipelineDepth = 1;\n+\tret = add_camera_metadata_entry(staticMetadata_,\n+\t\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n+\t\t\t&maxPipelineDepth, 1);\n+\tMETADATA_ASSERT(ret);\n+\n \treturn staticMetadata_;\n }\n\n@@ -340,12 +347,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \t\t\tmaxOutStream, 3);\n \tMETADATA_ASSERT(ret);\n\n-\tuint8_t maxPipelineDepth = 5;\n-\tret = add_camera_metadata_entry(requestTemplate_,\n-\t\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n-\t\t\t&maxPipelineDepth, 1);\n-\tMETADATA_ASSERT(ret);\n-\n \tint32_t inputStreams = 0;\n \tret = add_camera_metadata_entry(requestTemplate_,\n \t\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n", "prefixes": [ "libcamera-devel" ] }