Patch Detail
Show a patch.
GET /api/1.1/patches/18754/?format=api
{ "id": 18754, "url": "https://patchwork.libcamera.org/api/1.1/patches/18754/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18754/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230620142904.72600-5-jacopo.mondi@ideasonboard.com>", "date": "2023-06-20T14:29:04", "name": "[libcamera-devel,RFC,4/4] apps: cam: Add option to set stream orientation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0b597e7c4f8a9c47d1dd72646cafdce8ba72bd29", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18754/mbox/", "series": [ { "id": 3932, "url": "https://patchwork.libcamera.org/api/1.1/series/3932/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3932", "date": "2023-06-20T14:29:00", "name": "libcamera: Replace CameraConfiguration::transform", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3932/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18754/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18754/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EB0EC32AA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Jun 2023 14:29:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39F27628C3;\n\tTue, 20 Jun 2023 16:29:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00401628C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jun 2023 16:29:19 +0200 (CEST)", "from uno.lan (unknown [IPv6:2001:b07:5d2e:52c9:72c3:346:a663:c82d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 004B810FE;\n\tTue, 20 Jun 2023 16:28:44 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1687271364;\n\tbh=oYhF7hyz9pKMIn/KeZkRwGYNadMjT4MXJrnrXqTEcBU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SGfXIaACgHPKYXJxdg+v1zC3NPPI3DvBQHN6CAlkSN49SPQx65hyBLUXiWzG5ioWL\n\tT2IlT002yYQsVd7e3RY3914tn5gLSsKM/Zw/FG+1dJDNeYCu27UOEjZfK7kBaVVOkQ\n\tOIgxHD3dXsEO+cF1TLe94sAKUqYkbxK3baZBqnxl/ToJi6MnzZbMJqFHJzLOYqln+g\n\tAjmiRmYAmsSlX9vjZHUPK4Gf0NKzxsfJpHsOJYyZxhnB9vAmypl1vRU3RaPFy4h550\n\tDu8kz0U2cfYtENlW7SHTECS8I78mQ9pc7CTmqJvFfibcaEBmtXaTSg8SA8TWMy1BGN\n\tXrQw1n0P2Yoaw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1687271325;\n\tbh=oYhF7hyz9pKMIn/KeZkRwGYNadMjT4MXJrnrXqTEcBU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=viDAeOYQi4So6cuB/f12OXwHeihvDRrapjfuikxDX6167pVpgRZH3t2MzIGGgD4tQ\n\t/cXvtNnGgBLTRi3LC3fDxGlL8emAAsvaL2AMuGCBt3WcmjcqE+MrUpq5D9BtdOzzLS\n\tZwFt55sOVJ5cgqeGt33nR7EyDb1rs1gAAqtYBujc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"viDAeOYQ\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Jun 2023 16:29:04 +0200", "Message-Id": "<20230620142904.72600-5-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20230620142904.72600-1-jacopo.mondi@ideasonboard.com>", "References": "<20230620142904.72600-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC 4/4] apps: cam: Add option to set stream\n\torientation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a '--orientation|-o' option to the cam test application to set\nan orientation to the image stream.\n\nSupported values are the ones obtained by applying flips to the camera\nsensor:\n- rot180: Rotate 180 degrees\n- flip: vertical flip\n- mirror: horizontal flip\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/apps/cam/camera_session.cpp | 17 +++++++++++++++++\n src/apps/cam/main.cpp | 5 +++++\n src/apps/cam/main.h | 1 +\n 3 files changed, 23 insertions(+)\n\n--\n2.40.1", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 8fcec6304d66..2d6a1440cde2 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -65,6 +65,23 @@ CameraSession::CameraSession(CameraManager *cm,\n \t\treturn;\n \t}\n\n+\tif (options_.isSet(OptOrientation)) {\n+\t\tstd::string orient = options_[OptOrientation].toString();\n+\t\tif (orient == \"rot180\") {\n+\t\t\tconfig->orientation =\n+\t\t\t\tlibcamera::CameraConfiguration::rotate180;\n+\t\t} else if (orient == \"mirror\") {\n+\t\t\tconfig->orientation =\n+\t\t\t\tlibcamera::CameraConfiguration::flipRotate0;\n+\t\t} else if (orient == \"flip\") {\n+\t\t\tconfig->orientation =\n+\t\t\t\tlibcamera::CameraConfiguration::flipRotate180;\n+\t\t} else {\n+\t\t\tstd::cerr << \"Invalid orientation \" << orient << std::endl;\n+\t\t\treturn;\n+\t\t}\n+\t}\n+\n \t/* Apply configuration if explicitly requested. */\n \tif (StreamKeyValueParser::updateConfiguration(config.get(),\n \t\t\t\t\t\t options_[OptStream])) {\ndiff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\nindex 5d8a57bc14e5..8698d5eedcf8 100644\n--- a/src/apps/cam/main.cpp\n+++ b/src/apps/cam/main.cpp\n@@ -133,6 +133,11 @@ int CamApp::parseOptions(int argc, char *argv[])\n \t\t\t \"Capture until interrupted by user or until <count> frames captured\",\n \t\t\t \"capture\", ArgumentOptional, \"count\", false,\n \t\t\t OptCamera);\n+\n+\tparser.addOption(OptOrientation, OptionString,\n+\t\t\t \"The camera stream image orientation (rot180, mirror, flip)\",\n+\t\t\t \"orientation\", ArgumentRequired, \"orientation\", false,\n+\t\t\t OptCamera);\n #ifdef HAVE_KMS\n \tparser.addOption(OptDisplay, OptionString,\n \t\t\t \"Display viewfinder through DRM/KMS on specified connector\",\ndiff --git a/src/apps/cam/main.h b/src/apps/cam/main.h\nindex 526aecece3f3..4aa959b32e13 100644\n--- a/src/apps/cam/main.h\n+++ b/src/apps/cam/main.h\n@@ -17,6 +17,7 @@ enum {\n \tOptList = 'l',\n \tOptListProperties = 'p',\n \tOptMonitor = 'm',\n+\tOptOrientation = 'o',\n \tOptSDL = 'S',\n \tOptStream = 's',\n \tOptListControls = 256,\n", "prefixes": [ "libcamera-devel", "RFC", "4/4" ] }