Patch Detail
Show a patch.
GET /api/1.1/patches/18694/?format=api
{ "id": 18694, "url": "https://patchwork.libcamera.org/api/1.1/patches/18694/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18694/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230603075615.20663-10-tomi.valkeinen@ideasonboard.com>", "date": "2023-06-03T07:56:11", "name": "[libcamera-devel,v5,09/13] py: Drop get_ready_requests()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "78491e8a3294b82a6e3a83e7c87f28a6bfef542e", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18694/mbox/", "series": [ { "id": 3904, "url": "https://patchwork.libcamera.org/api/1.1/series/3904/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3904", "date": "2023-06-03T07:56:02", "name": "py: New python bindings event handling", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3904/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18694/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18694/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D21C1C32AD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 3 Jun 2023 07:57:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84A4962885;\n\tSat, 3 Jun 2023 09:57:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 602DF6287E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 3 Jun 2023 09:57:14 +0200 (CEST)", "from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC363B2A;\n\tSat, 3 Jun 2023 09:56:50 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685779040;\n\tbh=wYbL/tGfOiTWpYkSunmxUHnRx/GsiUaGPhOYCs/HAqE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Y4z2bgn3J/u76w0LvAd88INAFPP4GhGjqO6ceVv9wB7MknzREwtXkh7JhoIt4HCvp\n\thHnsd4TEYfJGVXEc53BgEUyKdVuUed299F3tKcWm0FbcM9iBu740oY1E/q29i040cI\n\tLraewgasQMoxtSl3cB0V4u387vXCbEkfE3IN/EPCEF67edpcsCXOBNdovbb4V6Tmzp\n\t9YH4g08lfsu/T3M/JvpNHqBRL/3OWbqG62RaCU+Q5LFV6xtvbUazZFX/w3oTdrSugp\n\ttqRJJsJc7tPwBZZjhDi/iSaf2q3lb/gPJFIkeLNPDi3vUNmJ3lZWTzdG9xcU3PjY5i\n\tsT6xhVC7EVSrA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685779011;\n\tbh=wYbL/tGfOiTWpYkSunmxUHnRx/GsiUaGPhOYCs/HAqE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cGuuQZ8+oNmgguFklf07FH8VUC+tBN9bM4+lQFscy4VttjWy7CaKB99Ht78f5s43v\n\tdPdJ5HMvWFABsJ3WOHXwp/1h+tX7qvznFETFpGMmSqv0GC4ZfUFsbRZAu4RSswnsBt\n\tpFr+OOciFwKwXLDk3MBg2Z40iVZrMhzu/AK82ZZU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cGuuQZ8+\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 3 Jun 2023 10:56:11 +0300", "Message-Id": "<20230603075615.20663-10-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>", "References": "<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 09/13] py: Drop get_ready_requests()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "get_ready_requests() is deprecated, and the Python code in libcamera has\nbeen converted to the new event system, so we can drop\nget_ready_requests().\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/libcamera/py_camera_manager.cpp | 24 ------------------------\n src/py/libcamera/py_camera_manager.h | 1 -\n src/py/libcamera/py_main.cpp | 3 ---\n 3 files changed, 28 deletions(-)", "diff": "diff --git a/src/py/libcamera/py_camera_manager.cpp b/src/py/libcamera/py_camera_manager.cpp\nindex 83c2b063..4f3a59a3 100644\n--- a/src/py/libcamera/py_camera_manager.cpp\n+++ b/src/py/libcamera/py_camera_manager.cpp\n@@ -110,30 +110,6 @@ PyCameraEvent PyCameraManager::convertEvent(const CameraEvent &event)\n \treturn pyevent;\n }\n \n-/* DEPRECATED */\n-std::vector<py::object> PyCameraManager::getReadyRequests()\n-{\n-\tint ret = readFd();\n-\n-\tif (ret == -EAGAIN)\n-\t\treturn std::vector<py::object>();\n-\n-\tif (ret != 0)\n-\t\tthrow std::system_error(-ret, std::generic_category());\n-\n-\tstd::vector<py::object> py_reqs;\n-\n-\tfor (const auto &ev : getEvents()) {\n-\t\tif (ev.type_ != CameraEventType::RequestCompleted)\n-\t\t\tcontinue;\n-\n-\t\tPyCameraEvent pyev = convertEvent(ev);\n-\t\tpy_reqs.push_back(pyev.request_);\n-\t}\n-\n-\treturn py_reqs;\n-}\n-\n std::vector<PyCameraEvent> PyCameraManager::getPyEvents()\n {\n \tint ret = readFd();\ndiff --git a/src/py/libcamera/py_camera_manager.h b/src/py/libcamera/py_camera_manager.h\nindex 31747547..46121a78 100644\n--- a/src/py/libcamera/py_camera_manager.h\n+++ b/src/py/libcamera/py_camera_manager.h\n@@ -70,7 +70,6 @@ public:\n \n \tint eventFd() const { return eventFd_.get(); }\n \n-\tstd::vector<pybind11::object> getReadyRequests(); /* DEPRECATED */\n \tstd::vector<PyCameraEvent> getPyEvents();\n \tstd::vector<PyCameraEvent> getPyCameraEvents(std::shared_ptr<Camera> camera);\n \ndiff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 981a3070..bc40849a 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -170,9 +170,6 @@ PYBIND11_MODULE(_libcamera, m)\n \n \t\t.def_property_readonly(\"event_fd\", &PyCameraManager::eventFd)\n \n-\t\t/* DEPRECATED */\n-\t\t.def(\"get_ready_requests\", &PyCameraManager::getReadyRequests)\n-\n \t\t.def(\"get_events\", &PyCameraManager::getPyEvents);\n \n \tpyCamera\n", "prefixes": [ "libcamera-devel", "v5", "09/13" ] }