Patch Detail
Show a patch.
GET /api/1.1/patches/18691/?format=api
{ "id": 18691, "url": "https://patchwork.libcamera.org/api/1.1/patches/18691/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18691/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230603075615.20663-7-tomi.valkeinen@ideasonboard.com>", "date": "2023-06-03T07:56:08", "name": "[libcamera-devel,v5,06/13] py: simple-capture.py: Use new events support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "eaa087af069179b7f6c52970c9b64a83772481f0", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18691/mbox/", "series": [ { "id": 3904, "url": "https://patchwork.libcamera.org/api/1.1/series/3904/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3904", "date": "2023-06-03T07:56:02", "name": "py: New python bindings event handling", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3904/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18691/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18691/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D11AEC32AB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 3 Jun 2023 07:57:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DB476288E;\n\tSat, 3 Jun 2023 09:57:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73AB662709\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 3 Jun 2023 09:57:12 +0200 (CEST)", "from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DAB6E468;\n\tSat, 3 Jun 2023 09:56:48 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685779038;\n\tbh=edz4xFWTKtABKI4EC7dWnAxOKJeMyqJxs/BmtaJae4g=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=DlInb5l4hNNOD7j7RzKRNvHSB3c3ZDvOFW9KphUZ5kC6wS3JbHebPRZe+JH0IUDQc\n\tTZMZ3MK/fuh+mNI7OdKDopT/9z9pzvv102Egtetm2tKDqEEnRkfjoWRhayOBZ1KTHN\n\t4KPktxsJKLOvQOvc4B6MEmDaBkx0LfeacDmXVuIgBcVTOJU1GXkAnRFh3g1f0ZlGJ/\n\tqxCagljVlacTupF904fVERzpFhUv/6AYCNgqla9gii04vPfNu4hOygyLru8a7GPYqR\n\tbZj/FTyqfp+hoNFC8KriU6P81SvUHq2MkJ/N9yDYA+uB3W3D14LPNpzSiDepOIMuiN\n\t/MstL5n4xGMpg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685779009;\n\tbh=edz4xFWTKtABKI4EC7dWnAxOKJeMyqJxs/BmtaJae4g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hlKKD5n/2F2WCYX5KuPItkgme2S4CwUNNQ7mpXjOgFWzvgvj7paovpr2UhWqMw9pP\n\tcDwmpMc+EfHltmZzgznuHxPv+J3RM19Qm4NYtxWDHz84f2ZTX4EY6E8nTnPgHkNDQE\n\tJs/JEur4XQh4iSn779CBhyOADUiEFC+PAANt/GCc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hlKKD5n/\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 3 Jun 2023 10:56:08 +0300", "Message-Id": "<20230603075615.20663-7-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>", "References": "<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 06/13] py: simple-capture.py: Use new\n\tevents support", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update simple-capture.py to the new event model.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/examples/simple-capture.py | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/py/examples/simple-capture.py b/src/py/examples/simple-capture.py\nindex 4b85408f..4fa36d6f 100755\n--- a/src/py/examples/simple-capture.py\n+++ b/src/py/examples/simple-capture.py\n@@ -107,17 +107,22 @@ def main():\n sel.register(cm.event_fd, selectors.EVENT_READ)\n \n while frames_done < TOTAL_FRAMES:\n- # cm.get_ready_requests() does not block, so we use a Selector to wait\n- # for a camera event. Here we should almost always get a single\n- # Request, but in some cases there could be multiple or none.\n+ # cm.get_events() does not block, so we use a Selector to wait for a\n+ # camera event. Here we should almost always get a single request\n+ # completion event, but in some cases there could be multiple ones,\n+ # other events, or no events at all.\n \n events = sel.select()\n if not events:\n continue\n \n- reqs = cm.get_ready_requests()\n+ for ev in cm.get_events():\n+ # We are only interested in RequestCompleted events\n+ if ev.type != libcam.Event.Type.RequestCompleted:\n+ continue\n+\n+ req = ev.request\n \n- for req in reqs:\n frames_done += 1\n \n buffers = req.buffers\n", "prefixes": [ "libcamera-devel", "v5", "06/13" ] }