Patch Detail
Show a patch.
GET /api/1.1/patches/1869/?format=api
{ "id": 1869, "url": "https://patchwork.libcamera.org/api/1.1/patches/1869/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1869/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190828011710.32128-5-niklas.soderlund@ragnatech.se>", "date": "2019-08-28T01:17:01", "name": "[libcamera-devel,04/13] libcamera: pipeline: Add initialization hook for CameraData", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "734732c01b095425cf427f92f60c684ab71978a3", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1869/mbox/", "series": [ { "id": 470, "url": "https://patchwork.libcamera.org/api/1.1/series/470/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=470", "date": "2019-08-28T01:16:57", "name": "libcamera: ipa: Add basic IPA support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/470/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1869/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1869/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44D5D60C42\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Aug 2019 03:17:41 +0200 (CEST)", "from bismarck.berto.se (unknown [95.195.154.80])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 979ada08-c931-11e9-bdc3-005056917a89;\n\tWed, 28 Aug 2019 03:17:25 +0200 (CEST)" ], "X-Halon-ID": "979ada08-c931-11e9-bdc3-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 28 Aug 2019 03:17:01 +0200", "Message-Id": "<20190828011710.32128-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.22.1", "In-Reply-To": "<20190828011710.32128-1-niklas.soderlund@ragnatech.se>", "References": "<20190828011710.32128-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 04/13] libcamera: pipeline: Add\n\tinitialization hook for CameraData", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 28 Aug 2019 01:17:41 -0000" }, "content": "Add a hook so CameraData can be initialized before a camera is exposed\nto an application but after all resources and possibly an IPA have been\nfound.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/include/pipeline_handler.h | 2 ++\n src/libcamera/pipeline_handler.cpp | 12 ++++++++++++\n 2 files changed, 14 insertions(+)", "diff": "diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex 91d40ef40a465c4e..45f9457879c64363 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -43,6 +43,8 @@ public:\n \t}\n \tvirtual ~CameraData() {}\n \n+\tvirtual int initCameraData() { return 0; };\n+\n \tCamera *camera_;\n \tPipelineHandler *pipe_;\n \tstd::list<Request *> queuedRequests_;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 766fd496306ece9c..6b3ee0ed8f39676a 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -66,6 +66,12 @@ LOG_DEFINE_CATEGORY(Pipeline)\n * is needed for the camera both parameters should be set to 0.\n */\n \n+/**\n+ * \\fn CameraData::initCameraData()\n+ * \\brief Hook to initialize the camera data\n+ * \\return 0 on success or a negative error code otherwise\n+ */\n+\n /**\n * \\var CameraData::camera_\n * \\brief The camera related to this CameraData instance\n@@ -462,6 +468,12 @@ void PipelineHandler::registerCamera(std::shared_ptr<Camera> camera,\n \t}\n \n \tdata->camera_ = camera.get();\n+\tif (data->initCameraData()) {\n+\t\tLOG(Pipeline, Warning) << \"Skipping \" << camera->name()\n+\t\t\t\t << \" initialization camera data failed\";\n+\t\treturn;\n+\t}\n+\n \tcameraData_[camera.get()] = std::move(data);\n \tcameras_.push_back(camera);\n \tmanager_->addCamera(std::move(camera));\n", "prefixes": [ "libcamera-devel", "04/13" ] }