Patch Detail
Show a patch.
GET /api/1.1/patches/18684/?format=api
{ "id": 18684, "url": "https://patchwork.libcamera.org/api/1.1/patches/18684/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18684/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230602133805.198862-1-web@cedricnugteren.nl>", "date": "2023-06-02T13:38:05", "name": "[libcamera-devel] Apply review suggestions", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "e18633f97692c8adba76b059048fd5bec49a51ad", "submitter": { "id": 164, "url": "https://patchwork.libcamera.org/api/1.1/people/164/?format=api", "name": "Cedric Nugteren", "email": "cedric@plumerai.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18684/mbox/", "series": [ { "id": 3903, "url": "https://patchwork.libcamera.org/api/1.1/series/3903/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3903", "date": "2023-06-02T13:38:05", "name": "[libcamera-devel] Apply review suggestions", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3903/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18684/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18684/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8344C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Jun 2023 13:39:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22D5A62754;\n\tFri, 2 Jun 2023 15:39:06 +0200 (CEST)", "from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n\t[IPv6:2a00:1450:4864:20::62f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16352626FA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Jun 2023 15:39:05 +0200 (CEST)", "by mail-ej1-x62f.google.com with SMTP id\n\ta640c23a62f3a-96fab30d1e1so448436466b.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 02 Jun 2023 06:39:05 -0700 (PDT)", "from kaylee.. (92-68-83-157.biz.kpn.net. [92.68.83.157])\n\tby smtp.gmail.com with ESMTPSA id\n\tg6-20020a1709064e4600b00965b416585bsm770659ejw.118.2023.06.02.06.39.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Jun 2023 06:39:03 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685713146;\n\tbh=dTwCRrfI4pdz7WS8GFOmR9Lkq0KoO6CezyNpGFZU5FU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=K/jn2fY6Hs+IBAl/qXqUb+AxqKE21tN1NCdybDQwbtCFwJ8iwZRfN+NfcuIx9m2zo\n\t96S4MyVmyibjK9NjBcQsTJIcyWEGo/G4asLirTf1XaTKCH3n+Fm0m3WZ64qJwGCG/6\n\tX0tTyj9ei27u1BHUKGnUknLk165zygMOTrBpiVkowysRrd6o8ffC0BfDV+8NooXXfI\n\tu9U1ge4P1U7VA6Qg1fADo8wjnd7T6KrZ4sf3pUGs7t2PEzD/Bl/iGsQNznXnQAxfXC\n\toxDuRFiY7cYDybCsr/UXLWlBPVIlsTtsdIHlzrx5zI/M4dqsTH7mfTIQMJgqux2dtm\n\tGcdfz80GbpuBQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=plumerai.com; s=google; t=1685713144; x=1688305144;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=G16UFzawe7BPKlrKgrQzkBeMrZMxB0NE2650bPuJr7Q=;\n\tb=KvW/nnAgvF632AspR5GnP9/EuZeZ3Y32Y32LT4GLRZjJ+VL7Tf3O5z0R6+Y9puipoQ\n\t0AW89RhhijhyM55KihMx45EMGcDBhQJ7XOJlrVDrlJx7rXBZhW6lmlgDnGOXu2GfNm3j\n\ts2Quqxzfw9Usqcti8j/v7WpyQyfFEY+mFjMkY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=plumerai.com\n\theader.i=@plumerai.com header.b=\"KvW/nnAg\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1685713144; x=1688305144;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=G16UFzawe7BPKlrKgrQzkBeMrZMxB0NE2650bPuJr7Q=;\n\tb=IDNQOzONmT7sXuYzbVpw5j1Hzr/cf12W6NtXXnTS5xHz/ATrpGqIjiVkJtyR3XW5lb\n\tftdbJGUYYICaJJnLcrURADNVWnZq2camdKhOjAve6eEQ8S2RUXIMzMqggfh6GsrEv7hI\n\tlwwYDOUmhOqb21XiSB7gCb4HPxJJFjIWuhlZA0dFVOXWACt51ZTflcyYWrxTLwxMwmNW\n\tGeyVEE5R87larALAtbDP5X8pzoICdrkv7VzoBLhEzgxMZXw+SVb8ik2PX6RYRNO0+I6i\n\teAu9eHAIBSMxBJjoWLyMHlwW6s1QO1HzSfmdRrsN5Cy6CzokfoISJInlMGXUybNJUO5H\n\tQNug==", "X-Gm-Message-State": "AC+VfDz+68HXoGP+dhHrZDib8VReGvgkQ+RKwKY8IF4aTMWZjUZ3+S45\n\tzelsF62bwC2Bi+3S3nP5c2xfKvT++XrOKofATvU=", "X-Google-Smtp-Source": "ACHHUZ69lG6DK0aw58YIPIZQ2AHU4f5ZW2uiH4dTm97kDVHfrJHHgJinz8WjaJTshKHKOSheiXnTTg==", "X-Received": "by 2002:a17:906:7311:b0:96a:316f:8aaa with SMTP id\n\tdi17-20020a170906731100b0096a316f8aaamr4457156ejc.37.1685713144422; \n\tFri, 02 Jun 2023 06:39:04 -0700 (PDT)", "X-Google-Original-From": "Cedric Nugteren <web@cedricnugteren.nl>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Jun 2023 15:38:05 +0200", "Message-Id": "<20230602133805.198862-1-web@cedricnugteren.nl>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<037947>", "References": "<037947>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] Apply review suggestions", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Cedric Nugteren via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Cedric Nugteren <cedric@plumerai.com>", "Cc": "Cedric Nugteren <web@cedricnugteren.nl>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This addresses the comments from Nicolas. I did not change the default behaviour,\nI'll wait with that until you have settled on what to do.\n\nSigned-off-by: Cedric Nugteren <web@cedricnugteren.nl>\n---\n src/gstreamer/gstlibcameraprovider.cpp | 15 +++++++--------\n src/gstreamer/gstlibcamerasrc.cpp | 14 +++++++-------\n 2 files changed, 14 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex 86fa2542..579cb8c0 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -41,7 +41,7 @@ G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device,\n struct _GstLibcameraDevice {\n \tGstDevice parent;\n \tgchar *name;\n-\tgboolean enable_auto_focus = false;\n+\tbool enable_auto_focus = false;\n };\n \n G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE)\n@@ -71,7 +71,6 @@ gst_libcamera_device_reconfigure_element(GstDevice *device,\n \t\treturn FALSE;\n \n \tg_object_set(element, \"camera-name\", GST_LIBCAMERA_DEVICE(device)->name, nullptr);\n-\tg_object_set(element, \"enable-auto-focus\", GST_LIBCAMERA_DEVICE(device)->enable_auto_focus, nullptr);\n \n \treturn TRUE;\n }\n@@ -128,12 +127,12 @@ gst_libcamera_device_class_init(GstLibcameraDeviceClass *klass)\n \t\t\t\t\t\t(GParamFlags)(G_PARAM_STATIC_STRINGS | G_PARAM_WRITABLE |\n \t\t\t\t\t\t\t G_PARAM_CONSTRUCT_ONLY));\n \tg_object_class_install_property(object_class, PROP_DEVICE_NAME, pspec);\n-\tGParamSpec *spec2 = g_param_spec_boolean(\"enable-auto-focus\",\n-\t \"Enable auto-focus\",\n-\t \"Enable auto-focus if set to true, \"\n-\t \"disable it if set to false\",\n-\t FALSE, G_PARAM_WRITABLE);\n-\tg_object_class_install_property(object_class, PROP_ENABLE_AUTO_FOCUS, spec2);\n+\tpspec = g_param_spec_boolean(\"enable-auto-focus\",\n+\t \"Enable auto-focus\",\n+\t \"Enable auto-focus if set to true, \"\n+\t \"disable it if set to false\",\n+\t FALSE, G_PARAM_WRITABLE);\n+\tg_object_class_install_property(object_class, PROP_ENABLE_AUTO_FOCUS, pspec);\n }\n \n static GstDevice *\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 672ea38a..b2d8456b 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -146,7 +146,7 @@ struct _GstLibcameraSrc {\n \tGstTask *task;\n \n \tgchar *camera_name;\n-\tgboolean enable_auto_focus = false;\n+\tbool enable_auto_focus = false;\n \n \tGstLibcameraSrcState *state;\n \tGstLibcameraAllocator *allocator;\n@@ -864,11 +864,11 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n \t\t\t\t\t\t\t | G_PARAM_READWRITE\n \t\t\t\t\t\t\t | G_PARAM_STATIC_STRINGS));\n \tg_object_class_install_property(object_class, PROP_CAMERA_NAME, spec);\n-\tGParamSpec *spec2 = g_param_spec_boolean(\"enable-auto-focus\",\n-\t \"Enable auto-focus\",\n-\t \"Enable auto-focus if set to true, \"\n-\t \"disable it if set to false\",\n-\t FALSE, G_PARAM_WRITABLE);\n-\tg_object_class_install_property(object_class, PROP_ENABLE_AUTO_FOCUS, spec2);\n+\tspec = g_param_spec_boolean(\"enable-auto-focus\",\n+\t \"Enable auto-focus\",\n+\t \"Enable auto-focus if set to true, \"\n+\t \"disable it if set to false\",\n+\t FALSE, G_PARAM_WRITABLE);\n+\tg_object_class_install_property(object_class, PROP_ENABLE_AUTO_FOCUS, spec);\n \n }\n", "prefixes": [ "libcamera-devel" ] }