Patch Detail
Show a patch.
GET /api/1.1/patches/18653/?format=api
{ "id": 18653, "url": "https://patchwork.libcamera.org/api/1.1/patches/18653/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18653/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230529123926.74775-1-jacopo.mondi@ideasonboard.com>", "date": "2023-05-29T12:39:25", "name": "[libcamera-devel,1/2] ipa: ipu3: agc: Drop hard-codec analogue gain max", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "adf19eca2c35aa7326e271a9f9c5b9803ff7cd9e", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18653/mbox/", "series": [ { "id": 3891, "url": "https://patchwork.libcamera.org/api/1.1/series/3891/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3891", "date": "2023-05-29T12:39:25", "name": "[libcamera-devel,1/2] ipa: ipu3: agc: Drop hard-codec analogue gain max", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3891/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18653/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18653/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61ECCC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 May 2023 12:39:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE5CC626FD;\n\tMon, 29 May 2023 14:39:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A703C626F5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 May 2023 14:39:43 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C1416D5;\n\tMon, 29 May 2023 14:39:23 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685363984;\n\tbh=mzdHXjpzGJdchKXzi2JrbWrhahYKxDdtjGIrBvYN2u0=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=f4M3+J+lsOPZrhNZfahLYIU13f7eyqJW7iQDPho5mJMdYOX4dOTwEJ7XQQGK2zRH9\n\tvJQreNcVvb6IeqqXm68b4YzpdRDVLZOFVFxkZGE0dfYo69Ycu/UeUKK4JE5S1lW30i\n\tnMPhZKAXNUa3M6aK7WSY9aVfzLcSJB+O5aEmXQG0mdgE0ZdGNFvMpRSJNh3Oi/+01c\n\ta2GJ80OwsogiuYmitxX+yy37+TydSlEjkYXz+fsbLgs53vmXFVDQETsCDVePBFlThx\n\tw9amRAt4rtj3durmKilYdp/Qvtk5AYgNbaM/qbYXeQWBBIgOKaJcCdCUNZbCovKwyz\n\tTE8IxuKz/baYw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685363963;\n\tbh=mzdHXjpzGJdchKXzi2JrbWrhahYKxDdtjGIrBvYN2u0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=KRYmgEr9i18exkvMjlTGHAlYbLccRSNK61rMBX/7T4Y2PHRyELReFrkrcN/d2NJYH\n\tuP1xzSH+uRKo63omPxImHAUf5pGdx8j+WPc2mQ3i0n1MYB/iQGs4cG9PXD9/BdDcIU\n\tc1b+sKJ4EPXFm2XZbkbWekoRSihYD3R9RQzJXbHM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KRYmgEr9\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 May 2023 14:39:25 +0200", "Message-Id": "<20230529123926.74775-1-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] ipa: ipu3: agc: Drop hard-codec\n\tanalogue gain max", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As the sensor's analogue gain range is known, drop the arbitrary\nmaximum limit for the sensor analogue gain.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex b5309bdbea25..606a237a4a59 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -47,9 +47,8 @@ namespace ipa::ipu3::algorithms {\n \n LOG_DEFINE_CATEGORY(IPU3Agc)\n \n-/* Limits for analogue gain values */\n+/* Minimum limit for analogue gain value */\n static constexpr double kMinAnalogueGain = 1.0;\n-static constexpr double kMaxAnalogueGain = 8.0;\n \n /* \\todo Honour the FrameDurationLimits control instead of hardcoding a limit */\n static constexpr utils::Duration kMaxShutterSpeed = 60ms;\n@@ -97,10 +96,10 @@ int Agc::configure(IPAContext &context,\n \t\t\t\t kMaxShutterSpeed);\n \n \tminAnalogueGain_ = std::max(configuration.agc.minAnalogueGain, kMinAnalogueGain);\n-\tmaxAnalogueGain_ = std::min(configuration.agc.maxAnalogueGain, kMaxAnalogueGain);\n+\tmaxAnalogueGain_ = configuration.agc.maxAnalogueGain;\n \n \t/* Configure the default exposure and gain. */\n-\tactiveState.agc.gain = std::max(minAnalogueGain_, kMinAnalogueGain);\n+\tactiveState.agc.gain = minAnalogueGain_;\n \tactiveState.agc.exposure = 10ms / configuration.sensor.lineDuration;\n \n \tframeCount_ = 0;\n", "prefixes": [ "libcamera-devel", "1/2" ] }