Patch Detail
Show a patch.
GET /api/1.1/patches/18630/?format=api
{ "id": 18630, "url": "https://patchwork.libcamera.org/api/1.1/patches/18630/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18630/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230515124550.3601128-2-kieran.bingham@ideasonboard.com>", "date": "2023-05-15T12:45:46", "name": "[libcamera-devel,v3,1/5] libcamera: internal: request: convert to pragma once", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1b789fb14afa9163ead3d605445ebbaf453336be", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18630/mbox/", "series": [ { "id": 3878, "url": "https://patchwork.libcamera.org/api/1.1/series/3878/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3878", "date": "2023-05-15T12:45:45", "name": "libcamera: Add new Camera devices property", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3878/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18630/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18630/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 429B4BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 15 May 2023 12:45:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 712C66286D;\n\tMon, 15 May 2023 14:45:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDE4F60493\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 May 2023 14:45:53 +0200 (CEST)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2256D7E1;\n\tMon, 15 May 2023 14:45:43 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1684154755;\n\tbh=aaZMqUPcooHCbX/fwLlmEMqE0g1nrz40v8z9hWQhgWE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=HRh0x1FC5ALEZH1zJ4x7RWrEe/QWLmjnwE6cDYBi+LZdv5MSg0xi9F5esIdQeKKXd\n\tC+FgexVoY5wSvi3WEBfmBx3wjzVLR+f3f9QeMTOSifAhtB3iQNAggm9ecpPE8y6++g\n\tqYsMnCu7Vwj9WKyXMM0skKm7dOis8ywVwgbSYTWw6x4sdbKCJfjToPZ5uHC1zuljAp\n\tcq8Elbj3+4ks7ifkQy1NWEOqG4VGJxOLtlAw4qd6bdS0U/Rx3Bw5+jR1NA5sglrw8b\n\t8X6KpkTCJi1+zSP8dfhIRKIu6JOkMksmtQR5/vaogShh7u7BDXvuskcBYiGEr4vy04\n\tfaoRbYsSofGmQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1684154743;\n\tbh=aaZMqUPcooHCbX/fwLlmEMqE0g1nrz40v8z9hWQhgWE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AVmXYFMIsp11qhVQniD/L6WzYPcqfm+Rr9nXVbi3oT4V+xOcdh7UiLIJzicK0qevq\n\tAmZ6QPTHQioh+3dDt5uIcVMg0l3SR4N/ZnnLCkbIRR5whShz5hAmsznu+Zrl5BNPh/\n\tD/0Pq7QyyxfPncXD+SXRzUW7rCJ6KKfpoNNPBnco=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AVmXYFMI\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 15 May 2023 13:45:46 +0100", "Message-Id": "<20230515124550.3601128-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>", "References": "<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/5] libcamera: internal: request:\n\tconvert to pragma once", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the verbose #ifndef/#define/#endif pattern for maintaining\nheader idempotency, and replace it with a simple #pragma once.\n\nThis simplifies the headers, and prevents redundant changes when\nheader files get moved.\n\nThe internal/request.h was missed at the time of the original\nconversion. Update it.\n\nFixes: df131ad08893 (\"libcamera: internal: Convert to pragma once\")\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/request.h | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex 8c92a27a95e5..3454cf5a72f5 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -4,8 +4,8 @@\n *\n * request.h - Request class private data\n */\n-#ifndef __LIBCAMERA_INTERNAL_REQUEST_H__\n-#define __LIBCAMERA_INTERNAL_REQUEST_H__\n+\n+#pragma once\n \n #include <chrono>\n #include <map>\n@@ -62,5 +62,3 @@ private:\n };\n \n } /* namespace libcamera */\n-\n-#endif /* __LIBCAMERA_INTERNAL_REQUEST_H__ */\n", "prefixes": [ "libcamera-devel", "v3", "1/5" ] }