Patch Detail
Show a patch.
GET /api/1.1/patches/18610/?format=api
{ "id": 18610, "url": "https://patchwork.libcamera.org/api/1.1/patches/18610/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18610/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230508134501.23802-1-jacopo.mondi@ideasonboard.com>", "date": "2023-05-08T13:45:01", "name": "[libcamera-devel] libcamera: ipa_manager: Allow IPA loading in nested subdirs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "309f1fdca787d714dbc46d6cf6467c391e927549", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18610/mbox/", "series": [ { "id": 3870, "url": "https://patchwork.libcamera.org/api/1.1/series/3870/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3870", "date": "2023-05-08T13:45:01", "name": "[libcamera-devel] libcamera: ipa_manager: Allow IPA loading in nested subdirs", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3870/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18610/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18610/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC0DDBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 May 2023 13:45:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6DB4A60544;\n\tMon, 8 May 2023 15:45:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 375916053A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 May 2023 15:45:24 +0200 (CEST)", "from uno.lan (unknown\n\t[IPv6:2001:b07:5d2e:52c9:1cf0:b3bc:c785:4625])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C245B7CE;\n\tMon, 8 May 2023 15:45:17 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683553525;\n\tbh=6xRNNKp9z9hKZnxIu+qxiDmisGJG1cpiumAt8Z49ObE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=KLneA7eUINXHK8Q0EuweGYphcyYcRsNpbZNwkWwLHDB3elodFElGZz1F/M0GRORO1\n\twFG6IpO+3vO5NxgMKr8gvIAW4OgS/kBcmNmOvFjZD2FCF1tqgAf+/bUR158XtR+61p\n\tN2q2baLD1RUHMr9HMQdGYurMIMx/otwuDzhxMb/Ru87b5R+BgZUnbl6og1BPbPD48l\n\t8bcYY4l4YOU5Zd/SHOM2gTrmmOdR6oPYgPeKxQijWKysR0ylT29iREvj4Z0Lz3Kafq\n\tCArgW9/72r702hDnNA81IomXbWNT6seACPrc46d11QjnDSnHX53RYtXPonJZZpgQ2D\n\tuh6DnBiyTIoPQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683553518;\n\tbh=6xRNNKp9z9hKZnxIu+qxiDmisGJG1cpiumAt8Z49ObE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=v8is7lr7Vs/IYOzyOvyQaUUCatCJOhqJPXqXMhI13TJmjoYtqOidxun4yS1zYgyAc\n\tpKp8i1UXcP8APvbPc+0fUr77wkB4cXitvyq+nyNfbf3HKaA/0qXPX+tOsaTjrwSzzf\n\ts/uslJvOMeXwm4tB7/hCnnqrjAnB6rdVQcOSBIYA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"v8is7lr7\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 8 May 2023 15:45:01 +0200", "Message-Id": "<20230508134501.23802-1-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: ipa_manager: Allow IPA loading\n\tin nested subdirs", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that we allow IPA modules to live in nested directories for the\nRaspberryPi platform, it is required to allow parsing one more level\nto be able to run libcamera from the source directory.\n\nWithout this patch the $(builddir)/src/ipa/rpi/vc4/ipa_rpi_vc4.so\nIPA module cannot be loaded.\n\nThe issue is only present when running from the source directory\nas when libcamera is installed all IPA modules are deployed to a single\n$(prefix)/$(libcamera_libdir)/libamera/ location.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/ipa_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.40.1", "diff": "diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex 030ef43fb994..ac5397003b50 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -138,7 +138,7 @@ IPAManager::IPAManager()\n \tstd::string root = utils::libcameraBuildPath();\n \tif (!root.empty()) {\n \t\tstd::string ipaBuildPath = root + \"src/ipa\";\n-\t\tconstexpr int maxDepth = 1;\n+\t\tconstexpr int maxDepth = 2;\n\n \t\tLOG(IPAManager, Info)\n \t\t\t<< \"libcamera is not installed. Adding '\"\n", "prefixes": [ "libcamera-devel" ] }