Patch Detail
Show a patch.
GET /api/1.1/patches/18603/?format=api
{ "id": 18603, "url": "https://patchwork.libcamera.org/api/1.1/patches/18603/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18603/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230504144801.2590668-3-kieran.bingham@ideasonboard.com>", "date": "2023-05-04T14:48:01", "name": "[libcamera-devel,v2,2/2] v4l2: Move the v4l2 compat layer to libexec/libcamera", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "75dd2004eb8ac3a8b4a199f7be061401d472ee7d", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18603/mbox/", "series": [ { "id": 3865, "url": "https://patchwork.libcamera.org/api/1.1/series/3865/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3865", "date": "2023-05-04T14:47:59", "name": "V4L2 Compatibility installation directory", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3865/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18603/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18603/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6621C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 May 2023 14:48:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16F6E633BB;\n\tThu, 4 May 2023 16:48:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F34161EAE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 May 2023 16:48:07 +0200 (CEST)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BF6DDC9;\n\tThu, 4 May 2023 16:48:04 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683211691;\n\tbh=V9oQ2RNbwux0oSPiNo7eDpDwcjGtG8xComNBhdK2UsQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=3RQU9T4eROWd0oJFu1pJSkntku1fnnTgU2qow1J7Z2x+AKzGYwsVy5riTOxnSDoYx\n\tuwHX55i6GwqFcjer4x3Gejx4TplasxhENBe+vdc7j7I401Vt1nLGw7QAcWF2hQB3EU\n\tE54VZ0AN4lJK8eoXp9bWF42l4T4WuMwrciQ9XaaepujmjkvhyR6sARnRpLX8qn6Lox\n\tzYDJXCbtsG8phcbDhPdGcBj/PoLlrC5TJbyNyt74czNDx4cuUb0imh3drOT2PhhB3d\n\t0oxIU4EcsMKxc2y441vt7rKIK13/MFcvhwJuxBGm14IoSkVj+McfgYkUDM2IqyPnvR\n\tMD0VhFuf34Afw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683211684;\n\tbh=V9oQ2RNbwux0oSPiNo7eDpDwcjGtG8xComNBhdK2UsQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MuDy1P4q+Hd26AF7yNED3UUTo1ecLB2X1p/fMerOw4mNxP3G3nXg+koExYOdDxxbL\n\t/ylRJ2eK8VlJHLHogtveZOqFc587sW9pQQGU8QKFgvFkeQU7KE5h4YVRwdHD6Xla32\n\tGnxHBoTuBF5wwSzO21HY7Y/NlNfW4v/PkE3asaNU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MuDy1P4q\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 4 May 2023 15:48:01 +0100", "Message-Id": "<20230504144801.2590668-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230504144801.2590668-1-kieran.bingham@ideasonboard.com>", "References": "<20230504144801.2590668-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/2] v4l2: Move the v4l2 compat layer\n\tto libexec/libcamera", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the v4l2-compat.so shared library installation to the libcamera\ndirectory under libexec. This is the same location that the proxy\nworkers live and will facilitate easier packaging of the V4L2\ncompatibiltiy layer with distributions.\n\nCreate a new libcamera_libexecdir variable within meson to simplify\nrepresentation of this path and update the proxy worker meson.build\ninfrastructure to make use of it as well.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/proxy/worker/meson.build | 2 +-\n src/meson.build | 1 +\n src/v4l2/meson.build | 3 ++-\n 3 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/proxy/worker/meson.build b/src/libcamera/proxy/worker/meson.build\nindex 70c8760a3d42..aa4d9cd7b5d8 100644\n--- a/src/libcamera/proxy/worker/meson.build\n+++ b/src/libcamera/proxy/worker/meson.build\n@@ -1,6 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n-proxy_install_dir = get_option('libexecdir') / 'libcamera'\n+proxy_install_dir = libcamera_libexecdir\n \n # generate {pipeline}_ipa_proxy_worker.cpp\n foreach mojom : ipa_mojoms\ndiff --git a/src/meson.build b/src/meson.build\nindex a3821fb90a0f..165a77bb9d53 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -3,6 +3,7 @@\n # Cache system paths\n libcamera_datadir = get_option('datadir') / 'libcamera'\n libcamera_libdir = get_option('libdir') / 'libcamera'\n+libcamera_libexecdir = get_option('libexecdir') / 'libcamera'\n libcamera_sysconfdir = get_option('sysconfdir') / 'libcamera'\n \n config_h.set('LIBCAMERA_DATA_DIR', '\"' + get_option('prefix') / libcamera_datadir + '\"')\ndiff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\nindex f132103cb503..ab4b35dd0e6b 100644\n--- a/src/v4l2/meson.build\n+++ b/src/v4l2/meson.build\n@@ -31,6 +31,7 @@ v4l2_compat = shared_library('v4l2-compat',\n v4l2_compat_sources,\n name_prefix : '',\n install : true,\n+ install_dir : libcamera_libexecdir,\n dependencies : [libcamera_private, libdl],\n cpp_args : v4l2_compat_cpp_args)\n \n@@ -38,7 +39,7 @@ v4l2_compat = shared_library('v4l2-compat',\n # adaptation layer.\n \n cdata = configuration_data()\n-cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / get_option('libdir') / 'v4l2-compat.so')\n+cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / libcamera_libexecdir / 'v4l2-compat.so')\n \n configure_file(input : 'libcamerify.in',\n output : 'libcamerify',\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }