Patch Detail
Show a patch.
GET /api/1.1/patches/18589/?format=api
{ "id": 18589, "url": "https://patchwork.libcamera.org/api/1.1/patches/18589/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18589/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230503122035.32026-5-naush@raspberrypi.com>", "date": "2023-05-03T12:20:26", "name": "[libcamera-devel,04/13] pipeline: meson: Allow nested pipeline handler directory structures", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4e242b379c8ce6a35e5b037c3638daaeaaed09b6", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18589/mbox/", "series": [ { "id": 3863, "url": "https://patchwork.libcamera.org/api/1.1/series/3863/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3863", "date": "2023-05-03T12:20:22", "name": "Raspberry Pi: Code refactoring", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3863/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18589/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18589/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 353A1C327C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 3 May 2023 12:20:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EDF0633C8;\n\tWed, 3 May 2023 14:20:44 +0200 (CEST)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93874633BB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 May 2023 14:20:40 +0200 (CEST)", "by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-3f20215fa70so33548065e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 03 May 2023 05:20:40 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tf23-20020a7bcd17000000b003ee443bf0c7sm1736785wmj.16.2023.05.03.05.20.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 03 May 2023 05:20:39 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683116444;\n\tbh=Nrc2VCaQEYgwL/KrjgCkD/2fXQlzDrF+D5L1CKEfJTs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=mibNVtFjoZ0pUuv9/vEMotnqCQq3bA/jee3WrhqrOg6v+/lqxeiUH9c1p30m7o83V\n\tJ4ni0QpYfs6GPCGCjhKvgPv0ffEwc/Ba0Xe9dDvZubrShWMAm9pZPMHT1wQKX2MUgl\n\tL2B9TnurMV27p+A3cMSfsWZsAWsvWSfC/K5Ou4cbdqSIFPkFecpvIt1zyGJpuoc/wy\n\tnmOtzrWQ/MUUm70P8eMuniRaTU7keCVpGpl6Pu9Q4oH5uYfmhuvTRecwMg214gJ8gt\n\t6j7AMq9MGtin8q7Fe8iaN3qnTGfv5wzSlulHbvo8q4gCIFn4YAx1IQDA9zySiF7vso\n\tWCtIydBeAGX3w==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1683116440; x=1685708440;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=IemsxOVQ9LeJZukTKv2xAB06N6yXJw0JMYPwJ07JdP4=;\n\tb=KGUMKjp2QZnAMjp4y4D78ybL7/VMdip7LnjMTfzKb98J9fKVkLbagT9xQ1oO8jHhOO\n\tzcsBIzBH361nlBUO56Pxc4dCN27f88DMGiEdJj+UnPQQVHaEKBOCFptXQ1ryrdXIg5lX\n\tj3t9R7Z695iP9ue1wXPzFCGVdxx8N+ChQ2U3JB9kvo/MSV4WmS7YrCbzygbmi7ua45LM\n\ttSPO7Jhf16cL60hfK1d2fAT4tZNmJ6UhV8vhzsWcnl2VQWBTQwnkKRwbMZ9EEvBKWHWx\n\tdu4571nZYmXsjb3EMnp5Ro7CcSCLqkzfhkjK0V0xb3l+q3uqaQfl6Sfg0J1/Zzh6fNJA\n\tHJwg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"KGUMKjp2\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1683116440; x=1685708440;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=IemsxOVQ9LeJZukTKv2xAB06N6yXJw0JMYPwJ07JdP4=;\n\tb=F1njNc9OxS1uqn+dtr/jIRLhoFsh47+Acz0OF6TbBnck5r0svuE7U6Pd2Z0jk9phgk\n\tsF6fWZxYCeK0ssYa66fjQ/HYGSfqGAUoJBfq+wv/5Cx73vV1EL2O3qwJ3Exlik3itV6j\n\t/crNRi919sZTdOr62MWLRmDzd18xKVD1ITYTw49dpdsYmfzeYSaKmyaETn+PLsAxkyK5\n\tom+AXiIrSkYto8f9O4dllN8Q9VfZV/J5E9YFATUm90LTZ8EPrxiIlJ1uiHDL+Y7c7ivV\n\tSuaEKK/JklbcZ45yH65DLIAJgNHXk2zGjkbyJGVTwHaVk/eQua0m11lDasf4WRAVc/jM\n\tqBsA==", "X-Gm-Message-State": "AC+VfDz7Q8ao9LxlLefPCV8y6LvTcIGCot4bdP+p6ZZzukkSGBPPGoal\n\tNOnof+7gjqHOwY6DqJPnUkRhEvR1F9V4mfpoDJf7jQ==", "X-Google-Smtp-Source": "ACHHUZ4hVnNE97++h7PCLFqmVAd0eAY2o7jsVbyI8M5O0SiWrM4+a+gXpjDZ499L1dTMSB+lkMVXOg==", "X-Received": "by 2002:a1c:7311:0:b0:3f1:72db:4554 with SMTP id\n\td17-20020a1c7311000000b003f172db4554mr14585532wmb.1.1683116439774; \n\tWed, 03 May 2023 05:20:39 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 3 May 2023 13:20:26 +0100", "Message-Id": "<20230503122035.32026-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230503122035.32026-1-naush@raspberrypi.com>", "References": "<20230503122035.32026-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 04/13] pipeline: meson: Allow nested\n\tpipeline handler directory structures", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The current pipeline handler build files require a flat directory\nstruture for each pipeline handler. Modify the build files to remove\nthis restriction and allow a directory structure such as:\n\nsrc/libcamera/pipeline/\n |- raspberrypi\n |- common\n |- vc4\n |- rkisp1\n |- ipu3\n\nwhere each subdir (e.g. raspberrypi/common, raspberrypi/vc4) has its own\nmeson.build file. Such a directory structure will be introduced for the\nRaspberry Pi pipeline handler in a future commit.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/meson.build | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\nindex f14869f3a3c0..059c68bb964f 100644\n--- a/src/libcamera/pipeline/meson.build\n+++ b/src/libcamera/pipeline/meson.build\n@@ -3,6 +3,15 @@\n # Location of pipeline specific configuration files\n pipeline_data_dir = libcamera_datadir / 'pipeline'\n \n+# Allow multi-level directory structuring for the pipeline handlers if needed.\n+subdirs = []\n+\n foreach pipeline : pipelines\n+ pipeline = pipeline.split('/')[0]\n+ if pipeline in subdirs\n+ continue\n+ endif\n+\n subdir(pipeline)\n+ subdirs += [pipeline]\n endforeach\n", "prefixes": [ "libcamera-devel", "04/13" ] }