Patch Detail
Show a patch.
GET /api/1.1/patches/18583/?format=api
{ "id": 18583, "url": "https://patchwork.libcamera.org/api/1.1/patches/18583/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18583/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230502175842.70629-1-pobrn@protonmail.com>", "date": "2023-05-02T17:58:43", "name": "[libcamera-devel,v1] gstreamer: Simplify camera config generation call", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "921d16f8d911ed8cc16a5ef540a90e1943ad6f03", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18583/mbox/", "series": [ { "id": 3861, "url": "https://patchwork.libcamera.org/api/1.1/series/3861/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3861", "date": "2023-05-02T17:58:43", "name": "[libcamera-devel,v1] gstreamer: Simplify camera config generation call", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3861/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18583/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18583/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBAF2C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 May 2023 17:59:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C874633B4;\n\tTue, 2 May 2023 19:59:00 +0200 (CEST)", "from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A17160538\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 May 2023 19:58:59 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683050340;\n\tbh=emx8ytQaQhm3VZdMFuOPKEDkS5gZQ2TmDHMJBIJYNAk=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=A8gP481PEyZ8pTVd7ICRgoeDtM7s5RdYhLd/68mjcBLs1HbbfzjupRi+DFBdN5Ib4\n\t/WaZoxsqzY81Jt06Uim6Hrbx7PtgW3CrKTGVlpj4sjcr7kbgh/K/Ru5xYR4Rc02SPb\n\tVCzUfhDDNlJ8MZBnpg1NJFfV27XbsISSIBdR51BhcDYB5KV8zPq5v2HkBGm3L6wBg0\n\tXyf5ngRne9XadRAlvmSpRx5/kpY2mFB6DZ5HMxO8LJN9pVNjhWx4b/cISApDHm2VWc\n\tbKv3NXab/BH6Swqo6tWO5INmn0BzH8W3GsJNJE7LmVTUHzw2HYKXN5lLoBJF+nm7Ik\n\tpLwFgUwcgsavg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1683050339; x=1683309539;\n\tbh=emx8ytQaQhm3VZdMFuOPKEDkS5gZQ2TmDHMJBIJYNAk=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=rT4fY2Vs6tMxoVaiKdTa/eNgtAlY1UatJMWz1rc73/0ns7Qyq7aolScRPdqi32kgv\n\tuLobvNphiyfFEGpU8i92HwApLGNWM7+R9X+BGCBjEhcZgi01+dlT/59Mh31HqANnUd\n\tAO164hjfdVY+VEoIu5Kemxo/rrTY0m8R64phAcZg5c0utVt8UuwwdF30RvvAKhXzxP\n\ttk2opXLDxBL9u06ABEXfHV134lcJqW5yQWIaaWRVEhrnskylG6/k1I0mLFuyeze70o\n\tC0V2VS3SWyefulJRemi/2ftJO43sbp1ECtFpXeU6f8r3QW7z4hN24euxISHNOY/xHH\n\tO3REvuK3mQXFw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"rT4fY2Vs\"; dkim-atps=neutral", "Date": "Tue, 02 May 2023 17:58:43 +0000", "To": "libcamera-devel@lists.libcamera.org", "Message-ID": "<20230502175842.70629-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[libcamera-devel] [PATCH v1] gstreamer: Simplify camera config\n\tgeneration call", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of explicitly creating a vector of StreamRole,\nsimply use an initializer list as the argument of\n`Camera::generateConfiguration()`.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/gstreamer/gstlibcameraprovider.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)\n\n--\n2.40.1", "diff": "diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex 6eb0a0eb..4f325ad4 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -128,11 +128,9 @@ gst_libcamera_device_new(const std::shared_ptr<Camera> &camera)\n {\n \tg_autoptr(GstCaps) caps = gst_caps_new_empty();\n \tconst gchar *name = camera->id().c_str();\n-\tStreamRoles roles;\n\n-\troles.push_back(StreamRole::VideoRecording);\n-\tstd::unique_ptr<CameraConfiguration> config = camera->generateConfiguration(roles);\n-\tif (!config || config->size() != roles.size()) {\n+\tstd::unique_ptr<CameraConfiguration> config = camera->generateConfiguration({ StreamRole::VideoRecording });\n+\tif (!config || config->size() != 1) {\n \t\tGST_ERROR(\"Failed to generate a default configuration for %s\", name);\n \t\treturn nullptr;\n \t}\n", "prefixes": [ "libcamera-devel", "v1" ] }