Patch Detail
Show a patch.
GET /api/1.1/patches/18580/?format=api
{ "id": 18580, "url": "https://patchwork.libcamera.org/api/1.1/patches/18580/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18580/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230501234734.43869-1-mail@eliasnaur.com>", "date": "2023-05-01T23:47:34", "name": "[libcamera-devel] libcamera: Add missing O_CLOEXEC flag", "commit_ref": "4c71ec00c2ea5c6acc75e436bf6d24e6861cb66f", "pull_url": null, "state": "accepted", "archived": false, "hash": "7ba14f4d137fb685b307d66b163459e06cd35a8e", "submitter": { "id": 159, "url": "https://patchwork.libcamera.org/api/1.1/people/159/?format=api", "name": "Elias Naur", "email": "mail@eliasnaur.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18580/mbox/", "series": [ { "id": 3858, "url": "https://patchwork.libcamera.org/api/1.1/series/3858/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3858", "date": "2023-05-01T23:47:34", "name": "[libcamera-devel] libcamera: Add missing O_CLOEXEC flag", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3858/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18580/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18580/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BA77BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 1 May 2023 23:47:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA2EE633B4;\n\tTue, 2 May 2023 01:47:55 +0200 (CEST)", "from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com\n\t[IPv6:2607:f8b0:4864:20::a2f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41C67627CD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 May 2023 01:47:53 +0200 (CEST)", "by mail-vk1-xa2f.google.com with SMTP id\n\t71dfb90a1353d-4404c9d9fceso1072804e0c.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 01 May 2023 16:47:53 -0700 (PDT)", "from localhost.localdomain ([190.53.13.8])\n\tby smtp.gmail.com with ESMTPSA id\n\te24-20020ab01698000000b007714fbc9795sm5319161uaf.20.2023.05.01.16.47.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 May 2023 16:47:51 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682984875;\n\tbh=7qTXN4QzxAXIa0bfUy0nF43BLRXGlf6PPNoMvPNmuxo=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=r1P7p2D1Mgv42czK+jYNNU5LAZebI3oX3+XcHNtjs5M7sffViRfQ21Hinvq4g4V8h\n\tyrFsZ1MJfTWtGsFUp7D5QJvsEy+AqLmLS3rEVy+MFULbyW0+9jA6iQVg5PNVBu4NKQ\n\tyVW+QBoqiqL9A1AYHnHEuAmBX2dNPENx2DBU9NLkI3Su1fMoMtHmuOp162P6y6AE8t\n\tZndxvkQfqVSsKdd3dHGCSHI5YFKszYOvXaPRuAb7XEmnsCvAP8Dkppbkko8GcJA/dF\n\t7TgZn0sxbFW0d0VEDOaEpbvmnfUEvgb66GSUwebzZlsL9DqHaeJJn+g0TpJ7JziXLm\n\tP3NlBPwY2wGQw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=eliasnaur.com; s=google; t=1682984871; x=1685576871;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=JT9F/2a8QX+P9KkPR12/eW/Gl6eMWGffTCP5W8R4ygA=;\n\tb=SBzuTkAStcfgjkGys2kLm6vDjz/7/C/XYPRYkIsDz4t+gRXtIz3dmuz6EqVCLZum9n\n\tddkozjrz/xgHnvYi7YJWKD5JkZI+rLWPBN1qto3w3vHt+HD3b0XvZm1eCua/IE/E7p0n\n\tMjrU2JRwRCcHugE2w3XoEREfvlNNP4iypS+Z0qjiDiqIZhfb7Cf3QtFJ0qWZbHl2uy+m\n\tHvMcNOvi96vs2auQUopa8P/c5emzQpgXr/T5S7+nXfhNjITwNyctg/BbX3xFfJ52o4lk\n\tahK2JiPOdquAZ9cjvrPfP+QRFj4jJiLquNx8Q2zLQUKwwph+F/tIw4sJNbeA7X+HM1Tm\n\tFOMQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=eliasnaur.com\n\theader.i=@eliasnaur.com\n\theader.b=\"SBzuTkAS\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1682984871; x=1685576871;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=JT9F/2a8QX+P9KkPR12/eW/Gl6eMWGffTCP5W8R4ygA=;\n\tb=G+bVCpWtblI3Iln3WpVksoLTpHcw4IPTbB9dlxtFtuolKEQTkUAytIGajA4H6oFJYA\n\t8yt85T8s4WPjO8OcvOLZkERFq/htsazrp7vam8bCq5haO3T1lopnCWT0+hKfILqwa06d\n\tWWCoHpdhI7R2R1qsgzQOJmf004+7zf5OfxREgKdKi2ZEO0IGyxvc+atNVKP91CBVoBvG\n\t0A8RVKD+ApGgKmITN+/mQQDRSJtkJk7pYamRhtqlqFb/SbOZ/Z00raU9+ACsfwglm4YI\n\tZ5ag9fKNbCA4je2KkI7lgmU1DXI1K4ALsq8AzKL48JvfHhpca6saA9jeoeuyO5i/u7DW\n\tZUWA==", "X-Gm-Message-State": "AC+VfDyGlf49F8I10wnilnVCbEEdS3PKPjOcs4UciR5T+bzooXyaQCRk\n\tuh2E7xnkJnYYBdO0bQ30LW4kis/ruftzHwRwCGw=", "X-Google-Smtp-Source": "ACHHUZ4WsfNWv7R6yjCoX4R2W4PAdi/zTly60Z935e3biGd919sxkFkJD9jhr6UfLJr7ekhvEIwg8A==", "X-Received": "by 2002:a05:6102:210:b0:430:6cf6:ddbe with SMTP id\n\tz16-20020a056102021000b004306cf6ddbemr5622399vsp.9.1682984871638; \n\tMon, 01 May 2023 16:47:51 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 1 May 2023 17:47:34 -0600", "Message-Id": "<20230501234734.43869-1-mail@eliasnaur.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: Add missing O_CLOEXEC flag", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Elias Naur via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Elias Naur <mail@eliasnaur.com>", "Cc": "Elias Naur <mail@eliasnaur.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Missed in commit 436b38fd89fe4324d2342084ef477a7a8809a001.\n\nSigned-off-by: Elias Naur <mail@eliasnaur.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 1051997e..a72ef64d 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1471,7 +1471,7 @@ UniqueFD V4L2VideoDevice::exportDmabufFd(unsigned int index,\n \texpbuf.type = bufferType_;\n \texpbuf.index = index;\n \texpbuf.plane = plane;\n-\texpbuf.flags = O_RDWR;\n+\texpbuf.flags = O_CLOEXEC | O_RDWR;\n \n \tret = ioctl(VIDIOC_EXPBUF, &expbuf);\n \tif (ret < 0) {\n", "prefixes": [ "libcamera-devel" ] }