Patch Detail
Show a patch.
GET /api/1.1/patches/18563/?format=api
{ "id": 18563, "url": "https://patchwork.libcamera.org/api/1.1/patches/18563/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18563/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230427072014.26890-1-naush@raspberrypi.com>", "date": "2023-04-27T07:20:14", "name": "[libcamera-devel] pipeline: raspberrypi: Make RPi::Stream::name() return const std::string &", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c7f5c333ddf20681c02a3a3d4ff777c34d3f94ca", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18563/mbox/", "series": [ { "id": 3849, "url": "https://patchwork.libcamera.org/api/1.1/series/3849/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3849", "date": "2023-04-27T07:20:14", "name": "[libcamera-devel] pipeline: raspberrypi: Make RPi::Stream::name() return const std::string &", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3849/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18563/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18563/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9D2CC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Apr 2023 07:20:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16659627E0;\n\tThu, 27 Apr 2023 09:20:17 +0200 (CEST)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FE71627D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Apr 2023 09:20:15 +0200 (CEST)", "by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-3f182d745deso80587475e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Apr 2023 00:20:15 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tu7-20020a5d5147000000b002cde25fba30sm17822015wrt.1.2023.04.27.00.20.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 27 Apr 2023 00:20:13 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682580017;\n\tbh=XPA5YkWxr/m2NEdk1SCc61CCVEge8/8yNmAwfWtuCTc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=l54GpmLN6Hs7KUxUEWUc8KcNy8D0DnIrqohQFZ3LwO0zbC8H0CFZE9VwJWBg4/Tiy\n\tH+pYKxtllOCs4n930Evrv1/DSLp7d6hS00rtKto6Er5g7Biy1+OmPTSsFeIXm6X0Zl\n\tOOEgLv1mPFmY6CLu3B5h3c84oE+UvJXXeVl/O17l9NXwrnW97xAgAKjEgS/iE6X64V\n\t0F8Xv4CsH6VdJcFNgZTsy8s/Ze8jjPeAAuhqv6tT3E8ksnnTim4niKx7z6wP71i05t\n\tV8IWg1783sUWZFwvdtBMwDFD+2nXkza8W27/lzJwT22M4iLP3+ujnaOEVtj8OGlC/a\n\t6nLibKEU+CK6Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1682580014; x=1685172014;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=rXzawEmLspCQfcLDrf2nTVlqapgr+r0VV3pxsl4fspU=;\n\tb=tt3A9b6zWg98ZEGmtMrFXMd7+1jntzUvmSYUaWMdu93BJsAc0S603AqYXQBQUhLIOL\n\tm7QowWYuC0CfMPtbttUMwqSMnLZyi+Kq0rqCe/DU2Y4wyWQhVXDBXM8C268sC3guVWDt\n\tZgZWqAguYoVonh7jXLTlNuONCjaUVyBqiI1NHe4UhZvjiS62Gc2NSw/LqpnljRq7QoPj\n\tkZVD7YkWPXEE40wWPUsUh6vx01Of09jcK9UJDCYmkfgt4gLdbIhpN6Bs8sc9Zd9SKpmz\n\tIRgAbCtaNtN58Q9RbnWRFMO0WfCPH1icWWLztyb7iK4ooBMv7LbBueHW8+xlRflBcpEt\n\tao1A==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"tt3A9b6z\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1682580014; x=1685172014;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=rXzawEmLspCQfcLDrf2nTVlqapgr+r0VV3pxsl4fspU=;\n\tb=MrOJKECcRkukLIm7aSfuwaLo4R1O8CS24RR5nCvU6b5PWY5jW5Srd1BBheI4zWV12X\n\tQyrjpnuI1WDyr0ESXsy+h7FA5nTNFLV1lRXqRnVaDyzX8bq7gJimgQTkNJsAx8vAm0He\n\tG1hEfbZEjiYgm7o0TvYCzo6qZVBLJuM0OgfIIFsSyJ/1xGa4Bp20Ubt/smfEbldiZbnr\n\tZhIbTxF0S+MRfIqblrQbSoIQN2ICv7NctELj4DeQN5e81OsEbAqqoZGq8dtVts13qlBA\n\ttG030UcD2OQZTxOpjeyZ/wVK5jUe/2Mb7f0k8xnlenodJXD1/5elIaVHiqaTN+9n2e8o\n\tv3Dg==", "X-Gm-Message-State": "AC+VfDxv+UiLWbcVuxBeyVtLgeeSEH4Z+90HtmP00UyVmHF+i+JNxrPc\n\tveVLIHWdUyh1Tfs/+XQ75DgkafFAPrdkSf48MDdJmg==", "X-Google-Smtp-Source": "ACHHUZ6pgWddSyLfxERMkZEbcGKj/K039Tt328FpxkuYplPVBakW23VfE+cs/hnplvoYiRboc+iaDQ==", "X-Received": "by 2002:a05:600c:ad9:b0:3f1:7bac:d411 with SMTP id\n\tc25-20020a05600c0ad900b003f17bacd411mr642811wmr.39.1682580014050; \n\tThu, 27 Apr 2023 00:20:14 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 Apr 2023 08:20:14 +0100", "Message-Id": "<20230427072014.26890-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230426131057.21550-11-naush@raspberrypi.com>", "References": "<20230426131057.21550-11-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] pipeline: raspberrypi: Make\n\tRPi::Stream::name() return const std::string &", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Return a const std::string reference from RPi::Stream::name() to avoid\ncopying a string when not needed.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/rpi/common/rpi_stream.cpp | 2 +-\n src/libcamera/pipeline/rpi/common/rpi_stream.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\nindex 3690667e9aa6..b7e4130f5e56 100644\n--- a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n@@ -19,7 +19,7 @@ V4L2VideoDevice *Stream::dev() const\n \treturn dev_.get();\n }\n \n-std::string Stream::name() const\n+const std::string &Stream::name() const\n {\n \treturn name_;\n }\ndiff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.h b/src/libcamera/pipeline/rpi/common/rpi_stream.h\nindex 1aae674967e1..b8c74de35863 100644\n--- a/src/libcamera/pipeline/rpi/common/rpi_stream.h\n+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.h\n@@ -49,7 +49,7 @@ public:\n \t}\n \n \tV4L2VideoDevice *dev() const;\n-\tstd::string name() const;\n+\tconst std::string &name() const;\n \tbool isImporter() const;\n \tvoid resetBuffers();\n \n", "prefixes": [ "libcamera-devel" ] }