Patch Detail
Show a patch.
GET /api/1.1/patches/18545/?format=api
{ "id": 18545, "url": "https://patchwork.libcamera.org/api/1.1/patches/18545/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18545/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230423203931.108022-3-umang.jain@ideasonboard.com>", "date": "2023-04-23T20:39:30", "name": "[libcamera-devel,2/3] apps: cam: kms_sink: Drop unique_ptr<> from DRM::AtomicRequest", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ac46299cecb1f76d7e311e30d0c7b4fa09430ae2", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18545/mbox/", "series": [ { "id": 3845, "url": "https://patchwork.libcamera.org/api/1.1/series/3845/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3845", "date": "2023-04-23T20:39:28", "name": "apps: cam: kms: Introduce requests tracking queue", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3845/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18545/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18545/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAED1C32A4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Apr 2023 20:39:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2AA83627DD;\n\tSun, 23 Apr 2023 22:39:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2380D627D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 23 Apr 2023 22:39:42 +0200 (CEST)", "from umang.jainideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:df01:2ad:735a:b54c:741d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91669C7E;\n\tSun, 23 Apr 2023 22:39:31 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682282386;\n\tbh=oXhEjAjmutFNoV/O0ifo+PR6BmGIsSy9LuVJVWCofBI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QidL5/qel9LzgQdhVCcaEM4NRntPWlA0HwqlpuzLo6h8/kMGYh9U4fFqSPaTHrBVL\n\tulHJS29hSmG22L4OYDWKNqvniroQiYe2cFr0orZh5hUrwoC5r5F6CtdPR8I3SSuZyd\n\tzyzSuhS+xSNabFoi4lk58YMlK/p2Ak8mz9YGZYxlEec/8Jt7xnCJiMkM78M8N0ZKnV\n\tXrMzNuKY+xKdqxJBB4pKgC14l/T2JWFTGP1JTUVSEIWfNGAYsI+QGnYY1yJM/SSAFz\n\tU+RvADOR2l4vB4wA13C+Ul/vjeSXOB/hM+R6V2JHuLX9eOWCUOqxQDE0sNvipwHQK2\n\tQplw4vXaez5Hg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682282372;\n\tbh=oXhEjAjmutFNoV/O0ifo+PR6BmGIsSy9LuVJVWCofBI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WIsfyDTCHYnxM0aUixT5BesmdoWeyOW8+NcGPRYFLN6oeikQAYYQiSmcqcdSzhWXh\n\tE9z86x+EYwiT5caczsj9l2CHAQmdJdUuq1KDNG2KCGb8MZc3HhHRyBC+OENqoJ10bL\n\t41JogvI8Clowqk91EMHs1KFPD0YHPoaCXaX0iKXw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WIsfyDTC\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 24 Apr 2023 02:09:30 +0530", "Message-Id": "<20230423203931.108022-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230423203931.108022-1-umang.jain@ideasonboard.com>", "References": "<20230423203931.108022-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] apps: cam: kms_sink: Drop\n\tunique_ptr<> from DRM::AtomicRequest", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There is no need to wrap DRM::AtomicRequest in std::unique_ptr<>\nin KMSSink::start(). Remove it so that the syntax becomes similar to\nwhat we have in KMSSink::stop().\n\nNo functional changes intended.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/apps/cam/kms_sink.cpp | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\nindex a508977d..2aefec06 100644\n--- a/src/apps/cam/kms_sink.cpp\n+++ b/src/apps/cam/kms_sink.cpp\n@@ -302,24 +302,22 @@ int KMSSink::configurePipeline(const libcamera::PixelFormat &format)\n \n int KMSSink::start()\n {\n-\tstd::unique_ptr<DRM::AtomicRequest> request;\n+\tDRM::AtomicRequest request(&dev_);\n \n \tint ret = FrameSink::start();\n \tif (ret < 0)\n \t\treturn ret;\n \n \t/* Disable all CRTCs and planes to start from a known valid state. */\n-\trequest = std::make_unique<DRM::AtomicRequest>(&dev_);\n-\n \tfor (const DRM::Crtc &crtc : dev_.crtcs())\n-\t\trequest->addProperty(&crtc, \"ACTIVE\", 0);\n+\t\trequest.addProperty(&crtc, \"ACTIVE\", 0);\n \n \tfor (const DRM::Plane &plane : dev_.planes()) {\n-\t\trequest->addProperty(&plane, \"CRTC_ID\", 0);\n-\t\trequest->addProperty(&plane, \"FB_ID\", 0);\n+\t\trequest.addProperty(&plane, \"CRTC_ID\", 0);\n+\t\trequest.addProperty(&plane, \"FB_ID\", 0);\n \t}\n \n-\tret = request->commit(DRM::AtomicRequest::FlagAllowModeset);\n+\tret = request.commit(DRM::AtomicRequest::FlagAllowModeset);\n \tif (ret < 0) {\n \t\tstd::cerr\n \t\t\t<< \"Failed to disable CRTCs and planes: \"\n", "prefixes": [ "libcamera-devel", "2/3" ] }