Patch Detail
Show a patch.
GET /api/1.1/patches/18540/?format=api
{ "id": 18540, "url": "https://patchwork.libcamera.org/api/1.1/patches/18540/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18540/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230419085821.2682901-2-kieran.bingham@ideasonboard.com>", "date": "2023-04-19T08:58:19", "name": "[libcamera-devel,1/3] libcamera: controls: Support dev_t in an Integer32 type.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f4d5b282649327a5ff88f7e9d43603b5660b89a9", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18540/mbox/", "series": [ { "id": 3844, "url": "https://patchwork.libcamera.org/api/1.1/series/3844/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3844", "date": "2023-04-19T08:58:18", "name": "libcamera: Add new Camera devices property", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3844/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18540/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18540/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CA42C3274\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Apr 2023 08:58:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE2FF627C1;\n\tWed, 19 Apr 2023 10:58:32 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97A3A627B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Apr 2023 10:58:30 +0200 (CEST)", "from Monstersaurus.tail69b4.ts.net\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DFEFDF07;\n\tWed, 19 Apr 2023 10:58:23 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1681894712;\n\tbh=xbimLW7IfavOO4wvlCRojtdOMlUfxGpZjZ0RbDIgzMM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=B822mngYtkiz+VItbAeATzVhY2TrJLC+oDZRa41xKFTwDGsVRbrUbYo2myq4kORKD\n\tS5UIaE/YEc8mCTEkCukGQxFyqA+275wH2eyqi9RSo015C3Jcq18xdl54r8+merLgrJ\n\tstqkx+HDcjSu8qahEKc9PexLVcfCwhlANARQnDybSpeLEr9AtxzU3iv2IXW88fuwQF\n\tfFYyfOW86BwGb5qY8htLHjDruNkRAgJOvLv3d6238FWY8z4qT2dgUpoZZV2aJakuaz\n\tV6pSdeB+oDIe0HaB3OSOD7X4g+286qIrd2wo9zsTY0BEaNdajq+6j2WQpWlDJbZJJh\n\tWpD852B0Uxifg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1681894704;\n\tbh=xbimLW7IfavOO4wvlCRojtdOMlUfxGpZjZ0RbDIgzMM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pRotODtGocr/mJliAl0hJhw+nAPXPe9oS2EwJaTQ5TDbrM5cCGcl6pyM86S3OM2F/\n\tWHSKK9puGNoBT+oVPbImY/xk3npLdruO0SQDAbkPUT6NB3FUQDiRhMnDHLekeOqGaI\n\t+pEt0viKA4Z3T0LQA1h0y3an906+nrJuU9WOLM0A=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pRotODtG\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 19 Apr 2023 09:58:19 +0100", "Message-Id": "<20230419085821.2682901-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230419085821.2682901-1-kieran.bingham@ideasonboard.com>", "References": "<20230419085821.2682901-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: controls: Support dev_t in\n\tan Integer32 type.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Allow dev_t device numbers to be stored in a ControlValue utilising the\nspace of a 32 bit integer.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nNote that dev_t is typedef'd as an unsigned long, and this allows all\nunsigned long types to be mapped to a ControlTypeInteger32.\n\nI'm not sure I like that bit, so I'm very open to ideas and suggestions\nhere. Ideally without having to duplicate the devnum vector just after\nit's created, just to retype it.\n\n include/libcamera/controls.h | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex cf94205577a5..84033babbcd5 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -62,6 +62,11 @@ struct control_type<int32_t> {\n \tstatic constexpr ControlType value = ControlTypeInteger32;\n };\n \n+template<>\n+struct control_type<dev_t> {\n+\tstatic constexpr ControlType value = ControlTypeInteger32;\n+};\n+\n template<>\n struct control_type<int64_t> {\n \tstatic constexpr ControlType value = ControlTypeInteger64;\n", "prefixes": [ "libcamera-devel", "1/3" ] }