Patch Detail
Show a patch.
GET /api/1.1/patches/1849/?format=api
{ "id": 1849, "url": "https://patchwork.libcamera.org/api/1.1/patches/1849/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1849/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190818011329.14499-13-laurent.pinchart@ideasonboard.com>", "date": "2019-08-18T01:13:27", "name": "[libcamera-devel,12/14] android: camera_hal_manager: Clean up resources when terminating", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0235ff3243179c6df2e12e292116fc751b9e5c6f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1849/mbox/", "series": [ { "id": 464, "url": "https://patchwork.libcamera.org/api/1.1/series/464/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=464", "date": "2019-08-18T01:13:15", "name": "Assorted fixes for Android camera HAL", "version": 1, "mbox": "https://patchwork.libcamera.org/series/464/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1849/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1849/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CCF06193A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:45 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A78AE734\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:44 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566090824;\n\tbh=Fcw3hNXCiERtZaj4yAZIDVZ1rC+qk8sK2j7uLQ6xJQc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=P2iWVhb1g+dlirpIEW/AkqKIOZiqDTk6uGdPmU3gzlWJl0xWqr29vQeaNMyInddDF\n\txlWrtYCEy24KHvIysfPzXBz5iY8Kjl9XQ16WER/EzzD0o3YBe6JzbXl63jfbJ95ODI\n\ti5y0fTb7cGpHc2CWDUa52VYSnvJ4t8VKCuSKrKAA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Aug 2019 04:13:27 +0300", "Message-Id": "<20190818011329.14499-13-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "References": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 12/14] android: camera_hal_manager: Clean\n\tup resources when terminating", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 18 Aug 2019 01:13:46 -0000" }, "content": "The CameraHalManager starts the libcamera CameraManager and creates\nCameraProxy instances for each camera in the system. Clean up those\nresources when the CameraHalManager terminates.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_hal_manager.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex a1ffb3713d7e..cf981720bca4 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -90,6 +90,10 @@ void CameraHalManager::run()\n \n \t/* Now start processing events and messages. */\n \texec();\n+\n+\t/* Clean up the resources we have allocated. */\n+\tproxies_.clear();\n+\tcameraManager_->stop();\n }\n \n CameraProxy *CameraHalManager::open(unsigned int id,\n", "prefixes": [ "libcamera-devel", "12/14" ] }