Patch Detail
Show a patch.
GET /api/1.1/patches/18476/?format=api
{ "id": 18476, "url": "https://patchwork.libcamera.org/api/1.1/patches/18476/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18476/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230327122030.11756-8-naush@raspberrypi.com>", "date": "2023-03-27T12:20:27", "name": "[libcamera-devel,v2,07/10] ipa: raspberrypi: Make RegionStats::get() always return a Region struct", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "842e21d8cfb2d6952a1793bc4bcd91153d11ca4f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18476/mbox/", "series": [ { "id": 3819, "url": "https://patchwork.libcamera.org/api/1.1/series/3819/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3819", "date": "2023-03-27T12:20:20", "name": "Raspberry Pi: Generalised algorithms", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3819/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18476/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18476/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B16FC329E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Mar 2023 12:20:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB3C66276C;\n\tMon, 27 Mar 2023 14:20:52 +0200 (CEST)", "from mail-io1-xd30.google.com (mail-io1-xd30.google.com\n\t[IPv6:2607:f8b0:4864:20::d30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB8B262747\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Mar 2023 14:20:49 +0200 (CEST)", "by mail-io1-xd30.google.com with SMTP id d14so3784938ion.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Mar 2023 05:20:49 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tr7-20020a5edb47000000b00758ff97aaedsm3239026iop.16.2023.03.27.05.20.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 27 Mar 2023 05:20:47 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679919652;\n\tbh=aRIc5B+sTvytGlTffgEhxKt6BpAyCyw6+uqLU6iJiI8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=aecVvSP1fy0q90dGkWRZqgowL08tb3zfrATDhv6LyGEX1CItXHkLdZVUpgxQxqyjM\n\tImiJMaM77Uhe9/wMSRqr/+oktW+TUu448c1O1OO0pxE6+tiEgYbmFwIbbMJiCsFC0f\n\tkteZ1YX6zrMWaQBsN3GTPB+QAc5HcJhiQUL7FfKxtvv8lAJqpo1mTMumB0jM2tL59/\n\tQZ0h+o/0mzLvyDqDznfc1MUMXLzdVrpETMIqHWWoWKs+UQXK9H+c0SwlV2cKZWdmmt\n\t4CKaBmGzNG1YGBcdcXO8NiTYkZpNPteSFIwnedCmW5FfRZpkmNC3LoNvdAgKbcXNdh\n\tCd4nIlYbxM5Gg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1679919648;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=quqiaExFAgBviDMcf8Asfps18bCBmhdSNFsVml+XS2A=;\n\tb=TOC0g+Cx+txP667AvOXek9H2l0zNgVOXocOqKnqk+/aGVgR+A1lRJykNJ5aFkB76Yt\n\t6vZq8vEC9Coufs+xOJ/UPV007HNEN8q2aY1Pq37p9tLs1mOMmvBDUfmq8wMN0XPhGjmC\n\tKPLt+mJbB43RrtY7mCu7VHh6Do8kB5+oNw0N+9UMVikylgaxEBBAESq57P6T2horyVU7\n\tpqv2jJ1/XHUtLaoA4wIehyY8PfkbC8GG42SAlpQcyRt6YhpztERZlE1lPTs/Z0gF0R5w\n\tthuokgaBasIfq1GaZ/i6WaFXZyzugquY+WtBegB+1gmherni8S9uogNN9Xpc9mNiYN6G\n\tsmbw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"TOC0g+Cx\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1679919648;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=quqiaExFAgBviDMcf8Asfps18bCBmhdSNFsVml+XS2A=;\n\tb=5VR9XWFbcUyks+qEaQmta5+wz++f//4oWBk+B6VRip2MEuTzRMi5Xju2sP8ukqJsiP\n\tbMn2TlgmMHaHFaDjFyNbt8DoxGwrnHxYypT8mOiakhkrVUFWOCAruDIQTlthgmIGdwd4\n\tpVH34uZPWcxM/tOSyl54wOSxEi2elWbjqtg4AdVDJdsFVtQMEV0lzB8/4G+w5uVPM9oJ\n\te1qcJCES+3u7pxPiMxySAfILkTtkJR7jqXWXYvwqopXNd3ISKG9zZVFPQneRZHM4t7q8\n\tG4/1w7b0oUxnPhS+awZq+RR8X2nz9tjkX81ZPFUPToCD1vl+4C4dZ3/hbYv+EmY1TWJI\n\tIEGQ==", "X-Gm-Message-State": "AO0yUKXAyn6TCbEoKDACQRb9UihtB6ZsPRpZTXR1H7ZatVNCBW/XM30o\n\tzaAq/JQZoYuFuhtDiyoK0scWY7iJzVduDVcmB6OxoQ==", "X-Google-Smtp-Source": "AK7set/TOoRFyhzghmmSKw1JTHBYKblB+YgAfN+a3qpPxG6C0bdn7KVz68/Aw1OWVU0JC6ZQoI34Wg==", "X-Received": "by 2002:a6b:a1a:0:b0:759:1e9e:6daa with SMTP id\n\tz26-20020a6b0a1a000000b007591e9e6daamr9091771ioi.10.1679919648352; \n\tMon, 27 Mar 2023 05:20:48 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Mar 2023 13:20:27 +0100", "Message-Id": "<20230327122030.11756-8-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230327122030.11756-1-naush@raspberrypi.com>", "References": "<20230327122030.11756-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 07/10] ipa: raspberrypi: Make\n\tRegionStats::get() always return a Region struct", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update the overloaded RegionStats::get() and RegionStats::getFloating()\nmember functions to return a Region struct for consistency.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/raspberrypi/controller/region_stats.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/region_stats.h b/src/ipa/raspberrypi/controller/region_stats.h\nindex 9aaf3a58a6f7..a8860dc8dba2 100644\n--- a/src/ipa/raspberrypi/controller/region_stats.h\n+++ b/src/ipa/raspberrypi/controller/region_stats.h\n@@ -86,12 +86,12 @@ public:\n \t\treturn get_(index);\n \t}\n \n-\tconst T &get(const libcamera::Point &pos) const\n+\tconst Region &get(const libcamera::Point &pos) const\n \t{\n \t\treturn get(pos.y * size_.width + pos.x);\n \t}\n \n-\tconst T &getFloating(unsigned int index) const\n+\tconst Region &getFloating(unsigned int index) const\n \t{\n \t\tif (index >= numFloatingRegions())\n \t\t\treturn default_;\n", "prefixes": [ "libcamera-devel", "v2", "07/10" ] }