Patch Detail
Show a patch.
GET /api/1.1/patches/18434/?format=api
{ "id": 18434, "url": "https://patchwork.libcamera.org/api/1.1/patches/18434/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18434/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230322130612.5208-8-naush@raspberrypi.com>", "date": "2023-03-22T13:06:09", "name": "[libcamera-devel,v1,07/10] ipa: raspberrypi: Make RegionStats::get() always return a Region struct", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "842e21d8cfb2d6952a1793bc4bcd91153d11ca4f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18434/mbox/", "series": [ { "id": 3810, "url": "https://patchwork.libcamera.org/api/1.1/series/3810/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3810", "date": "2023-03-22T13:06:02", "name": "Raspberry Pi: Generalised algorithms", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3810/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18434/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18434/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E352CC32A0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 22 Mar 2023 13:06:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8051362710;\n\tWed, 22 Mar 2023 14:06:29 +0100 (CET)", "from mail-io1-xd35.google.com (mail-io1-xd35.google.com\n\t[IPv6:2607:f8b0:4864:20::d35])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7631C62722\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Mar 2023 14:06:26 +0100 (CET)", "by mail-io1-xd35.google.com with SMTP id t129so8396943iof.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Mar 2023 06:06:26 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tl6-20020a026646000000b003c488204c6fsm4927960jaf.76.2023.03.22.06.06.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 22 Mar 2023 06:06:24 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679490389;\n\tbh=YMeB7Yt2BHmOWFHNjvg7Zwd4fmpx4B1nhACxM1E/89M=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=zhdWyyIYpW8jEwJUR1ec33uXEABulbJ0T5Z3tRs4ai65xtehmk4CGyBdrmimkUXwC\n\tOoeVpMOCPtZ0Wkb/tZp99kDdlZwFNjharvetHt1enfkGk3EMEu9xQhvcvBXsTP1Rzn\n\tMJ8i9cERQIdPRuk8sVGrqQH0FEUACONuf4RcZkT8iyjxI+YU44uNexP6k7S9FVmeyP\n\txJhBm8fDdURNz/LeeoR2LTnuTNM2CQX/2VWKyFlbXi5vrxcM91L+tqMPQUx3y54Yjr\n\tdJZCMA1EAwh6ep1hzri7rM0u6Pn0A/owMSHygXk26P62FolV4c8vGXKOTIdI0pYIrl\n\tmyGNCEI+vAkeQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1679490385;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=2D3sopp01tCN1h+VaYdiNoKyN5GcBEkpOHldOdbSyLk=;\n\tb=SyCfU+4M0wa9n8zfhgQL+cY36Zt7a0UrWjT/srQIXktpiQOWevik88a3KeyNrGMk/H\n\tIKStUo0hPOxjpje4E/MkkHjZvy8vBhaETm0nW7ht72bF6bT6QKIedrXeauUV4Z+T1ylr\n\tzsQQaZLFRJWZXU+6zl8wlk6kg2LIBAzX15hPf4tfb/FZ3fItvTZ0ABzviW9L9ztbuNM7\n\tRwPGDKzGvuJnvswouNujzjEckKGq1mdDCsygTsu61XdpTW+gEjBjnoUwyRdl7r8KrP60\n\thYnNR447coY/OH8aZSkNiZ6Ts6Dh7hzKFnEzxTnmgYc9U0sYFGuc7xSPLpF6OHlRrYro\n\tTABw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"SyCfU+4M\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1679490385;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=2D3sopp01tCN1h+VaYdiNoKyN5GcBEkpOHldOdbSyLk=;\n\tb=3W8gfMzwn8lDhmFkrcYvP90zJLhbOK5AHO5162jrLGbJFePnEi7T/Aqi6jVcTdhsXV\n\ttZBk2H9ywWip2UMcwF2E4w8EqVzdC7LUWjb4++mzMHD4BDMfCHtTYCqR9u7FHlRaRBhk\n\t8QKJ/FO75w3T6fmlxj8xECvS79mBmVRbULeu4TVAsbzp1xO5WJzreV9TJjDax+Q6DSQR\n\tnsFcvN3qt5D5kssug0mPWw2V6LNuw7cyn/FbSrSPDDNIAsfDsiwKmVVJ89Zzw5Kzqi+i\n\tSNHvNtn/5liNKjr8VP5DCIoZobOoPr0kp/lLNk0iXGEzY0vGioDytSlFRMdm1n+tT7KL\n\td3sQ==", "X-Gm-Message-State": "AO0yUKXg/vMjJHaiYDWf0iiUEalUwthP+PgbMUjETUOU1tgo5yjh2eM4\n\tV4q3AO5DZxFkL2y6HVC8g6r+JT+LQuG5oDRqy17gTQ==", "X-Google-Smtp-Source": "AK7set9AoERnoUHAtrSN3TGtIdEJFpOgeB8ylyX9D4nUxtAkK6DOmKOD8+zVA7mxONDHHjiQL5KAyw==", "X-Received": "by 2002:a6b:b4c5:0:b0:74c:aa8f:1f4c with SMTP id\n\td188-20020a6bb4c5000000b0074caa8f1f4cmr1220412iof.8.1679490385012; \n\tWed, 22 Mar 2023 06:06:25 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 22 Mar 2023 13:06:09 +0000", "Message-Id": "<20230322130612.5208-8-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230322130612.5208-1-naush@raspberrypi.com>", "References": "<20230322130612.5208-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 07/10] ipa: raspberrypi: Make\n\tRegionStats::get() always return a Region struct", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update the overloaded RegionStats::get() and RegionStats::getFloating()\nmember functions to return a Region struct for consistency.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/region_stats.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/region_stats.h b/src/ipa/raspberrypi/controller/region_stats.h\nindex 9aaf3a58a6f7..a8860dc8dba2 100644\n--- a/src/ipa/raspberrypi/controller/region_stats.h\n+++ b/src/ipa/raspberrypi/controller/region_stats.h\n@@ -86,12 +86,12 @@ public:\n \t\treturn get_(index);\n \t}\n \n-\tconst T &get(const libcamera::Point &pos) const\n+\tconst Region &get(const libcamera::Point &pos) const\n \t{\n \t\treturn get(pos.y * size_.width + pos.x);\n \t}\n \n-\tconst T &getFloating(unsigned int index) const\n+\tconst Region &getFloating(unsigned int index) const\n \t{\n \t\tif (index >= numFloatingRegions())\n \t\t\treturn default_;\n", "prefixes": [ "libcamera-devel", "v1", "07/10" ] }