Patch Detail
Show a patch.
GET /api/1.1/patches/1842/?format=api
{ "id": 1842, "url": "https://patchwork.libcamera.org/api/1.1/patches/1842/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1842/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190818011329.14499-6-laurent.pinchart@ideasonboard.com>", "date": "2019-08-18T01:13:20", "name": "[libcamera-devel,05/14] test: event-thread: Fix compilation on Chromium OS", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "278dfaf592e70c56903ec4716d209b6e1256d811", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1842/mbox/", "series": [ { "id": 464, "url": "https://patchwork.libcamera.org/api/1.1/series/464/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=464", "date": "2019-08-18T01:13:15", "name": "Assorted fixes for Android camera HAL", "version": 1, "mbox": "https://patchwork.libcamera.org/series/464/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1842/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1842/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1908C61927\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:42 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A70C751C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:41 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566090821;\n\tbh=NoI7cpVUBaCdLyk4InjmEZC6yarc1sUEg+2lwoUWwp0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=khIJzJydLVmCGsxnzVvZAhcUIaNv01PsF3iTmHxfwV/bHiXEo31goatiRgtTPO361\n\tWneRuxEnnxIVr/u2QLT8k1YMIiC7NX23pI1nBIyYKA+lloaqPS04GDEJ4wgtyLcK4/\n\tlJEEYHUXu/yzgZMSugNywRfwbRX3u4A/ZJqhU0mc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Aug 2019 04:13:20 +0300", "Message-Id": "<20190818011329.14499-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "References": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 05/14] test: event-thread: Fix compilation\n\ton Chromium OS", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 18 Aug 2019 01:13:43 -0000" }, "content": "Commit 92b4af98cd67 (\"test: Add EventNotifier thread move test\") causes\nthe build to fail in the Chromium OS build environment, because the\nreturn values of the pipe() function marked with the\n__warn_unused_result__ attribute is ignored. Fix this.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/event-thread.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/test/event-thread.cpp b/test/event-thread.cpp\nindex 714bc9845820..01120733eca4 100644\n--- a/test/event-thread.cpp\n+++ b/test/event-thread.cpp\n@@ -25,7 +25,11 @@ public:\n \tEventHandler()\n \t\t: notified_(false)\n \t{\n-\t\tpipe(pipefd_);\n+\t\tint ret = pipe(pipefd_);\n+\t\tif (ret < 0) {\n+\t\t\tret = errno;\n+\t\t\tcout << \"pipe() failed: \" << strerror(ret) << endl;\n+\t\t}\n \n \t\tnotifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read, this);\n \t\tnotifier_->activated.connect(this, &EventHandler::readReady);\n", "prefixes": [ "libcamera-devel", "05/14" ] }