Patch Detail
Show a patch.
GET /api/1.1/patches/18372/?format=api
{ "id": 18372, "url": "https://patchwork.libcamera.org/api/1.1/patches/18372/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18372/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230309142601.70556-12-tomi.valkeinen@ideasonboard.com>", "date": "2023-03-09T14:25:57", "name": "[libcamera-devel,v4,11/15] py: unittests.py: Add test for refs & keep-alives", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5396eea151c5fc9298301911b7102fabfed4f731", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18372/mbox/", "series": [ { "id": 3796, "url": "https://patchwork.libcamera.org/api/1.1/series/3796/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3796", "date": "2023-03-09T14:25:46", "name": "py: New python bindings event handling", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3796/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18372/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18372/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30706C32A2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Mar 2023 14:26:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF92F6270F;\n\tThu, 9 Mar 2023 15:26:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEE85626D5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Mar 2023 15:26:20 +0100 (CET)", "from desky.lan (91-154-32-225.elisa-laajakaista.fi [91.154.32.225])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71FB9886;\n\tThu, 9 Mar 2023 15:26:20 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678371988;\n\tbh=H74Qncs4GZTGGWW/AD1IEKuXkea5UP5UCTCdfElM1nI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vdhHGwztlY7QNq5F6WoaPYi39vwsEclJQzRr5bVzhxqLbHjzUWNnVHD7HAdsaCST5\n\tNmktk8W0SzUL/qAom+tY6jr/Le0Sr6hEZxJd5+X1nCZ4858cWDRe5ej2ST6ELyp8Vw\n\tIhoD5wQhw0ibmWusb/unXlyLktK1UkIase2NlBD/uf6xBdUcD8JUjf6SnvYTDa0ykA\n\tx5d92yKZaIyVJgfdpjhWNrkVqavcuTNo8VwJ0VJp4Rnk/1y4LIqila7w48dYozWOav\n\t0VmQLionZKWkCrlbGdMzKcafP0PYWBVTnrbWxlULyCZBGcgHKvpmbzrQ6N39rJv3gw\n\tx0Is/ehs0iAdA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678371980;\n\tbh=H74Qncs4GZTGGWW/AD1IEKuXkea5UP5UCTCdfElM1nI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A0zHtfOIbVr27/qlatv/ncxLp/P6wuDWccm19W+IfHkR52BRHVduOzJOWkiV09d7E\n\tko7AoA8zxwq7/SLTYTUAAWyidB9AzvF0DJ2KWhWXaSIzDIF/3qGNvkMkFkJJwA/VVR\n\tpAVLXmfi/NDmxESdUtYospt3UV5FoATzbISG9KpI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"A0zHtfOI\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 9 Mar 2023 16:25:57 +0200", "Message-Id": "<20230309142601.70556-12-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>", "References": "<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 11/15] py: unittests.py: Add test for\n\trefs & keep-alives", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a test for references and keep-alives by doing a capture, reusing\nthe Requests once and testing that the objects are freed as soon as all\nthe refs and keep-alives are gone.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n test/py/unittests.py | 128 +++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 128 insertions(+)", "diff": "diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 3bd2d7fd..b52b3391 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -31,6 +31,134 @@ class BaseTestCase(unittest.TestCase):\n self.assertTrue(all([not wr() for wr in wr_list]), msg)\n \n \n+# Test references and keep-alives by doing a capture, reusing the Requests once\n+# and testing that the objects are freed as soon as all the refs and keep-alives\n+# are gone.\n+class CaptureRefTestMethods(BaseTestCase):\n+ def test_ref(self):\n+ cm = libcam.CameraManager.singleton()\n+ wr_cm = weakref.ref(cm)\n+\n+ cam = cm.get('platform/vimc.0 Sensor B')\n+ self.assertIsNotNone(cam)\n+ wr_cam = weakref.ref(cam)\n+\n+ cam.acquire()\n+\n+ camconfig = cam.generate_configuration([libcam.StreamRole.StillCapture])\n+ self.assertTrue(camconfig.size == 1)\n+ wr_camconfig = weakref.ref(camconfig)\n+\n+ streamconfig = camconfig.at(0)\n+ wr_streamconfig = weakref.ref(streamconfig)\n+\n+ cam.configure(camconfig)\n+\n+ stream = streamconfig.stream\n+ wr_stream = weakref.ref(stream)\n+\n+ # stream keeps streamconfig and camconfig alive\n+ del streamconfig\n+ del camconfig\n+ gc.collect()\n+ self.assertIsAlive(wr_camconfig)\n+ self.assertIsAlive(wr_streamconfig)\n+\n+ allocator = libcam.FrameBufferAllocator(cam)\n+ num_bufs = allocator.allocate(stream)\n+ self.assertTrue(num_bufs > 0)\n+ wr_allocator = weakref.ref(allocator)\n+\n+ buffers = allocator.buffers(stream)\n+ self.assertIsNotNone(buffers)\n+\n+ wr_buffers = [weakref.ref(b) for b in buffers]\n+\n+ del allocator\n+ self.assertIsAlive(wr_allocator)\n+\n+ reqs = []\n+ wr_reqs = []\n+ for i in range(num_bufs):\n+ req = cam.create_request(i)\n+ self.assertIsNotNone(req)\n+\n+ wr_reqs.append(weakref.ref(req))\n+\n+ req.add_buffer(stream, buffers[i])\n+\n+ reqs.append(req)\n+\n+ del buffers\n+ del stream\n+\n+ self.assertIsDead(wr_stream)\n+\n+ cam.start()\n+\n+ reqs_target = num_bufs * 2\n+ reqs_queued = 0\n+ reqs_captured = 0\n+\n+ for req in reqs:\n+ cam.queue_request(req)\n+ reqs_queued += 1\n+\n+ del req\n+ del reqs\n+\n+ # All buffers and reqs should be alive\n+ self.assertIsAllAlive(wr_buffers)\n+ self.assertIsAllAlive(wr_reqs)\n+\n+ sel = selectors.DefaultSelector()\n+ sel.register(cm.event_fd, selectors.EVENT_READ)\n+\n+ while True:\n+ events = sel.select()\n+ if not events:\n+ continue\n+ del events\n+\n+ for ev in cm.get_events():\n+ self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n+\n+ reqs_captured += 1\n+ self.assertLessEqual(reqs_captured, reqs_target)\n+\n+ if reqs_queued < reqs_target:\n+ req: libcam.Request = typing.cast(libcam.Request, ev.request)\n+ req.reuse()\n+ cam.queue_request(req)\n+ reqs_queued += 1\n+ del req\n+\n+ del ev\n+\n+ if reqs_captured == reqs_target:\n+ break\n+\n+ del sel\n+\n+ # The allocator and all buffers and reqs should be dead\n+ self.assertIsAllDead(wr_buffers)\n+ self.assertIsAllDead(wr_reqs)\n+ self.assertIsDead(wr_allocator)\n+\n+ events = cam.stop()\n+ self.assertZero(len(events))\n+ del events\n+ cam.release()\n+\n+ del cm\n+ self.assertIsAlive(wr_cm)\n+ self.assertIsAlive(wr_cam)\n+\n+ del cam\n+ self.assertIsDead(wr_cam)\n+ self.assertIsDead(wr_cm)\n+\n+\n class SimpleTestMethods(BaseTestCase):\n def test_get_ref(self):\n cm = libcam.CameraManager.singleton()\n", "prefixes": [ "libcamera-devel", "v4", "11/15" ] }