Patch Detail
Show a patch.
GET /api/1.1/patches/1836/?format=api
{ "id": 1836, "url": "https://patchwork.libcamera.org/api/1.1/patches/1836/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1836/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190817152104.10834-19-laurent.pinchart@ideasonboard.com>", "date": "2019-08-17T15:21:04", "name": "[libcamera-devel,v2,18/18] test: Simplify tests with parent-child relationships", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "465da85dcfdd2f26af2279aea39e10fc6fda442b", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1836/mbox/", "series": [ { "id": 463, "url": "https://patchwork.libcamera.org/api/1.1/series/463/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=463", "date": "2019-08-17T15:20:46", "name": "Object & Thread enhancements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/463/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1836/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1836/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A8CE61934\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 17 Aug 2019 17:21:19 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01CDFF78\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 17 Aug 2019 17:21:18 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566055279;\n\tbh=UQEeFbjsRyzTjI4NOmwfwPm9jZVVigWClodH2XNZflQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=D4ZarYxd7s+Z39rJHpOJrEsMqYcLBsf3p8ClGZmuUPo3kn6c+YwGXPJT8VdaboKhF\n\tkFwjS5fCr1+ofAqJmTFUl+d9cEhBtGv7VVusNYTkKUtnWD0BTEQenGybka2KxR6WmE\n\tdvk5Lx0wAf40dPH2qlr+wI0IVByxBBECP7Z9x3NE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 17 Aug 2019 18:21:04 +0300", "Message-Id": "<20190817152104.10834-19-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190817152104.10834-1-laurent.pinchart@ideasonboard.com>", "References": "<20190817152104.10834-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 18/18] test: Simplify tests with\n\tparent-child relationships", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 17 Aug 2019 15:21:20 -0000" }, "content": "Create object instances with a parent to avoid the need for reparenting\nobjects manually.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n test/event-thread.cpp | 8 +-------\n test/timer-thread.cpp | 8 +-------\n 2 files changed, 2 insertions(+), 14 deletions(-)", "diff": "diff --git a/test/event-thread.cpp b/test/event-thread.cpp\nindex 4a82d49b94f1..58f452339f87 100644\n--- a/test/event-thread.cpp\n+++ b/test/event-thread.cpp\n@@ -26,7 +26,7 @@ public:\n \t{\n \t\tpipe(pipefd_);\n \n-\t\tnotifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read);\n+\t\tnotifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read, this);\n \t\tnotifier_->activated.connect(this, &EventHandler::readReady);\n \t}\n \n@@ -60,12 +60,6 @@ public:\n \t\treturn notified_;\n \t}\n \n-\tvoid moveToThread(Thread *thread)\n-\t{\n-\t\tObject::moveToThread(thread);\n-\t\tnotifier_->moveToThread(thread);\n-\t}\n-\n private:\n \tvoid readReady(EventNotifier *notifier)\n \t{\ndiff --git a/test/timer-thread.cpp b/test/timer-thread.cpp\nindex b9373050068c..5c1b4ac4a401 100644\n--- a/test/timer-thread.cpp\n+++ b/test/timer-thread.cpp\n@@ -20,7 +20,7 @@ class TimeoutHandler : public Object\n {\n public:\n \tTimeoutHandler()\n-\t\t: timeout_(false)\n+\t\t: timer_(this), timeout_(false)\n \t{\n \t\ttimer_.timeout.connect(this, &TimeoutHandler::timeoutHandler);\n \t\ttimer_.start(100);\n@@ -31,12 +31,6 @@ public:\n \t\treturn timeout_;\n \t}\n \n-\tvoid moveToThread(Thread *thread)\n-\t{\n-\t\tObject::moveToThread(thread);\n-\t\ttimer_.moveToThread(thread);\n-\t}\n-\n private:\n \tvoid timeoutHandler(Timer *timer)\n \t{\n", "prefixes": [ "libcamera-devel", "v2", "18/18" ] }