Patch Detail
Show a patch.
GET /api/1.1/patches/18351/?format=api
{ "id": 18351, "url": "https://patchwork.libcamera.org/api/1.1/patches/18351/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18351/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230307114804.42291-2-jacopo.mondi@ideasonboard.com>", "date": "2023-03-07T11:48:01", "name": "[libcamera-devel,v3,1/4] libcamera: rkisp1: Generate config using main path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ce16983f6f2f9c7d0001ebdb45d415d6f7ccc7eb", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18351/mbox/", "series": [ { "id": 3792, "url": "https://patchwork.libcamera.org/api/1.1/series/3792/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3792", "date": "2023-03-07T11:48:00", "name": "libcamera: rkisp1: Fix generateConfiguration", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3792/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18351/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18351/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29A04BDE17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Mar 2023 11:48:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B595626BD;\n\tTue, 7 Mar 2023 12:48:21 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95DDD6265E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Mar 2023 12:48:19 +0100 (CET)", "from uno.homenet.telecomitalia.it\n\t(host-79-47-54-87.retail.telecomitalia.it [79.47.54.87])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E5CD6D5;\n\tTue, 7 Mar 2023 12:48:18 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678189701;\n\tbh=yTZCZe+asRpABZTXEMdxSzftafd8+qHzj3TlxvWe8Y0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=31GnVCco6lemk2uCPNzOAm2lv16IHlfCMlYDE8ovs+p7+Wt0CT03l/3s4R+mzGxAg\n\tSlcvtZ/3nMY7Trjd+Eoz2k1HB9ub+WfPrAjZE9LDXslJA76KZd0DBjgcM+OZaKbZzu\n\tjx5Ot91m1t+fLn97hlwaATaYcddnO1CVC2cjacyqxN9AFz7uV/zOMZY5mPfrFxS8W5\n\t9ksKbdSvAYJpmHE6f9uRou0aPeOhiTdYzb4sL4856ij7b6uYf2xVQJe0BmPa2bfOn4\n\trWhedKjc05PzU7hT8Ri3ilnHwCij9Tu+17XBIspPoErz/kjWHl56UR5VmANAMu6Ep6\n\tHUCdr5bxS7jkQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678189699;\n\tbh=yTZCZe+asRpABZTXEMdxSzftafd8+qHzj3TlxvWe8Y0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=F7NnQAaUWn2wEKDy8fA4fvhoVCB6SLd2/NxxRRxHga/Tq/092WbhHsG3yeWIHJUqP\n\tIrxZgqdN4Sm1UiR57lcT6+8W+0pvC+wNHiSZDMzqdwR2N/ADbuGTMkzy9okwlso2GJ\n\tdvxT90ymZkgv3izr+/x/vvtqWQbuKDf49in3NsYw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"F7NnQAaU\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 7 Mar 2023 12:48:01 +0100", "Message-Id": "<20230307114804.42291-2-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.0", "In-Reply-To": "<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>", "References": "<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/4] libcamera: rkisp1: Generate config\n\tusing main path", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, libcamera@luigi311.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The generateConfiguration() implementation in the Rockchip RkISP1\npipeline handler uses by default the self path (if available) for\nthe Viewfinder and VideoRecording StreamRoles.\n\nThe validate() implementation, at the contrary, prefers using the main\npath, when available, for all streams.\n\nAs the self-path is limited in output resolution to 1920x1920,\ngenerating a configuration using the self path limits the maximum\nstream size to 1920x1920, while higher resolutions can be obtained by\nusing the main path.\n\nAlign the generateConfiguration() implementation to the validate() one\nby using the main path by default if available.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=180\nReported-by: libcamera@luigi311.com\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 096c9cca3a0a..ebc9bef8688a 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -647,23 +647,19 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t * first stream and use it for all streams.\n \t */\n \tstd::optional<ColorSpace> colorSpace;\n-\n \tbool mainPathAvailable = true;\n-\tbool selfPathAvailable = data->selfPath_;\n \n \tfor (const StreamRole role : roles) {\n-\t\tbool useMainPath;\n+\t\tbool useMainPath = mainPathAvailable;\n \n \t\tswitch (role) {\n \t\tcase StreamRole::StillCapture:\n-\t\t\tuseMainPath = mainPathAvailable;\n \t\t\t/* JPEG encoders typically expect sYCC. */\n \t\t\tif (!colorSpace)\n \t\t\t\tcolorSpace = ColorSpace::Sycc;\n \t\t\tbreak;\n \n \t\tcase StreamRole::Viewfinder:\n-\t\t\tuseMainPath = !selfPathAvailable;\n \t\t\t/*\n \t\t\t * sYCC is the YCbCr encoding of sRGB, which is commonly\n \t\t\t * used by displays.\n@@ -673,7 +669,6 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t\t\tbreak;\n \n \t\tcase StreamRole::VideoRecording:\n-\t\t\tuseMainPath = !selfPathAvailable;\n \t\t\t/* Rec. 709 is a good default for HD video recording. */\n \t\t\tif (!colorSpace)\n \t\t\t\tcolorSpace = ColorSpace::Rec709;\n@@ -686,7 +681,6 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t\t\t\treturn nullptr;\n \t\t\t}\n \n-\t\t\tuseMainPath = true;\n \t\t\tcolorSpace = ColorSpace::Raw;\n \t\t\tbreak;\n \n@@ -703,7 +697,6 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t\t\tmainPathAvailable = false;\n \t\t} else {\n \t\t\tpath = data->selfPath_;\n-\t\t\tselfPathAvailable = false;\n \t\t}\n \n \t\tStreamConfiguration cfg =\n", "prefixes": [ "libcamera-devel", "v3", "1/4" ] }