Patch Detail
Show a patch.
GET /api/1.1/patches/18305/?format=api
{ "id": 18305, "url": "https://patchwork.libcamera.org/api/1.1/patches/18305/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18305/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230223204755.46740-1-suhrid.subramaniam@mediatek.com>", "date": "2023-02-23T20:47:57", "name": "[libcamera-devel] libcamera: pipeline: simple: Check if converter_ is a nullptr", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1e4bf5b2ea41a6efd2330c7e6036a4d095c223c6", "submitter": { "id": 151, "url": "https://patchwork.libcamera.org/api/1.1/people/151/?format=api", "name": "Suhrid Subramaniam", "email": "suhridsubramaniam@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18305/mbox/", "series": [ { "id": 3766, "url": "https://patchwork.libcamera.org/api/1.1/series/3766/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3766", "date": "2023-02-23T20:47:57", "name": "[libcamera-devel] libcamera: pipeline: simple: Check if converter_ is a nullptr", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3766/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18305/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18305/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BA48BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Feb 2023 21:04:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9F7B6265D;\n\tThu, 23 Feb 2023 22:04:04 +0100 (CET)", "from mail-pl1-x631.google.com (mail-pl1-x631.google.com\n\t[IPv6:2607:f8b0:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06438603B4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Feb 2023 21:50:18 +0100 (CET)", "by mail-pl1-x631.google.com with SMTP id i10so5614871plr.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Feb 2023 12:50:17 -0800 (PST)", "from localhost.localdomain (sfosm0151r356001-v22.wiline.com.\n\t[67.207.106.98]) by smtp.gmail.com with ESMTPSA id\n\tk17-20020a170902761100b0019a8468cbedsm4217942pll.226.2023.02.23.12.50.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 23 Feb 2023 12:50:15 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677186244;\n\tbh=OvFOgdhytnUxq9sLHEK9OxfYsVRB2KT92yJ8nZXUIQo=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=QKQyH+ERGfGy9DNutlQ2rIzFVqaqhblh20SHbRmubTJsU6eGAW/BEcw4zt39W5z6K\n\tDxSZx+Qrk6+XdI8n7wN7MRDwGGHwoa6pz+Nj8HapQ8K2KfsZcndmzoU0JQEW+LDqUG\n\tVN64rbdJEoB+9Jos02M2Gc8+5D/M+5QTtujHQvo0OMMoWFjlu+ughSoNLVNnFgO7at\n\tS1KTKSSDQw/d2hv5VPBxWm/VmRz9j4XktzUbSTizxDC2BRd7K9uz/wemA/bL642A/O\n\tHXRe2zd8mP0HRZFUHi3dE0W9L8igO/0G/RuGTbZTKcI2Qh2nn1BpRSDEn64eJqAtIY\n\tDrqgw5m3+kZGA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20210112; t=1677185416;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=55bXgzJ7lgqJoz6t2+4fIitcYoL4Exh0HE4g/IB3upo=;\n\tb=Nb5+on21WnDoBZnczA9srtCm5WdfUGcvT1PfwUnOnKeXR3wDvV/Tvi7o414uKhtXDc\n\tWgKI5/YG9icTNp5K/tqf241LdJPNM+4h79YHPmKgU7SIJUsrULW+Y5KTvvtS3q5NhRIE\n\t01/jo2uuQq33SdaofdWWhzuzxH5lIqXFunq9qbGqa6wV/2wuu2pkrfcvDp9gE9+2SScr\n\tNQ7T9qrNd91SzHJJ5PQHrKLLguM4g+zGK5d9yxg848ttzbUmx5wbJgU424eyC7gIKPxe\n\t+DBTnFKV5daAgTtvBlERZgCBeyGnIs5zisH+1IvGPG6F4K/86lFIIBziyi+q6IZ+x/Ov\n\tqiaw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Nb5+on21\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1677185416;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=55bXgzJ7lgqJoz6t2+4fIitcYoL4Exh0HE4g/IB3upo=;\n\tb=JDGwBFFo+PdFUe+t5NpxyFrOytixLCFCwmPOmRX9ltubbVKtNV0wbpFGprSzfiGDj9\n\ttbiceNPvo6O0amC8/AK9FdIhgyXaK2f/1R/Dmdhn+Ux1QHsmcjuoY4hpHCh5GrFRTnyu\n\tMPKVQRYZTjbgLIXDu11+yMT0BsmWYSLbc4GCkJc4EAxRZdvJfojwf7X364L7mTJemQ8+\n\t30/EfJKL+FSf8drfakuWh78v4ChkCTM6azDzEIH30uoYbv5U2G30P+7ZvE0+qZCQ9wX0\n\t5Ueqh+gWfst7duz18wBtjNX7UzHpmyptf0+v0l2aCwRfjOYxfQKeFhcjmvnqbCNqLtZd\n\tKJJg==", "X-Gm-Message-State": "AO0yUKWVYz+oiyA+YksdTPIb8tPg5NkwH50/60BHUk2oHd353+dgx6eV\n\t2r2gQMByNp+EWuPSBE52RHv/KHOdm/M6dLhKfY8=", "X-Google-Smtp-Source": "AK7set/WUHV3bx9GTmF8dqEDRstH5sWWT2CCJN2nvKoZTWa1ZX91sk5NUwbVB8b3L/Di6VFRx887Tw==", "X-Received": "by 2002:a17:902:ea03:b0:196:56c8:cfab with SMTP id\n\ts3-20020a170902ea0300b0019656c8cfabmr13913833plg.1.1677185415901; \n\tThu, 23 Feb 2023 12:50:15 -0800 (PST)", "X-Google-Original-From": "Suhrid Subramaniam <suhrid.subramaniam@mediatek.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 23 Feb 2023 12:47:57 -0800", "Message-Id": "<20230223204755.46740-1-suhrid.subramaniam@mediatek.com>", "X-Mailer": "git-send-email 2.39.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Thu, 23 Feb 2023 22:04:03 +0100", "Subject": "[libcamera-devel] libcamera: pipeline: simple: Check if converter_\n\tis a nullptr", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Suhrid Subramaniam via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Suhrid Subramaniam <suhridsubramaniam@gmail.com>", "Cc": "Suhrid Subramaniam <suhrid.subramaniam@mediatek.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "- If no converter is found, converter_ becomes a nullptr and\n!converter_->isValid() causes a segmentation fault.\n- Avoid this by checking if converter_ is a nullptr.\n\nSigned-off-by: Suhrid Subramaniam <suhrid.subramaniam@mediatek.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 24ded4db..2423ec10 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -493,7 +493,7 @@ int SimpleCameraData::init()\n \tMediaDevice *converter = pipe->converter();\n \tif (converter) {\n \t\tconverter_ = ConverterFactoryBase::create(converter);\n-\t\tif (!converter_->isValid()) {\n+\t\tif (!converter_) {\n \t\t\tLOG(SimplePipeline, Warning)\n \t\t\t\t<< \"Failed to create converter, disabling format conversion\";\n \t\t\tconverter_.reset();\n", "prefixes": [ "libcamera-devel" ] }