Patch Detail
Show a patch.
GET /api/1.1/patches/18290/?format=api
{ "id": 18290, "url": "https://patchwork.libcamera.org/api/1.1/patches/18290/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18290/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230221164504.120738-2-jacopo.mondi@ideasonboard.com>", "date": "2023-02-21T16:45:02", "name": "[libcamera-devel,1/3] libcamera: rkisp1: Generate config using main path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ce16983f6f2f9c7d0001ebdb45d415d6f7ccc7eb", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18290/mbox/", "series": [ { "id": 3760, "url": "https://patchwork.libcamera.org/api/1.1/series/3760/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3760", "date": "2023-02-21T16:45:01", "name": "libcamera: rkisp1: Fix generateConfiguration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3760/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18290/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18290/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F569C3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Feb 2023 16:45:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1295062652;\n\tTue, 21 Feb 2023 17:45:23 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D8A362636\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Feb 2023 17:45:21 +0100 (CET)", "from uno.homenet.telecomitalia.it\n\t(host-87-16-53-160.retail.telecomitalia.it [87.16.53.160])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7CEE59D;\n\tTue, 21 Feb 2023 17:45:20 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676997923;\n\tbh=+1iyV2gHAn7SrlN9e6NHWLjBt6ZCa0hB+kgYjP2c0ps=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=lC2uTB5RZ1HJAFA+tZ2RqrG8iLTwOVYqiPc8qMYsjLtoFSxZBHN8iR1V2V+5C/LZg\n\t9tk94cVYRNpy2sYzdzaxvi7SFmKVtsAw9yRWW8yVg4aYqqrVoRxqKUp0VZsPzWHFYx\n\tnG/zxoRg7sd94zp5RlvVHTpSxY3Yd25nX54W3K0w46KugqD3d0Sv6c/yj//jz0fugO\n\tz3odP0/IkShq2azEaVdfsBkpF52Q8bEax/Fw31tq6bDT1QGPGhMd/TZBoZvhvqAED2\n\tppGdcFG0OxuECZ4fmvRaXRwdvFdpr2ePh1DKa4xkddjogNOPESZ8GX4EHiuXY+A8NX\n\thbNOfdbiqcwHA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1676997921;\n\tbh=+1iyV2gHAn7SrlN9e6NHWLjBt6ZCa0hB+kgYjP2c0ps=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=q/ymOWpfexzYV0HYRJ49bs5c/qrV1Bi3ezKd8oi9aZ6Y4DnZUPgOHB2DB/+dOLDxW\n\tsY9awR7+KqIUIGmmuo7XIRxGRVbVrDmiLZMHEfTm9IgfTPznMVF+Q/Tl6I6Zax46hJ\n\tXzeSoYCt8zcuTH1ahmd/GzfTO5b4/fF1hQsY1rYk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"q/ymOWpf\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 21 Feb 2023 17:45:02 +0100", "Message-Id": "<20230221164504.120738-2-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.0", "In-Reply-To": "<20230221164504.120738-1-jacopo.mondi@ideasonboard.com>", "References": "<20230221164504.120738-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: rkisp1: Generate config\n\tusing main path", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, libcamera@luigi311.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The generateConfiguration() implementation in the Rockchip RkISP1\npipeline handler uses by default the self path (if available) for\nthe Viewfinder and VideoRecording StreamRoles.\n\nThe validate() implementation, at the contrary, prefers using the main\npath, when available, for all streams.\n\nAs the self-path is limited in output resolution to 1920x1920,\ngenerating a configuration using the self path limits the maximum\nstream size to 1920x1920, while higher resolutions can be obtained by\nusing the main path.\n\nAlign the generateConfiguration() implementation to the validate() one\nby using the main path by default if available.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=180\nReported-by: libcamera@luigi311.com\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 8a30fe061d04..569fb8ecb629 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -630,23 +630,19 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t * first stream and use it for all streams.\n \t */\n \tstd::optional<ColorSpace> colorSpace;\n-\n \tbool mainPathAvailable = true;\n-\tbool selfPathAvailable = data->selfPath_;\n \n \tfor (const StreamRole role : roles) {\n-\t\tbool useMainPath;\n+\t\tbool useMainPath = mainPathAvailable;\n \n \t\tswitch (role) {\n \t\tcase StreamRole::StillCapture:\n-\t\t\tuseMainPath = mainPathAvailable;\n \t\t\t/* JPEG encoders typically expect sYCC. */\n \t\t\tif (!colorSpace)\n \t\t\t\tcolorSpace = ColorSpace::Sycc;\n \t\t\tbreak;\n \n \t\tcase StreamRole::Viewfinder:\n-\t\t\tuseMainPath = !selfPathAvailable;\n \t\t\t/*\n \t\t\t * sYCC is the YCbCr encoding of sRGB, which is commonly\n \t\t\t * used by displays.\n@@ -656,7 +652,6 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t\t\tbreak;\n \n \t\tcase StreamRole::VideoRecording:\n-\t\t\tuseMainPath = !selfPathAvailable;\n \t\t\t/* Rec. 709 is a good default for HD video recording. */\n \t\t\tif (!colorSpace)\n \t\t\t\tcolorSpace = ColorSpace::Rec709;\n@@ -669,7 +664,6 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t\t\t\treturn nullptr;\n \t\t\t}\n \n-\t\t\tuseMainPath = true;\n \t\t\tcolorSpace = ColorSpace::Raw;\n \t\t\tbreak;\n \n@@ -686,7 +680,6 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t\t\tmainPathAvailable = false;\n \t\t} else {\n \t\t\tpath = data->selfPath_;\n-\t\t\tselfPathAvailable = false;\n \t\t}\n \n \t\tStreamConfiguration cfg =\n", "prefixes": [ "libcamera-devel", "1/3" ] }