Patch Detail
Show a patch.
GET /api/1.1/patches/18278/?format=api
{ "id": 18278, "url": "https://patchwork.libcamera.org/api/1.1/patches/18278/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18278/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230213101808.4985-1-david.plowman@raspberrypi.com>", "date": "2023-02-13T10:18:08", "name": "[libcamera-devel,v2] pipeline: raspberrypi: Fix error in validateColorSpaces", "commit_ref": "02f0492c55f293b6a00ee702cee51b5f1b1c2e50", "pull_url": null, "state": "accepted", "archived": false, "hash": "25856d511b40b2ebee190c3a35c128eba60cd427", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18278/mbox/", "series": [ { "id": 3752, "url": "https://patchwork.libcamera.org/api/1.1/series/3752/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3752", "date": "2023-02-13T10:18:08", "name": "[libcamera-devel,v2] pipeline: raspberrypi: Fix error in validateColorSpaces", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3752/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18278/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18278/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A855BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Feb 2023 10:18:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7EA6625F4;\n\tMon, 13 Feb 2023 11:18:13 +0100 (CET)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A611361EED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Feb 2023 11:18:12 +0100 (CET)", "by mail-wm1-x32f.google.com with SMTP id\n\tbg5-20020a05600c3c8500b003e00c739ce4so8570079wmb.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Feb 2023 02:18:12 -0800 (PST)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tm17-20020a05600c3b1100b003df5be8987esm17662640wms.20.2023.02.13.02.18.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Feb 2023 02:18:11 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676283493;\n\tbh=BQhPLflshEqUpFwLE9QkcuEOa0RPXBdQzt7FSqhNd4k=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=mrakHr48M6yEuph6TlVgymIApayZvxq0rISfAlWAS+ul+UV0UFJejQOQYUqGARVRn\n\tMjz8r/JFPscd96dMM2HJKI5CnBHCSG1/Pt00pXdst0FGXpkJflcB5C2ju2v7W3EYWe\n\tZoUqOgI+W+QQzdhnwYjHcV/wDimjSlZFanSNSSBnVssXORHnXSl1JwNgyAPNi8CjhN\n\tyRl+ZqzmnvyrgFWADQ5BeR+uIVSlnElkGi79UwiMkhJcrrTUN2XL8JvM2M4CPsHWBA\n\tmr82rY0pFRHYQa+feDRI9WJEXmmZGlk6mWJ6dgvVyeVfU263jYGTZ80LxgpEwFeNnE\n\t1q01v2dwZuA8A==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ZZAoXy19ikm1jKHqYClfTHA33QP56yDo1XHhRALdOFE=;\n\tb=mTOlsnYudFiUlJb7xrt5FETlRTAxFf77d6gdAarjHGH6O04cliEKcD3YpE9MHaSeQj\n\tBks/O/OQkesqKmTo4tiQPaJGwJJlAXPKx1y/woVp8aq6nUGx9gPLkKk1zvQ3rY6o6UmU\n\tHBrYHB4xpg1HoSCeFVYDY7u3T3mHF/b0sQZLKARJCV04qRul/s+ILC6DnokQFqq+R9Nn\n\t2AOsH/n6Orptlc3+OGCkRyPkz8LkL4+cApqEa3sby8V8n5uGXrt0a+h7PqAkXlaxWT6W\n\tVaJykJjZS+ERQI9GN05fRhiRhM1nM6qSgyE/rhY+Z9Ewu+q+d/IlWgjHISK1f8VVm7jz\n\toRrg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"mTOlsnYu\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ZZAoXy19ikm1jKHqYClfTHA33QP56yDo1XHhRALdOFE=;\n\tb=g7P0X54VOkwLW8T/iJIkIRQWEJfgNpgIgSFWEcMyjr8R3QADPGIKeFbMuKSkXPDR/f\n\tmRu0d8Va9mpehd4BDBuyswq+Ht9qMW+RNR+J+RrgzlDatdcQpmoG+ebOCYWgkNw9mmBJ\n\tS7yIGfBG/WIhTm+NDf6wGpbdkpGoF+54hMEWGT3Wo7k+AkFsWvwmgRypIfgKjklt0iVH\n\t5ikPspxmJ6exaEfynQiahtPBPS478pFelau9myS5LMOQTPgxN8YB3ctIW29U27tZ9WXp\n\tiwlysxMrK8OvsGEjgg8YiyBhgNbKiRZ4SD/j2Fj176V3m2CY6LIEOhdxUmy5crgafYC4\n\tcd9g==", "X-Gm-Message-State": "AO0yUKXypBYTXfjWQM600cAFzOVFIWtEIPWE1/HmiQHhrnqYh9mhdaZk\n\t+IzNnRSnKn7DJjuTtu5fTxK1mSp6mAz9EIbl", "X-Google-Smtp-Source": "AK7set8ILxAk/QEGD44saiFfwywtZLhsf8yQIzdzh+ZoOLYWpp9CfVyCb7DqPSJNoGAxtX4xUUiyeg==", "X-Received": "by 2002:a05:600c:3511:b0:3df:9858:c03a with SMTP id\n\th17-20020a05600c351100b003df9858c03amr5339146wmq.15.1676283492077; \n\tMon, 13 Feb 2023 02:18:12 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 13 Feb 2023 10:18:08 +0000", "Message-Id": "<20230213101808.4985-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] pipeline: raspberrypi: Fix error in\n\tvalidateColorSpaces", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "David Plowman <david.plowman@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This fixes a small error in the validateColorSpaces method where the\ncolour space was not being set to Raw if it had an \"unset\" (null\noption) value.\n\nFixes: 613d5402673e (\"pipeline: raspberrypi: Fix handling of colour spaces\")\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex c0dd9551..84120954 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -449,10 +449,9 @@ CameraConfiguration::Status RPiCameraConfiguration::validateColorSpaces([[maybe_\n \t\t/* First fix up raw streams to have the \"raw\" colour space. */\n \t\tif (isRaw(cfg.pixelFormat)) {\n \t\t\t/* If there was no value here, that doesn't count as \"adjusted\". */\n-\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw) {\n+\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw)\n \t\t\t\tstatus = Adjusted;\n-\t\t\t\tcfg.colorSpace = ColorSpace::Raw;\n-\t\t\t}\n+\t\t\tcfg.colorSpace = ColorSpace::Raw;\n \t\t\tcontinue;\n \t\t}\n \n", "prefixes": [ "libcamera-devel", "v2" ] }