Patch Detail
Show a patch.
GET /api/1.1/patches/18277/?format=api
{ "id": 18277, "url": "https://patchwork.libcamera.org/api/1.1/patches/18277/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18277/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230213091934.2356-1-david.plowman@raspberrypi.com>", "date": "2023-02-13T09:19:34", "name": "[libcamera-devel] pipeline: raspberrypi: Fix error in validateColorSpaces", "commit_ref": "02f0492c55f293b6a00ee702cee51b5f1b1c2e50", "pull_url": null, "state": "accepted", "archived": false, "hash": "25856d511b40b2ebee190c3a35c128eba60cd427", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18277/mbox/", "series": [ { "id": 3751, "url": "https://patchwork.libcamera.org/api/1.1/series/3751/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3751", "date": "2023-02-13T09:19:34", "name": "[libcamera-devel] pipeline: raspberrypi: Fix error in validateColorSpaces", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3751/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18277/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18277/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7147BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Feb 2023 09:19:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 054DA625E3;\n\tMon, 13 Feb 2023 10:19:41 +0100 (CET)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90BF961EED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Feb 2023 10:19:39 +0100 (CET)", "by mail-wm1-x32b.google.com with SMTP id\n\tm20-20020a05600c3b1400b003e1e754657aso2306717wms.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Feb 2023 01:19:39 -0800 (PST)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tbg1-20020a05600c3c8100b003e118684d56sm14135485wmb.45.2023.02.13.01.19.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Feb 2023 01:19:38 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676279981;\n\tbh=mj9RlCaGERUT2mUjKJ2Ui7OnAFZUoz9id+eqzhc7HJc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=HqeSEWsYGdqRmTsENzAngSJRHL0PjUBhY+BgUTaUbKBrDfDcid0UcDZkPqXhgkOUu\n\tyqmZb/gZjRkDswNJ/eUk4x/rS+D7GEy4ZN/WNQGd6HPKj4Zi6qvr/RPvrn3VGZ1Sa1\n\tK9UVJaikrdA4dD/SPltEd76zB57iFq/updRML341WnvcuQiQODZavYub+wkUm2L4G+\n\tRwYb+LvLLyQ05dV6EscGfU+xVIHb8Z54jbwhxDsIaanhCFs0jnFpz8sKWrZOy5IuCF\n\tnTSlYn6HZy2EfFd9pgbZna1RjXTLFRvOLpiL9dHC8jq89ugVUJNd3laIsR6/7a2pB4\n\tHq2Gayljn0HTw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=fQl1dqXv05csJmiZGC0kR2/1g0tkHwD0LTQHKI/OMm8=;\n\tb=MgFDSBwG0ZTGy1lKbHIPo/LcC++4dgV4aljHBZHZ//MW1meteJe+6meccSpfcvAd6V\n\tRaKigKZIs8TaVoge8+el/bdyF8bfCE9JqD9+mbab9mrumOzNFYKBiKkCguQJg0LNCqKy\n\tz3NuKweacO4jLTU9ydHmgY4PKZqXwwGnJlmYS70gMRIgZoipr0OGWyUwG7TY38fwHVzY\n\t2YUCwthRKPo/DcBcqKOUtGVW2CpGdjNKsU8BCJf6741Lj1aKFX9/mKonLm0A7vFwKXHL\n\tWkk3o3QdmHKvKMPdb9HGAyh78/qiKj0aJGmRdvgnSBaVB8pZZWaYeVJREKDNaw+VkNbN\n\tkTWw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"MgFDSBwG\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=fQl1dqXv05csJmiZGC0kR2/1g0tkHwD0LTQHKI/OMm8=;\n\tb=CsUxYqPA+U3AqM6n8SBCNePXE5KcwTt10TxJF3kUpl2xVnBpooxf4k/Nzri6RVHnK8\n\t8015u8/2ki7WNYab4RpxF4HR4TYvl1APLRn15jbpPeTTbFvh/jlig2qeRPIaVwINzoMQ\n\tafQzl2/MiTaKXJJ+HQ5f7LC9PtzVP01VZc0WyKyEnVh1WJHU0hiyTXsOR2H594j6vDjR\n\tjzLeOkRjgjAeUlAtqLdny6J5XKbbQuFx7JtyaSMtAT6VPoDVFLkzJXCprzUhcx/QFKYF\n\tNQZtLVQtHGtxaVQqY/1Lk+hsiJqjZdmGYjyjF7KeMeAhDZNczHMMcKB0XGofgWnExCJY\n\txZfg==", "X-Gm-Message-State": "AO0yUKXZ+RdFRh734SHYT4qqnZJQly1J5hdXiwQoz+zkKxQ/OKnxMSW4\n\tuvmmjwZMJ+07UwN3dRlwAPu7rpnlLA6uuZB4", "X-Google-Smtp-Source": "AK7set/+xJFfa5XfQ1X3NJYlM+5sbQxfzgQxfDupTOsa8AFa+frRb317FOjGwqm01oWbDeR43Tq7CQ==", "X-Received": "by 2002:a05:600c:3287:b0:3dd:1c46:b92 with SMTP id\n\tt7-20020a05600c328700b003dd1c460b92mr20258851wmp.16.1676279978954; \n\tMon, 13 Feb 2023 01:19:38 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 13 Feb 2023 09:19:34 +0000", "Message-Id": "<20230213091934.2356-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] pipeline: raspberrypi: Fix error in\n\tvalidateColorSpaces", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "David Plowman <david.plowman@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This fixes a small error in the validateColorSpaces method where the\ncolour space was not being set to Raw if it had an \"unset\" (null\noption) value.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex c0dd9551..84120954 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -449,10 +449,9 @@ CameraConfiguration::Status RPiCameraConfiguration::validateColorSpaces([[maybe_\n \t\t/* First fix up raw streams to have the \"raw\" colour space. */\n \t\tif (isRaw(cfg.pixelFormat)) {\n \t\t\t/* If there was no value here, that doesn't count as \"adjusted\". */\n-\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw) {\n+\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw)\n \t\t\t\tstatus = Adjusted;\n-\t\t\t\tcfg.colorSpace = ColorSpace::Raw;\n-\t\t\t}\n+\t\t\tcfg.colorSpace = ColorSpace::Raw;\n \t\t\tcontinue;\n \t\t}\n \n", "prefixes": [ "libcamera-devel" ] }